From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GI7yIOZ2kGRY8QAASxT56A (envelope-from ) for ; Mon, 19 Jun 2023 17:40:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8Jn/IOZ2kGS+2AAA9RJhRA (envelope-from ) for ; Mon, 19 Jun 2023 17:40:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CDB11173D for ; Mon, 19 Jun 2023 17:40:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBGz6-0000Nz-Ky; Mon, 19 Jun 2023 11:40:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBGz4-0000No-HB for guix-patches@gnu.org; Mon, 19 Jun 2023 11:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBGz4-0008CL-6l for guix-patches@gnu.org; Mon, 19 Jun 2023 11:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBGz4-00035C-3L for guix-patches@gnu.org; Mon, 19 Jun 2023 11:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Jun 2023 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64155 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin , 64155@debbugs.gnu.org Cc: Liliana Marie Prikler Received: via spool by 64155-submit@debbugs.gnu.org id=B64155.168718919511833 (code B ref 64155); Mon, 19 Jun 2023 15:40:02 +0000 Received: (at 64155) by debbugs.gnu.org; 19 Jun 2023 15:39:55 +0000 Received: from localhost ([127.0.0.1]:57063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBGyx-00034f-21 for submit@debbugs.gnu.org; Mon, 19 Jun 2023 11:39:55 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:42518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBGyu-00034W-Gr for 64155@debbugs.gnu.org; Mon, 19 Jun 2023 11:39:53 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1687189190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xcHyRGQERnXevNaUl9SxXKcwbY93tAQ8bKSywLdcPoM=; b=M1MeSy02wPrQ1H6UIVjTRnVEfpvBsFlowXpFex5grZVoEbaQe18m6fUsDQ0Pttw9dlBi9X 9Pnxmy0Oe4+QXFfJgC5iYd/QZdzJ/W2yzyLmu0F62I3/4vDw6DhkLFb91SyFHicHLgM+av 8z2czPYLG31mekmF39z08H7m6FLFNZo= In-Reply-To: <87fs6ntvle.fsf@trop.in> References: <97c1eb6e58e07feaef29a1b10eeabb09f870bee1.1687117071.git.jlicht@fsfe.org> <87fs6ntvle.fsf@trop.in> Date: Mon, 19 Jun 2023 17:39:48 +0200 Message-ID: <871qi7xxyz.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687189222; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=xcHyRGQERnXevNaUl9SxXKcwbY93tAQ8bKSywLdcPoM=; b=OMArbwxQ8yGJphVwVVWpKoZgpUUyd0vPkCNIMhYDju4XHXLkGGcA1OuntQRpPI2oB1k91X AmRxKWwD12xhWhjOFccQC+MF2CylmdhG1EnMyFdvqfCpPXIxlvQ3Gu/RxI0j6TBh8XM4QR 6GRDOfaoaOkEZ+TfR+76Wm7tHVYduYoSgHbABAi1re12acFKfsy/Py68kA4jaT5GP/HEcO jlQtnefx6wQiB62efPVQKOB/Yyd42C4KCIWSwo2IdJBWS9GrZZrNlUV1lmQVg3NPechmoG /cog1deFfDE2XqlypTJL6MPDHWpPhSEmvJ46lI71GZ96jk+QzXpCS7ddk6d/1g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=M1MeSy02; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687189222; a=rsa-sha256; cv=none; b=u67OkX+Sq+BE/dxdaRslrIeAva3/D7+6IpkN5g8WGfb2Vw7cgMyWUZ1IE2iHimkywRT9HV xsIX6LFt0+MYtsjH7EAVxTGi8H+jGsQNibBgQeDCmrnKgfamuLF5lRVgto2Abar1iRUBcO 1rCz9xowuSY0Nb2W2A1ucYlM0NDfwn+chrOgnNYuTkTt53M+HhAxg3bg6dIX+DYHTP4s5/ 7264Wl06nsBqOvg2KG+v2U9t6lFC1aBB99ZYBaiPQ21gnfjJhXDUc96sM86fVXlgSrX0cL qFoRMhYIRF7u33yWwPKPfzja3y1UXH1DCgjZZDnRl/rUz2/nL8g0D6QVnrUIXg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=M1MeSy02; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2CDB11173D X-Spam-Score: -0.65 X-TUID: xfA62QnC4Npj Hi Andrew + peanut gallery, Andrew Tropin writes: > On 2023-06-18 21:38, jlicht@fsfe.org wrote: > >> From: Jelle Licht >> >> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0. >> [propagated-inputs]: Add emacs-debbugs. >> --- >> >> gnu/packages/emacs-xyz.scm | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >> index f46af73aec..08ec87b94c 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs >> (define-public emacs-piem >> (package >> (name "emacs-piem") >> - (version "0.4.0") >> + (version "0.5.0") >> (source >> (origin >> (method git-fetch) >> @@ -8346,7 +8346,7 @@ (define-public emacs-piem >> (commit (string-append "v" version)))) >> (file-name (string-append name "-" version "-checkout")) >> (sha256 >> - (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z")))) >> + (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q")))) >> (build-system emacs-build-system) >> (arguments >> (list #:phases >> @@ -8359,7 +8359,8 @@ (define-public emacs-piem >> (inputs >> (list b4)) >> (propagated-inputs >> - (list emacs-elfeed >> + (list emacs-debbugs >> + emacs-elfeed >> emacs-notmuch)) >> (home-page "https://docs.kyleam.com/piem") >> (synopsis "Glue for working with public-inbox archives") >> >> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e > > Hi Jelle! > > Thank you very much for the patch. > > IMHO, optional dependencies should not be propagated. On user side > installing additional packages is easier than transforming existing > package and removing unneeded propagated deps. Personally, I would > remove all the propagated inputs from piem and let the user install what > he needs for his particular use case. I'm of two minds, both for this particular patch, and the policy in general. I understand the point you are making, and see the elegance of offering a clean set of composable parts for users (and downstream) to compose. OTOH, it makes getting full-featured (and compiled) packages a chore, where users or downstream has to pick up the slack. Put another way; someone somewhere has to make a package variant if you want to cover all use cases. It is my understanding the guideline is (/was?) to have packages be full-featured, and offer a '-minimal' version in cases where it makes sense (e.g. bootstrapping, less-than-sane dependency graphs). If this guideline has since changed, or (in this case) the Emacs teams decides otherwise, that is something I'm obviously fine with. Some practical tips on how to make byte compilation happen would still be appreciated in that case :-). All the best, - Jelle