* [PATCH] gnu: moc: Update to 2.5.2.
@ 2017-01-11 0:23 Kei Kebreau
2017-01-11 1:00 ` Marius Bakke
0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2017-01-11 0:23 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1.1: Type: text/plain, Size: 96 bytes --]
Overdue update to moc 2.5.2. If it's reproducible for others as well, I'll
commit it to master.
[-- Attachment #1.2: 0001-gnu-moc-Update-to-2.5.2.patch --]
[-- Type: text/plain, Size: 1607 bytes --]
From 389a7e8f02b800bc937a5f7e191d1d090c980401 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Tue, 10 Jan 2017 19:18:42 -0500
Subject: [PATCH] gnu: moc: Update to 2.5.2.
* gnu/packages/music.scm (moc): Update to 2.5.2.
---
gnu/packages/music.scm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 59fd508f6..803e0a6e5 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2179,7 +2179,7 @@ with a number of bugfixes and changes to improve IT playback.")
(define-public moc
(package
(name "moc")
- (version "2.5.1")
+ (version "2.5.2")
(source (origin
(method url-fetch)
(uri (string-append "http://ftp.daper.net/pub/soft/"
@@ -2187,7 +2187,13 @@ with a number of bugfixes and changes to improve IT playback.")
name "-" version ".tar.bz2"))
(sha256
(base32
- "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v"))))
+ "026v977kwb0wbmlmf6mnik328plxg8wykfx9ryvqhirac0aq39pk"))
+ (modules '((guix build utils)))
+ (snippet
+ ;; Remove use of __DATE__ and __TIME__ for reproducibility.
+ '(substitute* "main.c"
+ (("printf \\(\" Built : %s\", __DATE__\\);") "")
+ (("printf \\(\" %s\", __TIME__\\);") "")))))
(build-system gnu-build-system)
(inputs
`(("alsa-lib" ,alsa-lib)
--
2.11.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: moc: Update to 2.5.2.
2017-01-11 0:23 [PATCH] gnu: moc: Update to 2.5.2 Kei Kebreau
@ 2017-01-11 1:00 ` Marius Bakke
2017-01-11 1:07 ` Kei Kebreau
0 siblings, 1 reply; 6+ messages in thread
From: Marius Bakke @ 2017-01-11 1:00 UTC (permalink / raw)
To: Kei Kebreau, guix-devel
[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]
Kei Kebreau <kei@openmailbox.org> writes:
> Overdue update to moc 2.5.2. If it's reproducible for others as well, I'll
> commit it to master.
> From 389a7e8f02b800bc937a5f7e191d1d090c980401 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Tue, 10 Jan 2017 19:18:42 -0500
> Subject: [PATCH] gnu: moc: Update to 2.5.2.
>
> * gnu/packages/music.scm (moc): Update to 2.5.2.
> ---
> gnu/packages/music.scm | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 59fd508f6..803e0a6e5 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2179,7 +2179,7 @@ with a number of bugfixes and changes to improve IT playback.")
> (define-public moc
> (package
> (name "moc")
> - (version "2.5.1")
> + (version "2.5.2")
> (source (origin
> (method url-fetch)
> (uri (string-append "http://ftp.daper.net/pub/soft/"
> @@ -2187,7 +2187,13 @@ with a number of bugfixes and changes to improve IT playback.")
> name "-" version ".tar.bz2"))
> (sha256
> (base32
> - "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v"))))
> + "026v977kwb0wbmlmf6mnik328plxg8wykfx9ryvqhirac0aq39pk"))
> + (modules '((guix build utils)))
> + (snippet
> + ;; Remove use of __DATE__ and __TIME__ for reproducibility.
> + '(substitute* "main.c"
> + (("printf \\(\" Built : %s\", __DATE__\\);") "")
> + (("printf \\(\" %s\", __TIME__\\);") "")))))
The commit message should mention the change to [source]. I would prefer
if this was a separate patch, unless the __DATE__ and __TIME__ macros
were introduced in this version, but no strong opinion.
LGTM!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: moc: Update to 2.5.2.
2017-01-11 1:00 ` Marius Bakke
@ 2017-01-11 1:07 ` Kei Kebreau
2017-01-11 1:32 ` Kei Kebreau
0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2017-01-11 1:07 UTC (permalink / raw)
To: Marius Bakke; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 2161 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Kei Kebreau <kei@openmailbox.org> writes:
>
>> Overdue update to moc 2.5.2. If it's reproducible for others as well, I'll
>> commit it to master.
>> From 389a7e8f02b800bc937a5f7e191d1d090c980401 Mon Sep 17 00:00:00 2001
>> From: Kei Kebreau <kei@openmailbox.org>
>> Date: Tue, 10 Jan 2017 19:18:42 -0500
>> Subject: [PATCH] gnu: moc: Update to 2.5.2.
>>
>> * gnu/packages/music.scm (moc): Update to 2.5.2.
>> ---
>> gnu/packages/music.scm | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>> index 59fd508f6..803e0a6e5 100644
>> --- a/gnu/packages/music.scm
>> +++ b/gnu/packages/music.scm
>> @@ -2179,7 +2179,7 @@ with a number of bugfixes and changes to improve IT playback.")
>> (define-public moc
>> (package
>> (name "moc")
>> - (version "2.5.1")
>> + (version "2.5.2")
>> (source (origin
>> (method url-fetch)
>> (uri (string-append "http://ftp.daper.net/pub/soft/"
>> @@ -2187,7 +2187,13 @@ with a number of bugfixes and changes to improve IT playback.")
>> name "-" version ".tar.bz2"))
>> (sha256
>> (base32
>> - "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v"))))
>> + "026v977kwb0wbmlmf6mnik328plxg8wykfx9ryvqhirac0aq39pk"))
>> + (modules '((guix build utils)))
>> + (snippet
>> + ;; Remove use of __DATE__ and __TIME__ for reproducibility.
>> + '(substitute* "main.c"
>> + (("printf \\(\" Built : %s\", __DATE__\\);") "")
>> + (("printf \\(\" %s\", __TIME__\\);") "")))))
>
> The commit message should mention the change to [source]. I would prefer
> if this was a separate patch, unless the __DATE__ and __TIME__ macros
> were introduced in this version, but no strong opinion.
>
> LGTM!
Thanks for the review! The macros you mention were indeed introduced in
this version. I'll modify the commit message to include the changes to
[source] and push it to master.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: moc: Update to 2.5.2.
2017-01-11 1:07 ` Kei Kebreau
@ 2017-01-11 1:32 ` Kei Kebreau
2017-01-11 3:03 ` Kei Kebreau
0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2017-01-11 1:32 UTC (permalink / raw)
To: Marius Bakke; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 2416 bytes --]
Kei Kebreau <kei@openmailbox.org> writes:
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Kei Kebreau <kei@openmailbox.org> writes:
>>
>>> Overdue update to moc 2.5.2. If it's reproducible for others as well, I'll
>>> commit it to master.
>>> From 389a7e8f02b800bc937a5f7e191d1d090c980401 Mon Sep 17 00:00:00 2001
>>> From: Kei Kebreau <kei@openmailbox.org>
>>> Date: Tue, 10 Jan 2017 19:18:42 -0500
>>> Subject: [PATCH] gnu: moc: Update to 2.5.2.
>>>
>>> * gnu/packages/music.scm (moc): Update to 2.5.2.
>>> ---
>>> gnu/packages/music.scm | 10 ++++++++--
>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>>> index 59fd508f6..803e0a6e5 100644
>>> --- a/gnu/packages/music.scm
>>> +++ b/gnu/packages/music.scm
>>> @@ -2179,7 +2179,7 @@ with a number of bugfixes and changes to improve IT playback.")
>>> (define-public moc
>>> (package
>>> (name "moc")
>>> - (version "2.5.1")
>>> + (version "2.5.2")
>>> (source (origin
>>> (method url-fetch)
>>> (uri (string-append "http://ftp.daper.net/pub/soft/"
>>> @@ -2187,7 +2187,13 @@ with a number of bugfixes and changes to improve IT playback.")
>>> name "-" version ".tar.bz2"))
>>> (sha256
>>> (base32
>>> - "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v"))))
>>> + "026v977kwb0wbmlmf6mnik328plxg8wykfx9ryvqhirac0aq39pk"))
>>> + (modules '((guix build utils)))
>>> + (snippet
>>> + ;; Remove use of __DATE__ and __TIME__ for reproducibility.
>>> + '(substitute* "main.c"
>>> + (("printf \\(\" Built : %s\", __DATE__\\);") "")
>>> + (("printf \\(\" %s\", __TIME__\\);") "")))))
>>
>> The commit message should mention the change to [source]. I would prefer
>> if this was a separate patch, unless the __DATE__ and __TIME__ macros
>> were introduced in this version, but no strong opinion.
>>
>> LGTM!
>
> Thanks for the review! The macros you mention were indeed introduced in
> this version. I'll modify the commit message to include the changes to
> [source] and push it to master.
Does this commit message look good to you?
* gnu/packages/music.scm (moc): Update to 2.5.2.
[source](modules, snippet): Remove timestamps from the output.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: moc: Update to 2.5.2.
2017-01-11 1:32 ` Kei Kebreau
@ 2017-01-11 3:03 ` Kei Kebreau
2017-01-11 17:39 ` Marius Bakke
0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2017-01-11 3:03 UTC (permalink / raw)
To: Marius Bakke; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 2773 bytes --]
Kei Kebreau <kei@openmailbox.org> writes:
> Kei Kebreau <kei@openmailbox.org> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>
>>>> Overdue update to moc 2.5.2. If it's reproducible for others as well, I'll
>>>> commit it to master.
>>>> From 389a7e8f02b800bc937a5f7e191d1d090c980401 Mon Sep 17 00:00:00 2001
>>>> From: Kei Kebreau <kei@openmailbox.org>
>>>> Date: Tue, 10 Jan 2017 19:18:42 -0500
>>>> Subject: [PATCH] gnu: moc: Update to 2.5.2.
>>>>
>>>> * gnu/packages/music.scm (moc): Update to 2.5.2.
>>>> ---
>>>> gnu/packages/music.scm | 10 ++++++++--
>>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>>>> index 59fd508f6..803e0a6e5 100644
>>>> --- a/gnu/packages/music.scm
>>>> +++ b/gnu/packages/music.scm
>>>> @@ -2179,7 +2179,7 @@ with a number of bugfixes and changes to improve IT playback.")
>>>> (define-public moc
>>>> (package
>>>> (name "moc")
>>>> - (version "2.5.1")
>>>> + (version "2.5.2")
>>>> (source (origin
>>>> (method url-fetch)
>>>> (uri (string-append "http://ftp.daper.net/pub/soft/"
>>>> @@ -2187,7 +2187,13 @@ with a number of bugfixes and changes to improve IT playback.")
>>>> name "-" version ".tar.bz2"))
>>>> (sha256
>>>> (base32
>>>> - "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v"))))
>>>> + "026v977kwb0wbmlmf6mnik328plxg8wykfx9ryvqhirac0aq39pk"))
>>>> + (modules '((guix build utils)))
>>>> + (snippet
>>>> + ;; Remove use of __DATE__ and __TIME__ for reproducibility.
>>>> + '(substitute* "main.c"
>>>> + (("printf \\(\" Built : %s\", __DATE__\\);") "")
>>>> + (("printf \\(\" %s\", __TIME__\\);") "")))))
>>>
>>> The commit message should mention the change to [source]. I would prefer
>>> if this was a separate patch, unless the __DATE__ and __TIME__ macros
>>> were introduced in this version, but no strong opinion.
>>>
>>> LGTM!
>>
>> Thanks for the review! The macros you mention were indeed introduced in
>> this version. I'll modify the commit message to include the changes to
>> [source] and push it to master.
>
> Does this commit message look good to you?
>
> * gnu/packages/music.scm (moc): Update to 2.5.2.
> [source](modules, snippet): Remove timestamps from the output.
Already pushed! Though I have another question while I have your
attention:
Does the ghc binary work for you? I get complaints about the ncursesw
library missing. I suspect it has to do with the LD_LIBRARY_PATH, as
seen in the ghc package definition.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: moc: Update to 2.5.2.
2017-01-11 3:03 ` Kei Kebreau
@ 2017-01-11 17:39 ` Marius Bakke
0 siblings, 0 replies; 6+ messages in thread
From: Marius Bakke @ 2017-01-11 17:39 UTC (permalink / raw)
To: Kei Kebreau; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
Kei Kebreau <kei@openmailbox.org> writes:
> Thanks for the review! The macros you mention were indeed introduced in
> this version.
Wow, good catch!
> Does this commit message look good to you?
>
> * gnu/packages/music.scm (moc): Update to 2.5.2.
> [source](modules, snippet): Remove timestamps from the output.
I'd just write "[source]: Add snippet to make it reproducible.".
> Does the ghc binary work for you? I get complaints about the ncursesw
> library missing. I suspect it has to do with the LD_LIBRARY_PATH, as
> seen in the ghc package definition.
Looks like you're right. I've filed a bug report:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25421
Thank you!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-11 17:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-11 0:23 [PATCH] gnu: moc: Update to 2.5.2 Kei Kebreau
2017-01-11 1:00 ` Marius Bakke
2017-01-11 1:07 ` Kei Kebreau
2017-01-11 1:32 ` Kei Kebreau
2017-01-11 3:03 ` Kei Kebreau
2017-01-11 17:39 ` Marius Bakke
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.