From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: moc: Update to 2.5.2. Date: Tue, 10 Jan 2017 20:32:38 -0500 Message-ID: <861swaz8i1.fsf@openmailbox.org> References: <86lguizbpt.fsf@openmailbox.org> <87k2a28l7t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <86h956z9ng.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cR7mT-0004Rl-GM for guix-devel@gnu.org; Tue, 10 Jan 2017 20:32:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cR7mP-0007fq-Bz for guix-devel@gnu.org; Tue, 10 Jan 2017 20:32:49 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:56873) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cR7mP-0007f8-3g for guix-devel@gnu.org; Tue, 10 Jan 2017 20:32:45 -0500 In-Reply-To: <86h956z9ng.fsf@openmailbox.org> (Kei Kebreau's message of "Tue, 10 Jan 2017 20:07:47 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Kei Kebreau writes: > Marius Bakke writes: > >> Kei Kebreau writes: >> >>> Overdue update to moc 2.5.2. If it's reproducible for others as well, I'll >>> commit it to master. >>> From 389a7e8f02b800bc937a5f7e191d1d090c980401 Mon Sep 17 00:00:00 2001 >>> From: Kei Kebreau >>> Date: Tue, 10 Jan 2017 19:18:42 -0500 >>> Subject: [PATCH] gnu: moc: Update to 2.5.2. >>> >>> * gnu/packages/music.scm (moc): Update to 2.5.2. >>> --- >>> gnu/packages/music.scm | 10 ++++++++-- >>> 1 file changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm >>> index 59fd508f6..803e0a6e5 100644 >>> --- a/gnu/packages/music.scm >>> +++ b/gnu/packages/music.scm >>> @@ -2179,7 +2179,7 @@ with a number of bugfixes and changes to improve IT playback.") >>> (define-public moc >>> (package >>> (name "moc") >>> - (version "2.5.1") >>> + (version "2.5.2") >>> (source (origin >>> (method url-fetch) >>> (uri (string-append "http://ftp.daper.net/pub/soft/" >>> @@ -2187,7 +2187,13 @@ with a number of bugfixes and changes to improve IT playback.") >>> name "-" version ".tar.bz2")) >>> (sha256 >>> (base32 >>> - "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v")))) >>> + "026v977kwb0wbmlmf6mnik328plxg8wykfx9ryvqhirac0aq39pk")) >>> + (modules '((guix build utils))) >>> + (snippet >>> + ;; Remove use of __DATE__ and __TIME__ for reproducibility. >>> + '(substitute* "main.c" >>> + (("printf \\(\" Built : %s\", __DATE__\\);") "") >>> + (("printf \\(\" %s\", __TIME__\\);") ""))))) >> >> The commit message should mention the change to [source]. I would prefer >> if this was a separate patch, unless the __DATE__ and __TIME__ macros >> were introduced in this version, but no strong opinion. >> >> LGTM! > > Thanks for the review! The macros you mention were indeed introduced in > this version. I'll modify the commit message to include the changes to > [source] and push it to master. Does this commit message look good to you? * gnu/packages/music.scm (moc): Update to 2.5.2. [source](modules, snippet): Remove timestamps from the output. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlh1izYACgkQ5qXuPBlG eg05aRAAworcsPYvu+Pedf/8DOIEWRhdong6Y0SPvv4hf4nKEAMhem3754Uaeoun eqOpTNEEWPdTygu6UdX9pMKL9dpdt6y7KRJvYQOXPxdOT6y7hsqmJYl7FEg4+LyM 1hluULKQuxwiyZzVprwl5hnd0hXrLFj+FJdzXnUoITbSTgV6MrtdMNo8OB+bsLFJ f7p4U4vbzdPEmpxVvwRZ3HYxnLwkT+Hb+u0lqDhYzdtQS9okc6oMpAywarmX7lbi JXjfTD1/YPwoqueJ3s77RU5vebpytKlqt1QuJbsWdULOrO+2HYXcm1PFYfe8Y0lG QqKwnvvJx3AXdiPWTm3PBHAHlV8C61r/StXpHuThwcWrALQG9use3euv6D+AJwu1 6mdG+smTurw68HIUnEnPk1p+YlLBIcU3Ry2IubPGVRhe+e52smiUaIQVFPFY7Nk3 AzH/lqQljfO9HspuNUrOgb5NM26WidnR4EnnsYjn2U0SRD3UOJ3NJiks8wTa8ykz WK/uKjlU2WouIePnXgfere78Lo/CarD56vSLkUyBOSVhgDMo2bdF+l7y1RGTqdOB ufbyaDzP4yuue0Y9JizEOwI7+vXyMgWnezchdz0gnJuTiJr+ipzAgvhzuO3c9LwU TByfW5J7tHS8v6HaDgFdCFSTNubecxqPxE6e6/PaozQORkg49fg= =qKos -----END PGP SIGNATURE----- --=-=-=--