From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: moc: Update to 2.5.2. Date: Wed, 11 Jan 2017 02:00:06 +0100 Message-ID: <87k2a28l7t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <86lguizbpt.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cR7Gw-0004XF-EC for guix-devel@gnu.org; Tue, 10 Jan 2017 20:00:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cR7Gr-0005mG-Pb for guix-devel@gnu.org; Tue, 10 Jan 2017 20:00:14 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45634) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cR7Gr-0005lY-Iv for guix-devel@gnu.org; Tue, 10 Jan 2017 20:00:09 -0500 In-Reply-To: <86lguizbpt.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau , guix-devel@gnu.org --=-=-= Content-Type: text/plain Kei Kebreau writes: > Overdue update to moc 2.5.2. If it's reproducible for others as well, I'll > commit it to master. > From 389a7e8f02b800bc937a5f7e191d1d090c980401 Mon Sep 17 00:00:00 2001 > From: Kei Kebreau > Date: Tue, 10 Jan 2017 19:18:42 -0500 > Subject: [PATCH] gnu: moc: Update to 2.5.2. > > * gnu/packages/music.scm (moc): Update to 2.5.2. > --- > gnu/packages/music.scm | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm > index 59fd508f6..803e0a6e5 100644 > --- a/gnu/packages/music.scm > +++ b/gnu/packages/music.scm > @@ -2179,7 +2179,7 @@ with a number of bugfixes and changes to improve IT playback.") > (define-public moc > (package > (name "moc") > - (version "2.5.1") > + (version "2.5.2") > (source (origin > (method url-fetch) > (uri (string-append "http://ftp.daper.net/pub/soft/" > @@ -2187,7 +2187,13 @@ with a number of bugfixes and changes to improve IT playback.") > name "-" version ".tar.bz2")) > (sha256 > (base32 > - "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v")))) > + "026v977kwb0wbmlmf6mnik328plxg8wykfx9ryvqhirac0aq39pk")) > + (modules '((guix build utils))) > + (snippet > + ;; Remove use of __DATE__ and __TIME__ for reproducibility. > + '(substitute* "main.c" > + (("printf \\(\" Built : %s\", __DATE__\\);") "") > + (("printf \\(\" %s\", __TIME__\\);") ""))))) The commit message should mention the change to [source]. I would prefer if this was a separate patch, unless the __DATE__ and __TIME__ macros were introduced in this version, but no strong opinion. LGTM! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlh1g5YACgkQoqBt8qM6 VPo5hQf/V7npSSHKdP2q7ARaNBfzzIgv9L2lF8k9LHyi2zMdMIeheL2AmeeIiOTI Xkome/g9GMcMRo11zrm89N7PQnyEJE4N4dPgjfe1x2+ujsRspPTQB9dndc7IZBEP wFBjLaVYHAL+uJdpIjec7NBk2rR37/al/YxY2iMjMoP0BbTlHiqDYwdhyJ69DKcZ lfikCXFA8Y3C69ay+pRnCFdmDldVc5JG16JXJ/4BEnxsdfmPRX8d+VeAFDz4oXBq e6cLd/UHdxg1doNzhPoTbsDse7zEF+9R6GxoXVKalp3NuzYjkd+69qxJzeaNmHbO UcjI14bFa7HP6Rb0qE/IQCKvUhiP2Q== =Kodz -----END PGP SIGNATURE----- --=-=-=--