From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 62309@debbugs.gnu.org
Subject: [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10.
Date: Wed, 22 Mar 2023 14:23:56 -0400 [thread overview]
Message-ID: <87v8isfxvn.fsf@gmail.com> (raw)
In-Reply-To: <87zg86q7jo.fsf@jpoiret.xyz> (Josselin Poiret's message of "Tue, 21 Mar 2023 19:32:43 +0100")
Hi,
Josselin Poiret <dev@jpoiret.xyz> writes:
> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> FIXME and other similar comment prefixes are more conventionally used
>> with a colon (FIXME: ...), I think. I also prefer to keep the patch
>> origin tracking in the patch itself (and 'guix lint' checks for that
>> nowadays, at least in some cases). The patch should fail to apply when
>> after it's included in a release.
>
> Right, I added this FIXME in the heat of the moment. I don't really
> mind either way, although I find it nice that when it fails to apply,
> anyone can see this comment and conclude that it should be ok to remove
> (as opposed to some patches failing because they're not up to date).
> What do you mean by "patch origin tracking", and it being taken care of
> by `guix lint`?
>
>> Feel free to push with these suggested changes.
>
> I don't know if this was directed at me or committers, but I'll just add
> that I do not have commit rights, if anyone else wants to have a look
> and push :)
It was directed at you, I thought you already had commit rights :-).
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-03-22 18:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 22:23 [bug#62309] [PATCH core-updates 0/2] Fix qemu build Josselin Poiret via Guix-patches via
2023-03-20 22:26 ` [bug#62309] [PATCH core-updates 1/2] opensbi: Build with default gcc, with microarch rv64g Josselin Poiret via Guix-patches via
2023-03-21 1:29 ` [bug#62309] [PATCH core-updates 0/2] Fix qemu build Maxim Cournoyer
2023-03-21 8:59 ` [bug#62309] [PATCH core-updates v2 " Josselin Poiret via Guix-patches via
2023-03-21 8:59 ` [bug#62309] [PATCH core-updates v2 1/2] opensbi: Build with default gcc, with microarch rv64g Josselin Poiret via Guix-patches via
2023-03-21 16:07 ` Maxim Cournoyer
2023-03-21 8:59 ` [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10 Josselin Poiret via Guix-patches via
2023-03-21 16:14 ` Maxim Cournoyer
2023-03-21 18:32 ` Josselin Poiret via Guix-patches via
2023-03-22 18:23 ` Maxim Cournoyer [this message]
2023-03-26 20:30 ` bug#62309: [PATCH core-updates 0/2] Fix qemu build Ludovic Courtès
2023-03-20 22:26 ` [bug#62309] [PATCH core-updates 2/2] u-boot: Fix build under Python 3.10 Josselin Poiret via Guix-patches via
2023-03-21 1:32 ` [bug#62309] [PATCH core-updates 0/2] Fix qemu build Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8isfxvn.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=62309@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.