From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mGr8KAxIG2S3DQAASxT56A (envelope-from ) for ; Wed, 22 Mar 2023 19:25:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aDQ2KAxIG2TejAAAG6o9tA (envelope-from ) for ; Wed, 22 Mar 2023 19:25:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 563751E5E3 for ; Wed, 22 Mar 2023 19:25:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pf38y-0003QJ-Uh; Wed, 22 Mar 2023 14:25:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf38x-0003QB-3b for guix-patches@gnu.org; Wed, 22 Mar 2023 14:25:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pf38w-0004Qd-QA for guix-patches@gnu.org; Wed, 22 Mar 2023 14:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pf38w-0008GB-J7 for guix-patches@gnu.org; Wed, 22 Mar 2023 14:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Mar 2023 18:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62309 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 62309@debbugs.gnu.org Received: via spool by 62309-submit@debbugs.gnu.org id=B62309.167950944531678 (code B ref 62309); Wed, 22 Mar 2023 18:25:02 +0000 Received: (at 62309) by debbugs.gnu.org; 22 Mar 2023 18:24:05 +0000 Received: from localhost ([127.0.0.1]:36710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf381-0008Es-Ck for submit@debbugs.gnu.org; Wed, 22 Mar 2023 14:24:05 -0400 Received: from mail-qt1-f176.google.com ([209.85.160.176]:38818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf37z-0008EM-Rr for 62309@debbugs.gnu.org; Wed, 22 Mar 2023 14:24:04 -0400 Received: by mail-qt1-f176.google.com with SMTP id w25so1234343qtc.5 for <62309@debbugs.gnu.org>; Wed, 22 Mar 2023 11:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679509438; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EIgNWgGzf1+cBM+t7LXLwqeQumvJ40Ml98tjfVszLGM=; b=Ak9QXJ7nfFIsGrEdMdpToX6/JB+GhnaOuFdFr1HjqIl4DhvhxpFKhGGO//kDK/VRwC +kFlO3xBsceWY0djADRxRkzrxBm0vHJJNFX9QunvCO/SwNdp5+EGLLnt14RYqpwT23Pw Jp8F0NLn8eCkMib4MIFIOG/BzD6gOKAmmNLb5qcLt6Ubp0dXtHobYuVX1YcyFYq6jjwA UKAxPUTkCkhb1r28BDA+3qI8UjBCk8CK76JY4Rid7RQQrBaKyZ3xkTTCW2G2yflgi9yo FG3c1rFjyJxSAjaopeiy1NB9ErOCMXKoE6hk9QtEUm/z5Z0FPyDSMBFm0DkhJcFkjmCD WgZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679509438; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EIgNWgGzf1+cBM+t7LXLwqeQumvJ40Ml98tjfVszLGM=; b=BEybotkNG4jrcEa8a++jKJeQlW7k7JRXvAduoNqyoVZfqaHdVpz6FMnkeztyg0PP99 DTjusc3OeR2f975SCkilOXFHpN4XgT8bKosabTMBRzj4ZruvFdkxcKOEWcATT9w2bFBO SijQaXEFAwY2Vxkq6QbcODZV83zly17XcDkbd0oGAGkRhy9k+go/lwW5zS7xmdrbZ5ib FKMtkFPSD/4z+Sny75qbDLp8dZ0gcWCNpdQAg0nkL3yq/4HyAUbuab95aiTNuKShl7zu F18vtsSjy781bBSmySrRmzvRTWtpzJQLwHMte7EMgxBAAgd55I/8fDpFT0v4BGTLBPSg wNXg== X-Gm-Message-State: AO0yUKUWBJWj37sD75XnGYc5ui1oozhF+uW3riQjAK1jWIRrYxEb1VWZ BjU0OzirQSN8OBmt9TliNlbFLX9C2DYmkQ== X-Google-Smtp-Source: AK7set+dKyKeRft+YHKzNnP1mOjTtbJ+gFUZ0uNdEv0XsDjb4zWHlaDOfveJ0XjQzWHlij2HATj1eA== X-Received: by 2002:a05:622a:1ba6:b0:3a8:e35:258f with SMTP id bp38-20020a05622a1ba600b003a80e35258fmr7250962qtb.31.1679509438228; Wed, 22 Mar 2023 11:23:58 -0700 (PDT) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id h13-20020ac8744d000000b003e248cc2986sm5366298qtr.43.2023.03.22.11.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 11:23:57 -0700 (PDT) From: Maxim Cournoyer References: <1896443a4ab3038fdbd1077a625178eeae1f737b.1679389017.git.dev@jpoiret.xyz> <87zg86nksl.fsf@gmail.com> <87zg86q7jo.fsf@jpoiret.xyz> Date: Wed, 22 Mar 2023 14:23:56 -0400 In-Reply-To: <87zg86q7jo.fsf@jpoiret.xyz> (Josselin Poiret's message of "Tue, 21 Mar 2023 19:32:43 +0100") Message-ID: <87v8isfxvn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679509516; a=rsa-sha256; cv=none; b=t6d9VKPgwNKrLeJ4Vri4G6WZ4zyKCbG5puay8LO+pkg5F41PCo9FFz2JjC1I7vVWlw07Xe usuJTAF8Hk+try8Eq95gnZicvdZlcS34FRvEeYCtCMFFc8s+o6Fj/nV7h+AUcpgipBSSdR XeVVRfOfy/t2ZIz4SNbQqTgRIGHhOWG1DApRp7QPsRtQnZNq9wOWeSiXMDuV0rQG35SkvH INJbkNIkOlx30eO8AVLsFbJYSsAcaRnUC59eKyo1+/0MPh/hrspdaQF+747t9IokIZ052S 0VgFY+k8WjZe54xmqJDCIpjtAem6ADBD/sHs8kPW8lVEzw6bwJr4ilAaJ3+Xww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Ak9QXJ7n; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679509516; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=EIgNWgGzf1+cBM+t7LXLwqeQumvJ40Ml98tjfVszLGM=; b=bxo+Rt3co4r37pnXTeQw7pUKM37WHnbde1PyFuPpicBSKPRqLpx6P76aOra+YClwOvL7rT cI2JcMjHgurPyWWENG1W/mBOfPbQw+jnwVnsTOH/hFP+z++V4yoyxFyPai96q1P11vXFeO CTqosHlFHptpD8Ee6jD5rJhW0qPVlbN9iNJ+E2mID1v30HcVH1HA+HmNmoBUOn2cv4YSmo je8tVkNzGSsMNl60PvF7kVFtkQeH14hKHIGHanR6qxaqxqFskrbmmGwOW4eA5bJ6Hhbsdw hU5vDz1/fWZhpSghE0gtTa2naIVMUBiYkB+Imi9cV/KswQMIwVZUjGU24P4+3g== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Ak9QXJ7n; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.65 X-Spam-Score: -0.65 X-Migadu-Queue-Id: 563751E5E3 X-TUID: 6iQ/iNCYeJ+N Hi, Josselin Poiret writes: > Hi Maxim, > > Maxim Cournoyer writes: > >> FIXME and other similar comment prefixes are more conventionally used >> with a colon (FIXME: ...), I think. I also prefer to keep the patch >> origin tracking in the patch itself (and 'guix lint' checks for that >> nowadays, at least in some cases). The patch should fail to apply when >> after it's included in a release. > > Right, I added this FIXME in the heat of the moment. I don't really > mind either way, although I find it nice that when it fails to apply, > anyone can see this comment and conclude that it should be ok to remove > (as opposed to some patches failing because they're not up to date). > What do you mean by "patch origin tracking", and it being taken care of > by `guix lint`? > >> Feel free to push with these suggested changes. > > I don't know if this was directed at me or committers, but I'll just add > that I do not have commit rights, if anyone else wants to have a look > and push :) It was directed at you, I thought you already had commit rights :-). -- Thanks, Maxim