all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 62309@debbugs.gnu.org
Subject: [bug#62309] [PATCH core-updates 0/2] Fix qemu build
Date: Mon, 20 Mar 2023 21:29:45 -0400	[thread overview]
Message-ID: <87pm923n92.fsf_-_@gmail.com> (raw)
In-Reply-To: <b08b5b8076d362a44f0043c50e7c999be0d5b9f0.1679350685.git.dev@jpoiret.xyz> (Josselin Poiret's message of "Mon, 20 Mar 2023 23:26:36 +0100")

Hi Josselin,

Josselin Poiret <dev@jpoiret.xyz> writes:

> * gnu/packages/firmware.scm (make-opensbi-package): Do it.

Nitpick: The change log should state the change; it took me an instant
to realize the "Do it" meant implement the git summary description.  The
summary can be more brief (or it could say the same if it fits under 80
chars).

>  gnu/packages/firmware.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
> index 956ece5d6d..9b9443effe 100644
> --- a/gnu/packages/firmware.scm
> +++ b/gnu/packages/firmware.scm
> @@ -486,7 +486,7 @@ (define* (make-opensbi-package platform name #:optional (arch "riscv64"))
>      (native-inputs
>       `(,@(if (and (not (string-prefix? "riscv64" (%current-system)))
>                    (string-prefix? "riscv64" arch))
> -           `(("cross-gcc" ,(cross-gcc "riscv64-linux-gnu" #:xgcc gcc-7))
> +           `(("cross-gcc" ,(cross-gcc "riscv64-linux-gnu"))
>               ("cross-binutils" ,(cross-binutils "riscv64-linux-gnu")))
>             '())))
>      (arguments
> @@ -499,6 +499,8 @@ (define* (make-opensbi-package platform name #:optional (arch "riscv64"))
>                                  `("CC=gcc"))
>                            "FW_PAYLOAD=n"
>                            "V=1")
> +       ;; fence.i instructions are used, so we need a non-default micro arch
> +       #:configure-flags (list "-march=rv64g")

I don't quite understand, but then I don't know what is opensbi either,
so I'd have to read more.  Or if you can expound a bit that comment for
neophytes like me, that'd be nice.

Thanks for the fix!

-- 
Maxim




  reply	other threads:[~2023-03-21  1:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 22:23 [bug#62309] [PATCH core-updates 0/2] Fix qemu build Josselin Poiret via Guix-patches via
2023-03-20 22:26 ` [bug#62309] [PATCH core-updates 1/2] opensbi: Build with default gcc, with microarch rv64g Josselin Poiret via Guix-patches via
2023-03-21  1:29   ` Maxim Cournoyer [this message]
2023-03-21  8:59     ` [bug#62309] [PATCH core-updates v2 0/2] Fix qemu build Josselin Poiret via Guix-patches via
2023-03-21  8:59       ` [bug#62309] [PATCH core-updates v2 1/2] opensbi: Build with default gcc, with microarch rv64g Josselin Poiret via Guix-patches via
2023-03-21 16:07         ` Maxim Cournoyer
2023-03-21  8:59       ` [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10 Josselin Poiret via Guix-patches via
2023-03-21 16:14         ` Maxim Cournoyer
2023-03-21 18:32           ` Josselin Poiret via Guix-patches via
2023-03-22 18:23             ` Maxim Cournoyer
2023-03-26 20:30           ` bug#62309: [PATCH core-updates 0/2] Fix qemu build Ludovic Courtès
2023-03-20 22:26 ` [bug#62309] [PATCH core-updates 2/2] u-boot: Fix build under Python 3.10 Josselin Poiret via Guix-patches via
2023-03-21  1:32   ` [bug#62309] [PATCH core-updates 0/2] Fix qemu build Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm923n92.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=62309@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.