all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 62309@debbugs.gnu.org
Subject: [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10.
Date: Tue, 21 Mar 2023 12:14:50 -0400	[thread overview]
Message-ID: <87zg86nksl.fsf@gmail.com> (raw)
In-Reply-To: <1896443a4ab3038fdbd1077a625178eeae1f737b.1679389017.git.dev@jpoiret.xyz> (Josselin Poiret's message of "Tue, 21 Mar 2023 09:59:37 +0100")

Hi Josselin,

Josselin Poiret <dev@jpoiret.xyz> writes:

> * gnu/packages/patches/u-boot-fix-build-python-3.10.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register it.
> * gnu/packages/bootloaders.scm (u-boot): Apply patch.
> ---
>  gnu/local.mk                                  |  1 +
>  gnu/packages/bootloaders.scm                  |  3 ++
>  .../u-boot-fix-build-python-3.10.patch        | 35 +++++++++++++++++++
>  3 files changed, 39 insertions(+)
>  create mode 100644 gnu/packages/patches/u-boot-fix-build-python-3.10.patch
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 058b23c683..73cf7b89a1 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -1936,6 +1936,7 @@ dist_patch_DATA =						\
>    %D%/packages/patches/tuxpaint-stamps-path.patch		\
>    %D%/packages/patches/twinkle-bcg729.patch			\
>    %D%/packages/patches/u-boot-allow-disabling-openssl.patch	\
> +  %D%/packages/patches/u-boot-fix-build-python-3.10.patch	\
>    %D%/packages/patches/u-boot-infodocs-target.patch		\
>    %D%/packages/patches/u-boot-patman-guix-integration.patch	\
>    %D%/packages/patches/u-boot-nintendo-nes-serial.patch		\
> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
> index ac269807be..457f3b3994 100644
> --- a/gnu/packages/bootloaders.scm
> +++ b/gnu/packages/bootloaders.scm
> @@ -655,6 +655,9 @@ (define u-boot
>                       %u-boot-allow-disabling-openssl-patch
>                       %u-boot-sifive-prevent-relocating-initrd-fdt
>                       %u-boot-rk3399-enable-emmc-phy-patch
> +                     ;; FIXME The following patch is backported from 2023.01,
> +                     ;; remove when updating.

FIXME and other similar comment prefixes are more conventionally used
with a colon (FIXME: ...), I think.  I also prefer to keep the patch
origin tracking in the patch itself (and 'guix lint' checks for that
nowadays, at least in some cases).  The patch should fail to apply when
after it's included in a release.

Feel free to push with these suggested changes.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-03-21 16:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 22:23 [bug#62309] [PATCH core-updates 0/2] Fix qemu build Josselin Poiret via Guix-patches via
2023-03-20 22:26 ` [bug#62309] [PATCH core-updates 1/2] opensbi: Build with default gcc, with microarch rv64g Josselin Poiret via Guix-patches via
2023-03-21  1:29   ` [bug#62309] [PATCH core-updates 0/2] Fix qemu build Maxim Cournoyer
2023-03-21  8:59     ` [bug#62309] [PATCH core-updates v2 " Josselin Poiret via Guix-patches via
2023-03-21  8:59       ` [bug#62309] [PATCH core-updates v2 1/2] opensbi: Build with default gcc, with microarch rv64g Josselin Poiret via Guix-patches via
2023-03-21 16:07         ` Maxim Cournoyer
2023-03-21  8:59       ` [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10 Josselin Poiret via Guix-patches via
2023-03-21 16:14         ` Maxim Cournoyer [this message]
2023-03-21 18:32           ` Josselin Poiret via Guix-patches via
2023-03-22 18:23             ` Maxim Cournoyer
2023-03-26 20:30           ` bug#62309: [PATCH core-updates 0/2] Fix qemu build Ludovic Courtès
2023-03-20 22:26 ` [bug#62309] [PATCH core-updates 2/2] u-boot: Fix build under Python 3.10 Josselin Poiret via Guix-patches via
2023-03-21  1:32   ` [bug#62309] [PATCH core-updates 0/2] Fix qemu build Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg86nksl.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=62309@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.