Re: [PATCH] gnu: make-bootstrap: Produce the correct %glibc-bootstrap-tarball for Hurd systems.

[ludo@gnu.org (Ludovic Courtès)]

Manolis Ragkousis <manolis837@gmail.com> skribis:

> Here is the updated patch with a small modification at the regexp. Now
> it copies all the .so and .a files,
> needed on a hurd system, to the stripped glibc (libcrt_nonshared.a,
> libmachuser.so, libhurduser.so).

OK for copying lib{hurd,mach}user.so, of course.

However, I think the .a files should be omitted.  What was the
motivation?

Also, I think any non-trivial change should be in a subsequent patch, so
that it’s easy to distinguish between the refactoring (moving code from
one file to another) and the actual functional change.

> +                          "^(crt.*|ld.*|lib(c|m|dl|rt|pthread|nsl|util|machuser|
> +hurduser).*\\.so(\\..*)?|libc(rt|)_nonshared\\.a)$"))

There should be a backslash at the end of the first line so that
carriage return doesn’t appear literally in the regexp.

Thanks,
Ludo’.