Re: [PATCH] gnu: make-bootstrap: Produce the correct %glibc-bootstrap-tarball for Hurd systems.

[ludo@gnu.org (Ludovic Courtès)]

Hello Manolis!

Manolis Ragkousis <manolis837@gmail.com> skribis:

> This is an old patch which I had forgotten I hadn't pushed to
> core-updates back then.
>
> This is the updated version with your suggestions and checked that it
> works with latest core-updates.

I believe it can go to master since it does not trigger rebuilds.

> From 0e21f4484f67dfd6ed132e9e5b5934f3098c98b3 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Wed, 30 Nov 2016 16:49:48 +0200
> Subject: [PATCH] gnu: make-bootstrap: Produce the correct
>  %glibc-bootstrap-tarball for Hurd systems.
>
> * gnu/packages/make-bootstrap.scm (%glibc-bootstrap-tarball): Make it a procedure.
>   (%glibc-stripped): Make it a procedure and move the kernel specific part from
>   here to ...
> * guix/build/make-bootstrap.scm (make-stripped-libc): ... here. New file.
> * Makefile.am (MODULES): Add it.

[...]

>         ;; `cross-libc' already returns a cross libc, so clear
>         ;; %CURRENT-TARGET-SYSTEM.
>         (parameterize ((%current-target-system #f))
> -         (cross-libc target)))))
> +         (cross-libc target )))))

Nope.  :-)

Apart from that it LGTM!

Thank you,
Ludo’.