From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: make-bootstrap: Produce the correct %glibc-bootstrap-tarball for Hurd systems.
Date: Tue, 26 Jul 2016 16:44:09 +0200 [thread overview]
Message-ID: <87invs793a.fsf@gnu.org> (raw)
In-Reply-To: <fc10f3ef-3d88-68fd-c5d0-fa1dc125f4ce@gmail.com> (Manolis Ragkousis's message of "Tue, 26 Jul 2016 16:41:36 +0300")
Hello!
Manolis Ragkousis <manolis837@gmail.com> skribis:
> From a8541a554f9e1653c78b6b45f323426e330d5215 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Mon, 25 Jul 2016 16:53:40 +0300
> Subject: [PATCH] gnu: make-bootstrap: Produce the correct
> %glibc-bootstrap-tarball for Hurd systems.
>
> * gnu/packages/make-bootstrap.scm (%glibc-bootstrap-tarball): Make it a procedure.
> (%glibc-stripped): Make it a procedure and move the kernel specific part from
> here to ...
> * guix/build/make-bootstrap.scm (make-stripped-libc): ... here. New file.
> * Makefile.am (MODULES): Add it.
I like this new (guix build make-bootstrap) module!
It would be ideal if the part that introduces this module were a patch
separate from the Hurd part. However, that’s too much of a trouble to
split the patch, it’s fine this way.
> +(define (make-stripped-libc output libc kernel-headers)
> + "Copy to OUTPUT the subset of LIBC and KERNEL-HEADERS that is needed
> + when producing a bootstrap libc."
^
Please align to the left.
> + (for-each (lambda (file)
> + (copy-file (string-append kernel-headers "/include/linux/" file)
> + (string-append incdir "/linux/"
> + (basename file))))
This could be written as:
(install-file (string-append kernel-headers "/include/linux/" file)
(string-append incdir "/linux"))
> + (find-files (string-append libc "/lib")
> + "^(crt.*|ld.*|lib(c|m|dl|rt|pthread|nsl|util).*\\.so(\\..*)?|\
> +lib(machuser|hurduser).so.*|libc(rt|)_nonshared\\.a)$"))
Maybe move the regexp to a separate variable for clarity, like:
(define %libc-object-files-rx "^…")
Otherwise LGTM!
Thanks!
Ludo’.
next prev parent reply other threads:[~2016-07-26 14:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 16:09 [PATCH] gnu: make-bootstrap: Produce the correct %glibc-bootstrap-tarball for Hurd systems Manolis Ragkousis
2016-07-26 13:41 ` Manolis Ragkousis
2016-07-26 14:44 ` Ludovic Courtès [this message]
2016-12-07 9:55 ` Manolis Ragkousis
2016-12-07 10:50 ` Ludovic Courtès
2016-12-07 11:01 ` Manolis Ragkousis
-- strict thread matches above, loose matches on Subject: below --
2015-06-30 10:14 Manolis Ragkousis
2015-06-30 19:56 ` Ludovic Courtès
2015-07-01 21:50 ` Manolis Ragkousis
2015-07-07 14:58 ` Ludovic Courtès
2015-07-09 9:54 ` Manolis Ragkousis
2015-07-10 20:48 ` Ludovic Courtès
2015-07-11 8:29 ` Manolis Ragkousis
2015-07-12 12:43 ` Manolis Ragkousis
2015-07-13 20:43 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87invs793a.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.