From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: make-bootstrap: Produce the correct
	%glibc-bootstrap-tarball for Hurd systems.
Date: Mon, 13 Jul 2015 22:43:07 +0200
Message-ID: <87si8rvles.fsf@gnu.org>
References: <CAFtzXzPhSU4YjmVAN4TqTK_wvPTbKmuGdoO1Aj97bpmLSvsbjg@mail.gmail.com>
	<87egktynp0.fsf@gnu.org>
	<CAFtzXzOv693nZzpFmBqVp2GN8FxTn03q=o8nZdfz4qNGE9AFZg@mail.gmail.com>
	<87lhesdnfd.fsf@gnu.org>
	<CAFtzXzPqY3Ee4dNKH7vA3y3PhLq0C=7Z=hdk+5bnzL36dtJtrQ@mail.gmail.com>
	<87r3of7n94.fsf@gnu.org>
	<CAFtzXzMj0=7mmaQv2Nn7F6SdCDhbBXy9obDm3ZCEKJ1R+akjfA@mail.gmail.com>
	<CAFtzXzNZbaGOVPDK51Kafwmw0h+KJQxqbHpxfrGymN=WzTzfpg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60347)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZEkZH-0007Ri-2i
	for Guix-devel@gnu.org; Mon, 13 Jul 2015 16:43:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZEkZB-0002Z0-P5
	for Guix-devel@gnu.org; Mon, 13 Jul 2015 16:43:14 -0400
In-Reply-To: <CAFtzXzNZbaGOVPDK51Kafwmw0h+KJQxqbHpxfrGymN=WzTzfpg@mail.gmail.com>
	(Manolis Ragkousis's message of "Sun, 12 Jul 2015 15:43:43 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>

Manolis Ragkousis <manolis837@gmail.com> skribis:

> Here is the updated patch with a small modification at the regexp. Now
> it copies all the .so and .a files,
> needed on a hurd system, to the stripped glibc (libcrt_nonshared.a,
> libmachuser.so, libhurduser.so).

OK for copying lib{hurd,mach}user.so, of course.

However, I think the .a files should be omitted.  What was the
motivation?

Also, I think any non-trivial change should be in a subsequent patch, so
that it=E2=80=99s easy to distinguish between the refactoring (moving code =
from
one file to another) and the actual functional change.

> +                          "^(crt.*|ld.*|lib(c|m|dl|rt|pthread|nsl|util|m=
achuser|
> +hurduser).*\\.so(\\..*)?|libc(rt|)_nonshared\\.a)$"))

There should be a backslash at the end of the first line so that
carriage return doesn=E2=80=99t appear literally in the regexp.

Thanks,
Ludo=E2=80=99.