all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#38897] [PATCH] gnu: Add ghc-pointedlist.
@ 2020-01-03 16:21 Alexandru-Sergiu Marton
  2020-01-04  4:27 ` Brett Gilio
  2020-01-04  8:46 ` [bug#38897] [PATCH v2] " Alexandru-Sergiu Marton
  0 siblings, 2 replies; 4+ messages in thread
From: Alexandru-Sergiu Marton @ 2020-01-03 16:21 UTC (permalink / raw)
  To: 38897; +Cc: Alexandru-Sergiu Marton

* gnu/packages/haskell-xyz.scm (ghc-pointedlist): New variable.
---
 gnu/packages/haskell-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
index 03ae83d50e..835380a69e 100644
--- a/gnu/packages/haskell-xyz.scm
+++ b/gnu/packages/haskell-xyz.scm
@@ -8615,6 +8615,31 @@ system dependencies.")
 functions for the ghc-persistent package.")
     (license license:expat)))
 
+(define-public ghc-pointedlist
+  (package
+    (name "ghc-pointedlist")
+    (version "0.6.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://hackage.haskell.org/package/pointedlist/"
+             "pointedlist-" version ".tar.gz"))
+       (sha256
+        (base32
+         "16xsrzqql7i4z6a3xy07sqnbyqdmcar1jiacla58y4mvkkwb0g3l"))))
+    (build-system haskell-build-system)
+    (home-page
+     "http://hackage.haskell.org/package/pointedlist")
+    (synopsis
+     "A zipper-like comonad which works as a list, tracking a position.")
+    (description
+     "A PointedList tracks the position in a non-empty list which works
+similarly to a zipper. A current item is always required, and therefore
+the list may never be empty. A circular PointedList wraps around to the
+other end when progressing past the actual edge.")
+    (license license:bsd-3)))
+
 (define-public ghc-polyparse
   (package
     (name "ghc-polyparse")
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#38897] [PATCH] gnu: Add ghc-pointedlist.
  2020-01-03 16:21 [bug#38897] [PATCH] gnu: Add ghc-pointedlist Alexandru-Sergiu Marton
@ 2020-01-04  4:27 ` Brett Gilio
  2020-01-04  8:46 ` [bug#38897] [PATCH v2] " Alexandru-Sergiu Marton
  1 sibling, 0 replies; 4+ messages in thread
From: Brett Gilio @ 2020-01-04  4:27 UTC (permalink / raw)
  To: Alexandru-Sergiu Marton; +Cc: 38897, Alexandru-Sergiu Marton

Alexandru-Sergiu Marton <brown121407@gmail.com> writes:

> +(define-public ghc-pointedlist
> +  (package
> +    (name "ghc-pointedlist")
> +    (version "0.6.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://hackage.haskell.org/package/pointedlist/"
> +             "pointedlist-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "16xsrzqql7i4z6a3xy07sqnbyqdmcar1jiacla58y4mvkkwb0g3l"))))
> +    (build-system haskell-build-system)
> +    (home-page
> +     "http://hackage.haskell.org/package/pointedlist")
> +    (synopsis
> +     "A zipper-like comonad which works as a list, tracking a position.")
> +    (description
> +     "A PointedList tracks the position in a non-empty list which works
> +similarly to a zipper. A current item is always required, and therefore
> +the list may never be empty. A circular PointedList wraps around to the
> +other end when progressing past the actual edge.")
> +    (license license:bsd-3)))

Hey again, Sergiu! I have a few suggestions for this package. I think
you forgot to run the linter :) which is okay! However, had you run it,
it would have warned you about the synopsis starting with an article,
the synopsis ending with a period, and the description not being double
spaced after each sentence punctuation. If you could reroll a V2 for
this, I would appreciate it!

Thanks!

-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg@gnu.org> <brettg@posteo.net>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#38897] [PATCH v2] gnu: Add ghc-pointedlist.
  2020-01-03 16:21 [bug#38897] [PATCH] gnu: Add ghc-pointedlist Alexandru-Sergiu Marton
  2020-01-04  4:27 ` Brett Gilio
@ 2020-01-04  8:46 ` Alexandru-Sergiu Marton
  2020-01-07 19:34   ` bug#38897: " Brett Gilio
  1 sibling, 1 reply; 4+ messages in thread
From: Alexandru-Sergiu Marton @ 2020-01-04  8:46 UTC (permalink / raw)
  To: 38897; +Cc: Alexandru-Sergiu Marton

* gnu/packages/haskell-xyz.scm (ghc-pointedlist): New variable.
---
Fix linter errors.

 gnu/packages/haskell-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
index 03ae83d50e..3f408d60e3 100644
--- a/gnu/packages/haskell-xyz.scm
+++ b/gnu/packages/haskell-xyz.scm
@@ -8615,6 +8615,31 @@ system dependencies.")
 functions for the ghc-persistent package.")
     (license license:expat)))
 
+(define-public ghc-pointedlist
+  (package
+    (name "ghc-pointedlist")
+    (version "0.6.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://hackage.haskell.org/package/pointedlist/"
+             "pointedlist-" version ".tar.gz"))
+       (sha256
+        (base32
+         "16xsrzqql7i4z6a3xy07sqnbyqdmcar1jiacla58y4mvkkwb0g3l"))))
+    (build-system haskell-build-system)
+    (home-page
+     "http://hackage.haskell.org/package/pointedlist")
+    (synopsis
+     "Zipper-like comonad which works as a list, tracking a position")
+    (description
+     "A PointedList tracks the position in a non-empty list which works
+similarly to a zipper.  A current item is always required, and therefore
+the list may never be empty.  A circular PointedList wraps around to the
+other end when progressing past the actual edge.")
+    (license license:bsd-3)))
+
 (define-public ghc-polyparse
   (package
     (name "ghc-polyparse")
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#38897: [PATCH v2] gnu: Add ghc-pointedlist.
  2020-01-04  8:46 ` [bug#38897] [PATCH v2] " Alexandru-Sergiu Marton
@ 2020-01-07 19:34   ` Brett Gilio
  0 siblings, 0 replies; 4+ messages in thread
From: Brett Gilio @ 2020-01-07 19:34 UTC (permalink / raw)
  To: Alexandru-Sergiu Marton; +Cc: 38897-done, Alexandru-Sergiu Marton

Hi Sergiu! Pushed with 451775a5675cdf1dfb9f4503427442b21bb5041a.

Thanks! Closing.

-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg@gnu.org> <brettg@posteo.net>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-07 19:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-03 16:21 [bug#38897] [PATCH] gnu: Add ghc-pointedlist Alexandru-Sergiu Marton
2020-01-04  4:27 ` Brett Gilio
2020-01-04  8:46 ` [bug#38897] [PATCH v2] " Alexandru-Sergiu Marton
2020-01-07 19:34   ` bug#38897: " Brett Gilio

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.