From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:41063) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inb2h-0007eM-0L for guix-patches@gnu.org; Fri, 03 Jan 2020 23:28:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inb2f-0000XD-R5 for guix-patches@gnu.org; Fri, 03 Jan 2020 23:28:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36361) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inb2f-0000WT-Mt for guix-patches@gnu.org; Fri, 03 Jan 2020 23:28:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inb2f-0000tF-KA for guix-patches@gnu.org; Fri, 03 Jan 2020 23:28:01 -0500 Subject: [bug#38897] [PATCH] gnu: Add ghc-pointedlist. Resent-Message-ID: From: Brett Gilio References: <20200103162120.3936-1-brown121407@member.fsf.org> Date: Fri, 03 Jan 2020 22:27:36 -0600 In-Reply-To: <20200103162120.3936-1-brown121407@member.fsf.org> (Alexandru-Sergiu Marton's message of "Fri, 3 Jan 2020 18:21:20 +0200") Message-ID: <87r20fzw07.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alexandru-Sergiu Marton Cc: 38897@debbugs.gnu.org, Alexandru-Sergiu Marton Alexandru-Sergiu Marton writes: > +(define-public ghc-pointedlist > + (package > + (name "ghc-pointedlist") > + (version "0.6.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://hackage.haskell.org/package/pointedlist/" > + "pointedlist-" version ".tar.gz")) > + (sha256 > + (base32 > + "16xsrzqql7i4z6a3xy07sqnbyqdmcar1jiacla58y4mvkkwb0g3l")))) > + (build-system haskell-build-system) > + (home-page > + "http://hackage.haskell.org/package/pointedlist") > + (synopsis > + "A zipper-like comonad which works as a list, tracking a position.") > + (description > + "A PointedList tracks the position in a non-empty list which works > +similarly to a zipper. A current item is always required, and therefore > +the list may never be empty. A circular PointedList wraps around to the > +other end when progressing past the actual edge.") > + (license license:bsd-3))) Hey again, Sergiu! I have a few suggestions for this package. I think you forgot to run the linter :) which is okay! However, had you run it, it would have warned you about the synopsis starting with an article, the synopsis ending with a period, and the description not being double spaced after each sentence punctuation. If you could reroll a V2 for this, I would appreciate it! Thanks! -- Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]