From: Brett Gilio <brettg@gnu.org>
To: Alexandru-Sergiu Marton <brown121407@gmail.com>
Cc: 38897@debbugs.gnu.org,
Alexandru-Sergiu Marton <brown121407@member.fsf.org>
Subject: [bug#38897] [PATCH] gnu: Add ghc-pointedlist.
Date: Fri, 03 Jan 2020 22:27:36 -0600 [thread overview]
Message-ID: <87r20fzw07.fsf@gnu.org> (raw)
In-Reply-To: <20200103162120.3936-1-brown121407@member.fsf.org> (Alexandru-Sergiu Marton's message of "Fri, 3 Jan 2020 18:21:20 +0200")
Alexandru-Sergiu Marton <brown121407@gmail.com> writes:
> +(define-public ghc-pointedlist
> + (package
> + (name "ghc-pointedlist")
> + (version "0.6.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://hackage.haskell.org/package/pointedlist/"
> + "pointedlist-" version ".tar.gz"))
> + (sha256
> + (base32
> + "16xsrzqql7i4z6a3xy07sqnbyqdmcar1jiacla58y4mvkkwb0g3l"))))
> + (build-system haskell-build-system)
> + (home-page
> + "http://hackage.haskell.org/package/pointedlist")
> + (synopsis
> + "A zipper-like comonad which works as a list, tracking a position.")
> + (description
> + "A PointedList tracks the position in a non-empty list which works
> +similarly to a zipper. A current item is always required, and therefore
> +the list may never be empty. A circular PointedList wraps around to the
> +other end when progressing past the actual edge.")
> + (license license:bsd-3)))
Hey again, Sergiu! I have a few suggestions for this package. I think
you forgot to run the linter :) which is okay! However, had you run it,
it would have warned you about the synopsis starting with an article,
the synopsis ending with a period, and the description not being double
spaced after each sentence punctuation. If you could reroll a V2 for
this, I would appreciate it!
Thanks!
--
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg@gnu.org> <brettg@posteo.net>
next prev parent reply other threads:[~2020-01-04 4:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 16:21 [bug#38897] [PATCH] gnu: Add ghc-pointedlist Alexandru-Sergiu Marton
2020-01-04 4:27 ` Brett Gilio [this message]
2020-01-04 8:46 ` [bug#38897] [PATCH v2] " Alexandru-Sergiu Marton
2020-01-07 19:34 ` bug#38897: " Brett Gilio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r20fzw07.fsf@gnu.org \
--to=brettg@gnu.org \
--cc=38897@debbugs.gnu.org \
--cc=brown121407@gmail.com \
--cc=brown121407@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.