all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage
@ 2018-06-22 12:39 Julien Lepiller
  2018-06-22 19:54 ` Ludovic Courtès
  2018-06-24  7:05 ` 宋文武
  0 siblings, 2 replies; 14+ messages in thread
From: Julien Lepiller @ 2018-06-22 12:39 UTC (permalink / raw)
  To: 31934

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

Hi, this patch fixes an issue with the patch for alsa-lib and defines a 
search-path rather than a native-search-path. In order to make the 
alsa-service work properly, you still need to have alsa-lib and 
alsa-plugins:pulseaudio in the same profile, and point ALSA_PLUGIN_DIR 
to $PROFILE/lib/alsa-lib.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-alsa-lib-Fix-ALSA_PLUGIN_DIR-usage.patch --]
[-- Type: text/x-diff; name=0001-gnu-alsa-lib-Fix-ALSA_PLUGIN_DIR-usage.patch, Size: 3159 bytes --]

From c63867eb51f1464207de950de4d8394971c7ec5f Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Fri, 22 Jun 2018 13:52:18 +0200
Subject: [PATCH] gnu: alsa-lib: Fix ALSA_PLUGIN_DIR usage.

* gnu/packages/linux.scm (native-search-paths): Use search-paths
instead.
* gnu/packages/patches/alsa-lib-add-environment-variable.patch: Use
computed plugdir instead of default ALSA_PLUGIN_DIR.
---
 gnu/packages/linux.scm                              |  2 +-
 .../patches/alsa-lib-add-environment-variable.patch | 21 ++++++++++++++-------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7e81f6387..b86dfdf80 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -983,7 +983,7 @@ intercept and print the system calls executed by the program.")
                "096pwrnhj36yndldvs2pj4r871zhcgisks0is78f1jkjn9sd4b2z"))
              (patches (search-patches "alsa-lib-add-environment-variable.patch"))))
     (build-system gnu-build-system)
-    (native-search-paths
+    (search-paths
      (list (search-path-specification
              (variable "ALSA_PLUGIN_DIR")
              (file-type 'regular)
diff --git a/gnu/packages/patches/alsa-lib-add-environment-variable.patch b/gnu/packages/patches/alsa-lib-add-environment-variable.patch
index a468a7fc4..9d122079e 100644
--- a/gnu/packages/patches/alsa-lib-add-environment-variable.patch
+++ b/gnu/packages/patches/alsa-lib-add-environment-variable.patch
@@ -1,21 +1,21 @@
-From 1822fb453128a1b5de93b4c590cd272d6488a077 Mon Sep 17 00:00:00 2001
+From 51523b7d546ade002b0bc999b2e01f9593e8576d Mon Sep 17 00:00:00 2001
 From: Julien Lepiller <julien@lepiller.eu>
-Date: Fri, 25 May 2018 19:26:58 +0200
+Date: Fri, 22 Jun 2018 13:50:45 +0200
 Subject: [PATCH] Add support for a ALSA_PLUGIN_DIR environment variable.
 
 If it is not set, default to previous behavior.
 ---
- src/control/control.c |  6 +++++-
+ src/control/control.c |  8 ++++++--
  src/dlmisc.c          |  9 +++++++--
  src/pcm/pcm.c         |  9 +++++++--
  src/pcm/pcm_rate.c    | 13 +++++++++----
- 4 files changed, 28 insertions(+), 9 deletions(-)
+ 4 files changed, 29 insertions(+), 10 deletions(-)
 
 diff --git a/src/control/control.c b/src/control/control.c
-index 11f7815..9dba7dd 100644
+index 11f7815..920b1af 100644
 --- a/src/control/control.c
 +++ b/src/control/control.c
-@@ -1331,7 +1331,11 @@ static int snd_ctl_open_conf(snd_ctl_t **ctlp, const char *name,
+@@ -1331,13 +1331,17 @@ static int snd_ctl_open_conf(snd_ctl_t **ctlp, const char *name,
  			build_in++;
  		}
  		if (*build_in == NULL) {
@@ -28,6 +28,13 @@ index 11f7815..9dba7dd 100644
  			if (buf1 == NULL) {
  				err = -ENOMEM;
  				goto _err;
+ 			}
+ 			lib = buf1;
+-			sprintf(buf1, "%s/libasound_module_ctl_%s.so", ALSA_PLUGIN_DIR, str);
++			sprintf(buf1, "%s/libasound_module_ctl_%s.so", plugdir, str);
+ 		}
+ 	}
+ #ifndef PIC
 diff --git a/src/dlmisc.c b/src/dlmisc.c
 index 3757d33..92aa864 100644
 --- a/src/dlmisc.c
@@ -106,5 +113,5 @@ index 4e0c7ca..8694a38 100644
  
  	rate->rate_min = SND_PCM_PLUGIN_RATE_MIN;
 -- 
-2.17.0
+2.14.4
 
-- 
2.14.4


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2018-06-26 14:04 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-22 12:39 [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage Julien Lepiller
2018-06-22 19:54 ` Ludovic Courtès
2018-06-22 20:22   ` Julien Lepiller
2018-06-23 21:54     ` Ludovic Courtès
2018-06-24  7:05 ` 宋文武
2018-06-24 10:44   ` [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins Oleg Pykhalov
2018-06-25 15:34     ` bug#31591: " 宋文武
2018-06-25 15:34       ` 宋文武
2018-06-25 15:37       ` Julien Lepiller
2018-06-26 11:38         ` 宋文武
2018-06-26 11:49           ` Marius Bakke
2018-06-26 12:34             ` bug#31934: " 宋文武
2018-06-26 12:59               ` [bug#31934] " Marius Bakke
2018-06-26 14:02         ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.