From: Julien Lepiller <julien@lepiller.eu>
To: 31934@debbugs.gnu.org
Subject: [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage
Date: Fri, 22 Jun 2018 22:22:46 +0200 [thread overview]
Message-ID: <20180622222246.49ea21b5@lepiller.eu> (raw)
In-Reply-To: <871scyy4u2.fsf@gnu.org>
Le Fri, 22 Jun 2018 21:54:45 +0200,
ludo@gnu.org (Ludovic Courtès) a écrit :
> Could you clarify which issue this fixes?
>
> Also, I think you really want ‘native-search-paths’ and not
> ‘search-paths’. The latter is meant to be used by things like
> cross-compilers.
>
> Thanks,
> Ludo’.
The issue was that a part of the code was only partially patched. It
looked like:
plugdir = ALSA_PLUGIN_DIR;
envplugdir = getenv("ALSA_PLUGIN_DIR");
if(envplugdir != NULL)
plugdir = envplugdir;
...
sofile = malloc(sizeof(plugdir) + ...);
...
sprintf(sofile, "%s/whatever.so", ALSA_PLUGIN_DIR);
If at compilation time ALSA_PLUGIN_DIR is bigger than the runtime
$ALSA_PLUGIN_DIR, we are in trouble: alsa-lib will crash because of a
buffer overflow. Otherwise, it just didn't care about $ALSA_PLUGIN_DIR.
The native-search-paths vs search-paths is a bit confusing... I need to
read the manual more carefully I guess.
next prev parent reply other threads:[~2018-06-22 20:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 12:39 [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage Julien Lepiller
2018-06-22 19:54 ` Ludovic Courtès
2018-06-22 20:22 ` Julien Lepiller [this message]
2018-06-23 21:54 ` Ludovic Courtès
2018-06-24 7:05 ` 宋文武
2018-06-24 10:44 ` [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins Oleg Pykhalov
2018-06-25 15:34 ` bug#31591: " 宋文武
2018-06-25 15:34 ` 宋文武
2018-06-25 15:37 ` Julien Lepiller
2018-06-26 11:38 ` 宋文武
2018-06-26 11:49 ` Marius Bakke
2018-06-26 12:34 ` bug#31934: " 宋文武
2018-06-26 12:59 ` [bug#31934] " Marius Bakke
2018-06-26 14:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622222246.49ea21b5@lepiller.eu \
--to=julien@lepiller.eu \
--cc=31934@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.