From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35403)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fXmLK-0000Ct-7f
	for guix-patches@gnu.org; Tue, 26 Jun 2018 07:41:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fXmLH-0007gS-1R
	for guix-patches@gnu.org; Tue, 26 Jun 2018 07:41:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:56024)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fXmLG-0007fj-UR
	for guix-patches@gnu.org; Tue, 26 Jun 2018 07:41:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fXmLG-0004SI-IW
	for guix-patches@gnu.org; Tue, 26 Jun 2018 07:41:02 -0400
Subject: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.
Resent-Message-ID: <handler.31934.B31934.153001320817053@debbugs.gnu.org>
From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=)
References: <c71cf82da0aa0f2e91a8ac616eea5013@lepiller.eu>
	<87a7rkhdg2.fsf@member.fsf.org> <87h8lso449.fsf_-_@gmail.com>
	<876026ev7u.fsf@member.fsf.org>
	<989ad55f9f17664af266f1f9f5653583@lepiller.eu>
Date: Tue, 26 Jun 2018 19:38:44 +0800
In-Reply-To: <989ad55f9f17664af266f1f9f5653583@lepiller.eu> (Julien Lepiller's
	message of "Mon, 25 Jun 2018 17:37:56 +0200")
Message-ID: <87o9fxdbgb.fsf@member.fsf.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: rekado@elephly.net, 31934@debbugs.gnu.org

Julien Lepiller <julien@lepiller.eu> writes:

> Le 2018-06-25 17:34, iyzsong@member.fsf.org a =C3=A9crit=C2=A0:
>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>
>>> Hello,
>>>
>>> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes:
>>>
>>>> Julien Lepiller <julien@lepiller.eu> writes:
>>>
>>> [=E2=80=A6]
>>>
>>>> Hello, after some hours of searching...  I found that we can use the
>>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
>>>> for alsa plugins, e.g:
>>>
>>> Thats a nice hack :-)  Thank you for working on this.
>>>
>>> [=E2=80=A6]
>>>
>>>> So I think we can make our 'alsa-service' do this, instead of
>>>> patching
>>>> alsa-lib for 'ALSA_PLUGIN_DIR'.
>>>
>>> Done.  Here is a patch which I tested on my machine by =E2=80=98system
>>> reconfigure=E2=80=99:
>>>
>>
>> Thank you, I modified it to keep the 'pulseaudio? #f' function, and
>> pushed :-)
>
> So maybe we can drop our ALSA_PLUGIN_DIR patch now?

Yes, I think so.  @Ricardo, should we do it in core-updates?