all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#38995] [PATCH] gnu: Add python-git-multimail.
@ 2020-01-06 20:10 Christopher Baines
  2020-01-11 21:42 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Baines @ 2020-01-06 20:10 UTC (permalink / raw)
  To: 38995

* gnu/packages/version-control.scm (python-git-multimail): New variable.
---
 gnu/packages/version-control.scm | 43 ++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index d354a807a3..9188e642a7 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -72,6 +72,7 @@
   #:use-module (gnu packages guile)
   #:use-module (gnu packages image)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages mail)
   #:use-module (gnu packages maths)
   #:use-module (gnu packages nano)
   #:use-module (gnu packages ncurses)
@@ -782,6 +783,48 @@ collaboration using typical untrusted file hosts or services.")
 a built-in cache to decrease server I/O pressure.")
     (license license:gpl2)))
 
+(define-public python-git-multimail
+  (package
+    (name "python-git-multimail")
+    (version "1.5.0.post1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "git-multimail" version))
+       (sha256
+        (base32
+         "1zkrbsa70anwpw86ysfwalrb7nsr064kygfiyikyq1pl9pcl969y"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "git-multimail/git_multimail.py"
+               (("GIT_EXECUTABLE = 'git'")
+                (string-append "GIT_EXECUTABLE = '"
+                               (assoc-ref inputs "git") "/bin/git"
+                               "'"))
+               (("/usr/sbin/sendmail")
+                (string-append (assoc-ref inputs "sendmail")
+                               "/usr/sbin/sendmail',
+        '/usr/sbin/sendmail")))
+             #t)))))
+    (inputs
+     `(("git" ,git)
+       ("sendmail" ,sendmail)))
+    (home-page "https://github.com/git-multimail/git-multimail")
+    (synopsis "Send notification emails for Git pushes")
+    (description
+     "This hook sends emails describing changes introduced by pushes to a Git
+repository.  For each reference that was changed, it emits one ReferenceChange
+email summarizing how the reference was changed, followed by one Revision
+email for each new commit that was introduced by the reference change.
+
+This script is designed to be used as a post-receive hook in a Git
+repository")
+    (license license:gpl2)))
+
 (define-public python-ghp-import
   (package
     (name "python-ghp-import")
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#38995] [PATCH] gnu: Add python-git-multimail.
  2020-01-06 20:10 [bug#38995] [PATCH] gnu: Add python-git-multimail Christopher Baines
@ 2020-01-11 21:42 ` Ludovic Courtès
  2020-01-16 21:32   ` bug#38995: " Christopher Baines
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2020-01-11 21:42 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 38995

Hi Chris!

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/packages/version-control.scm (python-git-multimail): New variable.

[...]

> +             (substitute* "git-multimail/git_multimail.py"
> +               (("GIT_EXECUTABLE = 'git'")
> +                (string-append "GIT_EXECUTABLE = '"
> +                               (assoc-ref inputs "git") "/bin/git"
> +                               "'"))
> +               (("/usr/sbin/sendmail")
> +                (string-append (assoc-ref inputs "sendmail")
> +                               "/usr/sbin/sendmail',
> +        '/usr/sbin/sendmail")))

The second clause is intriguing, but as long as it has the intended
effect, LGTM!  :-)

Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#38995: [PATCH] gnu: Add python-git-multimail.
  2020-01-11 21:42 ` Ludovic Courtès
@ 2020-01-16 21:32   ` Christopher Baines
  0 siblings, 0 replies; 3+ messages in thread
From: Christopher Baines @ 2020-01-16 21:32 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 38995-done

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hi Chris!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> * gnu/packages/version-control.scm (python-git-multimail): New variable.
>
> [...]
>
>> +             (substitute* "git-multimail/git_multimail.py"
>> +               (("GIT_EXECUTABLE = 'git'")
>> +                (string-append "GIT_EXECUTABLE = '"
>> +                               (assoc-ref inputs "git") "/bin/git"
>> +                               "'"))
>> +               (("/usr/sbin/sendmail")
>> +                (string-append (assoc-ref inputs "sendmail")
>> +                               "/usr/sbin/sendmail',
>> +        '/usr/sbin/sendmail")))
>
> The second clause is intriguing, but as long as it has the intended
> effect, LGTM!  :-)

I was thinking something about preserving the existing behaviour when I
kept /usr/sbin/sendmail in the list, but that doesn't make sense, as the
list is searched in order, and sendmail from the Guix package will
always be present.

I've removed the odd bit, and pushed this as
add8d50911f55464a1ecd003521997d6c7d912f3 now.

Thanks for taking a look!

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-16 21:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 20:10 [bug#38995] [PATCH] gnu: Add python-git-multimail Christopher Baines
2020-01-11 21:42 ` Ludovic Courtès
2020-01-16 21:32   ` bug#38995: " Christopher Baines

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.