From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38482) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isClD-0004Wf-5f for guix-patches@gnu.org; Thu, 16 Jan 2020 16:33:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isClC-0004kE-5n for guix-patches@gnu.org; Thu, 16 Jan 2020 16:33:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60735) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isClC-0004jz-2f for guix-patches@gnu.org; Thu, 16 Jan 2020 16:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1isClC-0000RW-0a for guix-patches@gnu.org; Thu, 16 Jan 2020 16:33:02 -0500 Subject: bug#38995: [PATCH] gnu: Add python-git-multimail. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <20200106201030.4520-1-mail@cbaines.net> <87k15xu0tx.fsf@gnu.org> From: Christopher Baines In-reply-to: <87k15xu0tx.fsf@gnu.org> Date: Thu, 16 Jan 2020 21:32:02 +0000 Message-ID: <87y2u7ozot.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 38995-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Chris! > > Christopher Baines skribis: > >> * gnu/packages/version-control.scm (python-git-multimail): New variable. > > [...] > >> + (substitute* "git-multimail/git_multimail.py" >> + (("GIT_EXECUTABLE =3D 'git'") >> + (string-append "GIT_EXECUTABLE =3D '" >> + (assoc-ref inputs "git") "/bin/git" >> + "'")) >> + (("/usr/sbin/sendmail") >> + (string-append (assoc-ref inputs "sendmail") >> + "/usr/sbin/sendmail', >> + '/usr/sbin/sendmail"))) > > The second clause is intriguing, but as long as it has the intended > effect, LGTM! :-) I was thinking something about preserving the existing behaviour when I kept /usr/sbin/sendmail in the list, but that doesn't make sense, as the list is searched in order, and sendmail from the Guix package will always be present. I've removed the odd bit, and pushed this as add8d50911f55464a1ecd003521997d6c7d912f3 now. Thanks for taking a look! Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4g1lNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdUHA/8CoXksL8R/1HYniSFuWCqVBHnVICi6vmbTeW/PmPsbzI9i1l4DTqX7VeW /Vb6kvTpikG1zFX5YsssANpYeTw9JISn1LolBWkraeH16VcJ5ySpJiTN8nbAAQWO t7nXozcGA+mY2ZmOofSUGwTMzRoUllrLb/cnG/u1kpBbWtM7BHGOyrJ7+8rs6Q4w cXXCTvciBak8G8wtDXlxjWhHi0Q7Tqt11QGW+ZiTz17Vi94ebRx90jpeU6VX2fM3 hb5WDB2mMhmjeY8gML3s8iqwAaFa0ujp3H3+yBBGhH9pjuhfeBtnXNC8GIHpngCv 5vJKuAjsO+61QtnRp/ogcKufbq2JMuvBlW+muvztPGy6Wbiq67IXi5YCH3Hp5sFG klaAWF2KDinyk1IjXJSQckNs9MIkPjNVqq2g1+NgifE0bNgIo0+gQRRwWR+eo3gK lf11NjLJA0ityWF7dR4gMyP+geRK+oCOgfiqyKqlQ/10ZljphivrUyCthlejOiFO zgf7B17EZOkTCSa0cSrS1pFkPAOTxuMfCw8Jwaxe+GKnaDT+DwuWv2LJ/a3JgaLd ES0c3+6AB1qJyhqoD9crzGL4i43BbEGc9cFGKmh9Md13uVgPAeO+EIyDCeMGGGO6 LwqwBzMtAzdRd6V80d+vVolYAPNfDY+GtaQ/2sYkVnyMvZ1eVOE= =HtoN -----END PGP SIGNATURE----- --=-=-=--