all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 38995-done@debbugs.gnu.org
Subject: bug#38995: [PATCH] gnu: Add python-git-multimail.
Date: Thu, 16 Jan 2020 21:32:02 +0000	[thread overview]
Message-ID: <87y2u7ozot.fsf@cbaines.net> (raw)
In-Reply-To: <87k15xu0tx.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hi Chris!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> * gnu/packages/version-control.scm (python-git-multimail): New variable.
>
> [...]
>
>> +             (substitute* "git-multimail/git_multimail.py"
>> +               (("GIT_EXECUTABLE = 'git'")
>> +                (string-append "GIT_EXECUTABLE = '"
>> +                               (assoc-ref inputs "git") "/bin/git"
>> +                               "'"))
>> +               (("/usr/sbin/sendmail")
>> +                (string-append (assoc-ref inputs "sendmail")
>> +                               "/usr/sbin/sendmail',
>> +        '/usr/sbin/sendmail")))
>
> The second clause is intriguing, but as long as it has the intended
> effect, LGTM!  :-)

I was thinking something about preserving the existing behaviour when I
kept /usr/sbin/sendmail in the list, but that doesn't make sense, as the
list is searched in order, and sendmail from the Guix package will
always be present.

I've removed the odd bit, and pushed this as
add8d50911f55464a1ecd003521997d6c7d912f3 now.

Thanks for taking a look!

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

      reply	other threads:[~2020-01-16 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 20:10 [bug#38995] [PATCH] gnu: Add python-git-multimail Christopher Baines
2020-01-11 21:42 ` Ludovic Courtès
2020-01-16 21:32   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2u7ozot.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=38995-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.