Re: 07/07: gnu: Add python-docspec.

Re: 07/07: gnu: Add python-docspec.

[Maxim Cournoyer]

Hi,

I'm not in the Python team, but I thought I'd give some feedback on
recent Python packages added.

guix-commits@gnu.org writes:

>     gnu: Add python-docspec.
>     
>     * gnu/packages/python-xyz.scm (python-docspec): New variable.
>     
>     Change-Id: I3103bde3483273a335156b38de742f493fd366f1
> ---
>  gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 61958d5eac..58a1a2b3cd 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -622,6 +622,31 @@ Python dataclasses.")
>  from JSON payloads using the @code{databind.core} framework.")
>      (license license:expat)))
>  
> +(define-public python-docspec
> +  (package
> +    (name "python-docspec")
> +    (version "2.2.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "docspec" version))
> +       (sha256
> +        (base32 "1zqmdrc6k8pprra8p3wpzq2ml2gph1cfjmsyg07f8b8fvizffm28"))))
> +    (build-system pyproject-build-system)
> +    (arguments (list #:tests? #false))  ;there are none

This commit and a few others mention there are no tests; perhaps that's
true of the PyPI archive, but in this case it's worth fetching from Git
in my opinion to run the tests.  Here for example, there appear to be a
Pytest test suite:
https://github.com/NiklasRosenstein/python-docspec/tree/develop/docspec/test

Fetching from git and adding pytest no native-inputs may be enough to
have it run.

Something to keep in mind for future submissions!

-- 
Thanks,
Maxim

Re: 07/07: gnu: Add python-docspec.

[Ricardo Wurmus]

Hi Maxim,

> I'm not in the Python team, but I thought I'd give some feedback on
> recent Python packages added.
>
> guix-commits@gnu.org writes:
>
>>     gnu: Add python-docspec.
>>     
>>     * gnu/packages/python-xyz.scm (python-docspec): New variable.
>>     
>>     Change-Id: I3103bde3483273a335156b38de742f493fd366f1
>> ---
>>  gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>
>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
>> index 61958d5eac..58a1a2b3cd 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -622,6 +622,31 @@ Python dataclasses.")
>>  from JSON payloads using the @code{databind.core} framework.")
>>      (license license:expat)))
>>  
>> +(define-public python-docspec
>> +  (package
>> +    (name "python-docspec")
>> +    (version "2.2.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "docspec" version))
>> +       (sha256
>> +        (base32 "1zqmdrc6k8pprra8p3wpzq2ml2gph1cfjmsyg07f8b8fvizffm28"))))
>> +    (build-system pyproject-build-system)
>> +    (arguments (list #:tests? #false))  ;there are none
>
> This commit and a few others mention there are no tests; perhaps that's
> true of the PyPI archive, but in this case it's worth fetching from Git
> in my opinion to run the tests.  Here for example, there appear to be a
> Pytest test suite:
> https://github.com/NiklasRosenstein/python-docspec/tree/develop/docspec/test
>
> Fetching from git and adding pytest no native-inputs may be enough to
> have it run.
>
> Something to keep in mind for future submissions!

Yes, I agree.  These recent Python additions are a little special in
that they had been misplaced and forgotten in the guix-science channel.
I’ve recently taken some time to clean up the guix-science channel and
move things that don’t belong there to the default Guix channel,
reviving and updating packages as I went along.

It’s true that it would be a good idea to revisit these packages to
check if we could get a test suite from the source repository and run
it.

-- 
Ricardo

Re: 07/07: gnu: Add python-docspec.

[Maxim Cournoyer]

Hi Ricardo,

Ricardo Wurmus <rekado@elephly.net> writes:

[...]

>> This commit and a few others mention there are no tests; perhaps that's
>> true of the PyPI archive, but in this case it's worth fetching from Git
>> in my opinion to run the tests.  Here for example, there appear to be a
>> Pytest test suite:
>> https://github.com/NiklasRosenstein/python-docspec/tree/develop/docspec/test
>>
>> Fetching from git and adding pytest no native-inputs may be enough to
>> have it run.
>>
>> Something to keep in mind for future submissions!
>
> Yes, I agree.  These recent Python additions are a little special in
> that they had been misplaced and forgotten in the guix-science channel.
> I’ve recently taken some time to clean up the guix-science channel and
> move things that don’t belong there to the default Guix channel,
> reviving and updating packages as I went along.

I understand, thanks for doing this!

-- 
Thanks,
Maxim