From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KMXLLQd8qWVIVwAA62LTzQ:P1 (envelope-from ) for ; Thu, 18 Jan 2024 20:29:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id KMXLLQd8qWVIVwAA62LTzQ (envelope-from ) for ; Thu, 18 Jan 2024 20:29:11 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ULKw+cRg; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705606151; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bdc+5eH8ip/On8AnL//H3LIniuWRYdMyye8Ndh0tXLA=; b=gr3P7Se0fUGnWaDAg50xRbBfsLFG6RUJ1zQMAYTDELiNzQBqglplEqfjOsWxJdc9Pc5M+R BSNa0icJixa2ggzSnEZkPvJkU3olY1h8kTb/pYbjDOCGwLz4rQ1UhXx0VUHlbxER071ifE VsLzuRk/UqsnSbEEyjWBGSlPFAiZ7NJl9IrBMOb8O+hO72y4KpX5E9h6mCCCBH57g986qI NM4LJLXYVa1iD5v8GLJQMM9hDjrLL6AdgwsDA38+UqkWcuLCMBMgD0hJGJwyBh4TQNClvo ImL3bl8iWTb+OLAzC99HZqpzSqPtzZT4/wQJ6PwLywIKBZnDMH/y7Y0AhdFT6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ULKw+cRg; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705606151; a=rsa-sha256; cv=none; b=p6TYzszhpNaw3oTSgxSvz2N8L1mbsO204rATXCEqbbz5xnpFRwHjiWVuzD1T9exaxXblAU WbZFP11y3AcElMlZXd4u1Z7KQeuQfHCAubGenh1vGodO5K08WhqaqaPjTlG3ohIxDP7KvY sir8r9mT+zUbDvBoVyNye6Yil8wqBPtmC62ibI96lmEKyU6UTlBp7i7E2em0ZMaIllj9Ty VjzPTv682hKPmZBah9OnLdW36R8v4eO4xdp0LmFZYukEZvT593lvjwzh5uNvpyhIgB3I47 eUh+mkxtDfNaNNf1hirYoNT4TMcrDqMt6NLpw2zsl/rZR293bQ/ll1UUl25NTg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 70D2676D08 for ; Thu, 18 Jan 2024 20:29:11 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQY3m-00062U-37; Thu, 18 Jan 2024 14:28:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQY3k-00061X-FJ for guix-devel@gnu.org; Thu, 18 Jan 2024 14:28:16 -0500 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQY3i-0008Kt-TE for guix-devel@gnu.org; Thu, 18 Jan 2024 14:28:16 -0500 Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-7831389c7daso1696885a.2 for ; Thu, 18 Jan 2024 11:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705606093; x=1706210893; darn=gnu.org; h=mime-version:user-agent:message-id:date:cc:references:in-reply-to :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=bdc+5eH8ip/On8AnL//H3LIniuWRYdMyye8Ndh0tXLA=; b=ULKw+cRgc8d1y/RgwEsI0zoCZrDi2b6oxm8oBUXEVgDh2GVbrxuyHViHBJx5mkKWN8 YnbSDqCjNpNe+I5xd8KYvd1NLCSJ5+3gf95kNQjwB7gxF0m/HmPTlSYECkaxfJNp3nWb 1YWNwnnWuW5zmu9nSb+r+Gmr3jqaY6uhk6gKt7gKB52Fc2wYq+7VelicQg4Ky16Gm5lN no2WdrDGlgo9iAtwA+LRwxQzBbF+yWVIv65kfZr+TYOuXZaJGYGMeq1M7s68W0Uys6zo VFhwEQ6l2R/jK0AlXYaHiBWw65iZmhacM/tUA8ODr6EKQnICnOvz/KYpEhSVEBk1oNFh wUOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705606093; x=1706210893; h=mime-version:user-agent:message-id:date:cc:references:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bdc+5eH8ip/On8AnL//H3LIniuWRYdMyye8Ndh0tXLA=; b=aPRUNvIMgDS5OFkwxEPEDSqcbd3THFwkMXcVm3CyZOWVodlELNijmBqMur8wo+n0Bz 5mn2acMSYGHCsW2q0Ylu77raJ425N5c9tRQgAMMkK94tGi3Vsw/QTjmKblNvNKsnHVmu g1aWhwnvlD8yyA1SwjbEsruHLfX807vJx8pwyCRLzz9DcC1jSlUCCj3nIk4auOD6qcbk 2VCP9nb6LXe9V4A7Pha1BlCE3S015Q3uY+azcrETsQDD7JVY2aeFU8Y2mGa7HBk9Wey6 SaE+VRmKmFuFoY9xHNFfavfwkQQ/gt1R5q0z80mK0W6UD+q3MtXmFWQfY0v3BpufdyBn jYxA== X-Gm-Message-State: AOJu0YxbAidoTj1Pwhsy2NBPDyP7Txf5i2zkJWsrMJXhLNpGWl0776HW /YMTw/od6VK8mLaD7sh+6FvnZf+23pTu8TSW386LH0i+7WIskugHZtHpj6xS X-Google-Smtp-Source: AGHT+IE98596nl1CdxJe232xSOaKKJP4k2wEJke+HCbyOUNeW48Zj86IkygsF7EWlisHAd/dmy3dFg== X-Received: by 2002:a05:620a:28d2:b0:783:2320:9704 with SMTP id l18-20020a05620a28d200b0078323209704mr208052qkp.26.1705606093298; Thu, 18 Jan 2024 11:28:13 -0800 (PST) Received: from hurd (dsl-10-132-160.b2b2c.ca. [72.10.132.160]) by smtp.gmail.com with ESMTPSA id u29-20020a05620a085d00b007834bfeb0e8sm4619492qku.51.2024.01.18.11.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 11:28:12 -0800 (PST) From: Maxim Cournoyer To: Ricardo Wurmus Subject: Re: 07/07: gnu: Add python-docspec. In-Reply-To: <20240115223414.D3725C405A2@vcs2.savannah.gnu.org> (guix-commits@gnu.org's message of "Mon, 15 Jan 2024 17:34:14 -0500 (EST)") References: <170535805079.4223.16688886567369675491@vcs2.savannah.gnu.org> <20240115223414.D3725C405A2@vcs2.savannah.gnu.org> CC: guix-devel@gnu.org Date: Thu, 18 Jan 2024 14:28:11 -0500 Message-ID: <87le8ml9v8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::729; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x729.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.99 X-Migadu-Queue-Id: 70D2676D08 X-Spam-Score: -9.99 X-Migadu-Scanner: mx11.migadu.com X-TUID: sO5XkO7Xq3Z3 Hi, I'm not in the Python team, but I thought I'd give some feedback on recent Python packages added. guix-commits@gnu.org writes: > gnu: Add python-docspec. > > * gnu/packages/python-xyz.scm (python-docspec): New variable. > > Change-Id: I3103bde3483273a335156b38de742f493fd366f1 > --- > gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index 61958d5eac..58a1a2b3cd 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -622,6 +622,31 @@ Python dataclasses.") > from JSON payloads using the @code{databind.core} framework.") > (license license:expat))) > > +(define-public python-docspec > + (package > + (name "python-docspec") > + (version "2.2.1") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "docspec" version)) > + (sha256 > + (base32 "1zqmdrc6k8pprra8p3wpzq2ml2gph1cfjmsyg07f8b8fvizffm28")))) > + (build-system pyproject-build-system) > + (arguments (list #:tests? #false)) ;there are none This commit and a few others mention there are no tests; perhaps that's true of the PyPI archive, but in this case it's worth fetching from Git in my opinion to run the tests. Here for example, there appear to be a Pytest test suite: https://github.com/NiklasRosenstein/python-docspec/tree/develop/docspec/test Fetching from git and adding pytest no native-inputs may be enough to have it run. Something to keep in mind for future submissions! -- Thanks, Maxim