From: Ricardo Wurmus <rekado@elephly.net>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: 07/07: gnu: Add python-docspec.
Date: Thu, 18 Jan 2024 23:11:47 +0100 [thread overview]
Message-ID: <87fryuthkw.fsf@elephly.net> (raw)
In-Reply-To: <87le8ml9v8.fsf@gmail.com>
Hi Maxim,
> I'm not in the Python team, but I thought I'd give some feedback on
> recent Python packages added.
>
> guix-commits@gnu.org writes:
>
>> gnu: Add python-docspec.
>>
>> * gnu/packages/python-xyz.scm (python-docspec): New variable.
>>
>> Change-Id: I3103bde3483273a335156b38de742f493fd366f1
>> ---
>> gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
>> index 61958d5eac..58a1a2b3cd 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -622,6 +622,31 @@ Python dataclasses.")
>> from JSON payloads using the @code{databind.core} framework.")
>> (license license:expat)))
>>
>> +(define-public python-docspec
>> + (package
>> + (name "python-docspec")
>> + (version "2.2.1")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (pypi-uri "docspec" version))
>> + (sha256
>> + (base32 "1zqmdrc6k8pprra8p3wpzq2ml2gph1cfjmsyg07f8b8fvizffm28"))))
>> + (build-system pyproject-build-system)
>> + (arguments (list #:tests? #false)) ;there are none
>
> This commit and a few others mention there are no tests; perhaps that's
> true of the PyPI archive, but in this case it's worth fetching from Git
> in my opinion to run the tests. Here for example, there appear to be a
> Pytest test suite:
> https://github.com/NiklasRosenstein/python-docspec/tree/develop/docspec/test
>
> Fetching from git and adding pytest no native-inputs may be enough to
> have it run.
>
> Something to keep in mind for future submissions!
Yes, I agree. These recent Python additions are a little special in
that they had been misplaced and forgotten in the guix-science channel.
I’ve recently taken some time to clean up the guix-science channel and
move things that don’t belong there to the default Guix channel,
reviving and updating packages as I went along.
It’s true that it would be a good idea to revisit these packages to
check if we could get a test suite from the source repository and run
it.
--
Ricardo
next prev parent reply other threads:[~2024-01-18 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170535805079.4223.16688886567369675491@vcs2.savannah.gnu.org>
[not found] ` <20240115223414.D3725C405A2@vcs2.savannah.gnu.org>
2024-01-18 19:28 ` 07/07: gnu: Add python-docspec Maxim Cournoyer
2024-01-18 22:11 ` Ricardo Wurmus [this message]
2024-01-19 21:55 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fryuthkw.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.