[bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme.

[bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme.

[Peter Mikkelsen]

Date: Tue, 19 Jun 2018 21:19:44 +0200
User-agent: mu4e 1.0; emacs 26.1
From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
* gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
---
 gnu/packages/emacs.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 219358bbd..86fa34cf9 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3213,6 +3213,25 @@ started with 20 minutes.  All values are customizable.")
 organizer.")
     (license license:gpl3+)))
 
+(define-public emacs-atom-one-dark-theme
+  (package
+   (name "emacs-atom-one-dark-theme")
+   (version "20180607.1638")
+   (source (origin
+             (method url-fetch)
+             (uri (string-append
+                   "https://melpa.org/packages/atom-one-dark-theme-"
+                   version ".el"))
+             (sha256
+              (base32
+               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
+   (build-system emacs-build-system)
+   (home-page
+    "https://github.com/jonathanchu/atom-one-dark-theme")
+   (synopsis "Atom One Dark color theme for Emacs")
+   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
+   (license license:gpl3)))
+
 (define-public emacs-zenburn-theme
   (package
     (name "emacs-zenburn-theme")
-- 
2.17.1

[bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

Hello Peter,

Peter Mikkelsen <peter@alaok.org> writes:

> Date: Tue, 19 Jun 2018 21:19:44 +0200
> User-agent: mu4e 1.0; emacs 26.1
> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable

[...]
  
> +(define-public emacs-atom-one-dark-theme
> +  (package
> +   (name "emacs-atom-one-dark-theme")
> +   (version "20180607.1638")
> +   (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "https://melpa.org/packages/atom-one-dark-theme-"
> +                   version ".el"))

Could you change this to use a git checkout or release tarball instead?
MELPA does not preserve old versions, so this version might not be
around for long.

> +             (sha256
> +              (base32
> +               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
> +   (build-system emacs-build-system)
> +   (home-page
> +    "https://github.com/jonathanchu/atom-one-dark-theme")
> +   (synopsis "Atom One Dark color theme for Emacs")
> +   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
> +   (license license:gpl3)))

This should be GPL3+, as noted in atom-one-dark-theme.el.  Can you send
an updated patch please?

Thanks in advance!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme.

[Peter Mikkelsen]

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

Hi, sorry for the delay

Marius Bakke writes:

> Hello Peter,
>
> Peter Mikkelsen <peter@alaok.org> writes:
>
>> Date: Tue, 19 Jun 2018 21:19:44 +0200
>> User-agent: mu4e 1.0; emacs 26.1
>> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
>> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
>
> [...]
>   
>> +(define-public emacs-atom-one-dark-theme
>> +  (package
>> +   (name "emacs-atom-one-dark-theme")
>> +   (version "20180607.1638")
>> +   (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append
>> +                   "https://melpa.org/packages/atom-one-dark-theme-"
>> +                   version ".el"))
>
> Could you change this to use a git checkout or release tarball instead?
> MELPA does not preserve old versions, so this version might not be
> around for long.

I didn't know that, but since the last release is quite old, I decided
to use a git checkout.

>> +             (sha256
>> +              (base32
>> +               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
>> +   (build-system emacs-build-system)
>> +   (home-page
>> +    "https://github.com/jonathanchu/atom-one-dark-theme")
>> +   (synopsis "Atom One Dark color theme for Emacs")
>> +   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
>> +   (license license:gpl3)))
>
> This should be GPL3+, as noted in atom-one-dark-theme.el.  Can you send
> an updated patch please?

I have attached an updated patch :)
Thanks


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch v2 --]
[-- Type: text/x-patch, Size: 1659 bytes --]

From 260f923dea35ce8f55ba00c06d1401cf8c0bb9c0 Mon Sep 17 00:00:00 2001
From: Peter Mikkelsen <petermikkelsen10@gmail.com>
Date: Tue, 19 Jun 2018 21:19:44 +0200
Subject: [PATCH] gnu: Add emacs-atom-one-dark-theme.

* gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
---
 gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 458c31dd0..27c454641 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3199,6 +3199,28 @@ started with 20 minutes.  All values are customizable.")
 organizer.")
     (license license:gpl3+)))
 
+(define-public emacs-atom-one-dark-theme
+  (let ((commit "1f1185bf667a38d3d0d180ce85fd4c131818aae2")
+        (revision "0"))
+    (package
+     (name "emacs-atom-one-dark-theme")
+     (version (git-version "0.1" revision commit))
+     (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/jonathanchu/atom-one-dark-theme.git")
+                    (commit commit)))
+              (sha256
+               (base32
+                "1alma16hg3mfjly8a9s3mrswkjjx4lrpdnf43869hn2ibkn7zx9z"))
+              (file-name (git-file-name name version))))
+     (build-system emacs-build-system)
+     (home-page
+      "https://github.com/jonathanchu/atom-one-dark-theme")
+     (synopsis "Atom One Dark color theme for Emacs")
+     (description "An Emacs port of the Atom One Dark theme from Atom.io.")
+     (license license:gpl3+))))
+
 (define-public emacs-zenburn-theme
   (package
     (name "emacs-zenburn-theme")
-- 
2.17.1

bug#31914: [PATCH] gnu: Add emacs-atom-one-dark-theme.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

Peter Mikkelsen <peter@alaok.org> writes:

> Hi, sorry for the delay
>
> Marius Bakke writes:
>
>> Hello Peter,
>>
>> Peter Mikkelsen <peter@alaok.org> writes:
>>
>>> Date: Tue, 19 Jun 2018 21:19:44 +0200
>>> User-agent: mu4e 1.0; emacs 26.1
>>> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
>>> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
>>
>> [...]
>>   
>>> +(define-public emacs-atom-one-dark-theme
>>> +  (package
>>> +   (name "emacs-atom-one-dark-theme")
>>> +   (version "20180607.1638")
>>> +   (source (origin
>>> +             (method url-fetch)
>>> +             (uri (string-append
>>> +                   "https://melpa.org/packages/atom-one-dark-theme-"
>>> +                   version ".el"))
>>
>> Could you change this to use a git checkout or release tarball instead?
>> MELPA does not preserve old versions, so this version might not be
>> around for long.
>
> I didn't know that, but since the last release is quite old, I decided
> to use a git checkout.
>
>>> +             (sha256
>>> +              (base32
>>> +               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
>>> +   (build-system emacs-build-system)
>>> +   (home-page
>>> +    "https://github.com/jonathanchu/atom-one-dark-theme")
>>> +   (synopsis "Atom One Dark color theme for Emacs")
>>> +   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
>>> +   (license license:gpl3)))
>>
>> This should be GPL3+, as noted in atom-one-dark-theme.el.  Can you send
>> an updated patch please?
>
> I have attached an updated patch :)

Thank you!  I've applied the patch, with one modification: the latest
git tag is "0.4.0"; and the same version number appears in the
commentary of atom-one-dark-theme.el, so it seemed more accurate than
"0.1".

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]