From: Marius Bakke <mbakke@fastmail.com>
To: Peter Mikkelsen <peter@alaok.org>
Cc: 31914-done@debbugs.gnu.org
Subject: bug#31914: [PATCH] gnu: Add emacs-atom-one-dark-theme.
Date: Tue, 03 Jul 2018 15:30:59 +0200 [thread overview]
Message-ID: <87sh508mzw.fsf@fastmail.com> (raw)
In-Reply-To: <87lgaxsw0q.fsf@alaok.org>
[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]
Peter Mikkelsen <peter@alaok.org> writes:
> Hi, sorry for the delay
>
> Marius Bakke writes:
>
>> Hello Peter,
>>
>> Peter Mikkelsen <peter@alaok.org> writes:
>>
>>> Date: Tue, 19 Jun 2018 21:19:44 +0200
>>> User-agent: mu4e 1.0; emacs 26.1
>>> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
>>> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
>>
>> [...]
>>
>>> +(define-public emacs-atom-one-dark-theme
>>> + (package
>>> + (name "emacs-atom-one-dark-theme")
>>> + (version "20180607.1638")
>>> + (source (origin
>>> + (method url-fetch)
>>> + (uri (string-append
>>> + "https://melpa.org/packages/atom-one-dark-theme-"
>>> + version ".el"))
>>
>> Could you change this to use a git checkout or release tarball instead?
>> MELPA does not preserve old versions, so this version might not be
>> around for long.
>
> I didn't know that, but since the last release is quite old, I decided
> to use a git checkout.
>
>>> + (sha256
>>> + (base32
>>> + "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
>>> + (build-system emacs-build-system)
>>> + (home-page
>>> + "https://github.com/jonathanchu/atom-one-dark-theme")
>>> + (synopsis "Atom One Dark color theme for Emacs")
>>> + (description "An Emacs port of the Atom One Dark theme from Atom.io.")
>>> + (license license:gpl3)))
>>
>> This should be GPL3+, as noted in atom-one-dark-theme.el. Can you send
>> an updated patch please?
>
> I have attached an updated patch :)
Thank you! I've applied the patch, with one modification: the latest
git tag is "0.4.0"; and the same version number appears in the
commentary of atom-one-dark-theme.el, so it seemed more accurate than
"0.1".
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2018-07-03 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 14:49 [bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme Peter Mikkelsen
2018-06-25 19:10 ` Marius Bakke
2018-06-29 10:54 ` Peter Mikkelsen
2018-07-03 13:30 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh508mzw.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=31914-done@debbugs.gnu.org \
--cc=peter@alaok.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.