From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faLPa-0005N6-Vh for guix-patches@gnu.org; Tue, 03 Jul 2018 09:32:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faLPW-0005UP-N7 for guix-patches@gnu.org; Tue, 03 Jul 2018 09:32:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36582) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1faLPW-0005U9-8Q for guix-patches@gnu.org; Tue, 03 Jul 2018 09:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1faLPV-0006y5-PO for guix-patches@gnu.org; Tue, 03 Jul 2018 09:32:01 -0400 Subject: bug#31914: [PATCH] gnu: Add emacs-atom-one-dark-theme. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <87lgaxsw0q.fsf@alaok.org> References: <87d0wlpl74.fsf@alaok.org> <87o9fyel82.fsf@fastmail.com> <87lgaxsw0q.fsf@alaok.org> Date: Tue, 03 Jul 2018 15:30:59 +0200 Message-ID: <87sh508mzw.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Peter Mikkelsen Cc: 31914-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Peter Mikkelsen writes: > Hi, sorry for the delay > > Marius Bakke writes: > >> Hello Peter, >> >> Peter Mikkelsen writes: >> >>> Date: Tue, 19 Jun 2018 21:19:44 +0200 >>> User-agent: mu4e 1.0; emacs 26.1 >>> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001 >>> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable >> >> [...] >>=20=20=20 >>> +(define-public emacs-atom-one-dark-theme >>> + (package >>> + (name "emacs-atom-one-dark-theme") >>> + (version "20180607.1638") >>> + (source (origin >>> + (method url-fetch) >>> + (uri (string-append >>> + "https://melpa.org/packages/atom-one-dark-theme-" >>> + version ".el")) >> >> Could you change this to use a git checkout or release tarball instead? >> MELPA does not preserve old versions, so this version might not be >> around for long. > > I didn't know that, but since the last release is quite old, I decided > to use a git checkout. > >>> + (sha256 >>> + (base32 >>> + "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq")= ))) >>> + (build-system emacs-build-system) >>> + (home-page >>> + "https://github.com/jonathanchu/atom-one-dark-theme") >>> + (synopsis "Atom One Dark color theme for Emacs") >>> + (description "An Emacs port of the Atom One Dark theme from Atom.io= .") >>> + (license license:gpl3))) >> >> This should be GPL3+, as noted in atom-one-dark-theme.el. Can you send >> an updated patch please? > > I have attached an updated patch :) Thank you! I've applied the patch, with one modification: the latest git tag is "0.4.0"; and the same version number appears in the commentary of atom-one-dark-theme.el, so it seemed more accurate than "0.1". --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAls7epMACgkQoqBt8qM6 VPpo+Qf/WwTUeO5JY+B5jzR2B8C9/zDUUGm6fPO0bp/G4UJBBwJPGi0J64EciBvX sLYPle40moA5sQjSsrlEnlx8pIwNahfVHsxRLa6H0U33jstjBPc1q6/NHa6C2DSG d8Q/go5WRYIuJWAb6MSyeype2++LEJieIvlQSDfJfNikwxdJJk9rvwK7oFRAWsZY dGjkRTS08d7ogmtRKQgUPYxVHDfXNefGjqQ8J9z6GfZbNe3FaxbESoGrwgogSrmL 97RIo+D+qawEvNJTtYF1a3GwIVoa3RnVUovP3EObdOw0h8BO+NMATF6CCdfcG0lp wzi58ESHHPimQhHH+hst4Y04oYbB8w== =y5/q -----END PGP SIGNATURE----- --=-=-=--