[bug#53535] [PATCH] gnu: Add emacs-popper

[bug#53535] [PATCH] gnu: Add emacs-popper

[Niklas Eklund]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

Niklas Eklund <niklas.eklund@posteo.net> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> Niklas Eklund <niklas.eklund@posteo.net> writes:
>>
>>> this patch adds the emacs-popper package.
>>
>> Thank you. Somme comments follow..
>>
>>> Subject: [PATCH] gnu: Add emacs-popper.
>>
>> The commit message is missing a line:
>>
>>   * gnu/packages/emacs-xyz.scm (emacs-popper): New variable.

Aha, I hadn't grasped that before. Thanks for mentioning it. Fixed that
in this new patch.

>>> +(define-public emacs-popper
>>> +  ;; No tagged release upstream for version 0.45
>>
>> This is true, but the commit matching release 0.45 is
>> "851d83882192ac9599ac5b053614a42d683b3fab", not the one you're using.
>>
>>> +  (let ((commit "527a85c49174e6e79220f0ed0761c204a979eae6") (revision "0"))
>>
>> Could you add a newline between (commit ...) and (revision ...)?
>>> +    (package
>>> +      (name "emacs-popper")
>>> +      (version "0.45")
>>
>> You bound revision, but you're not actually making use of it. I think
>> there are two possibilities here:
>>
>> - if you use commit 851d83882192ac9599ac5b053614a42d683b3fab, you can
>>   keep using (version "0.45"), and explain in a comment that the chosen
>>   commit matches version bump;
>>
>> - if you use another commit, you need to use (git-version "0.45"
>>   revision commit) instead, and explain in a comment why you're using an
>>   untagged commit.
>>
>> Could you send an updated patch?

Good points. I have changed to the
851d83882192ac9599ac5b053614a42d683b3fab commit and dropped revision.

>> Regards,
>> -- 
>> Nicolas Goaziou

/Niklas


[-- Attachment #2: patch-v2 --]
[-- Type: text/x-patch, Size: 1727 bytes --]

From 3f064617c9b001ced07a92bac86edcc7e31c2a1e Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Wed, 26 Jan 2022 00:23:29 +0100
Subject: [PATCH] gnu: Add emacs-popper.

* gnu/packages/emacs-xyz.scm (emacs-popper): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9d9adbb1e5..865c7c4172 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7068,6 +7068,29 @@ (define-public emacs-popup
 and popup menus.")
     (license license:gpl3+)))
 
+(define-public emacs-popper
+  ;; No tagged release upstream for version 0.45
+  (let ((commit "851d83882192ac9599ac5b053614a42d683b3fab"))
+    (package
+      (name "emacs-popper")
+      (version "0.45")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/karthink/popper")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0pk5wzqlz7n6v8rb1957i3ql0wjx578l68a3rp2m9pxr7a8a03h4"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/karthink/popper")
+      (synopsis "Emacs minor-mode to summon and dismiss buffers easily")
+      (description
+       "Popper is a minor-mode to tame the flood of ephemeral
+windows Emacs produces, while still keeping them within arm’s reach.")
+      (license license:gpl3+))))
+
 (define-public emacs-python-black
   (package
     (name "emacs-python-black")
-- 
2.32.0

bug#53535: [PATCH] gnu: Add emacs-popper

[Nicolas Goaziou]

Hello,

Niklas Eklund <niklas.eklund@posteo.net> writes:
> Subject: [PATCH] gnu: Add emacs-popper.

Applied. Thanks!

Regards,
-- 
Nicolas Goaziou

[bug#53535] [PATCH] gnu: Add emacs-popper

[Niklas Eklund]

[-- Attachment #1: Type: text/plain, Size: 59 bytes --]

Hello,

this patch adds the emacs-popper package.

/Niklas

[-- Attachment #2: emacs-popper --]
[-- Type: text/x-patch, Size: 1682 bytes --]

From 9fcc881fbe559000991992a4c52deede704cd2cf Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Wed, 26 Jan 2022 00:23:29 +0100
Subject: [PATCH] gnu: Add emacs-popper.

---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9d9adbb1e5..43c05b87c4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7068,6 +7068,29 @@ (define-public emacs-popup
 and popup menus.")
     (license license:gpl3+)))
 
+(define-public emacs-popper
+  ;; No tagged release upstream for version 0.45
+  (let ((commit "527a85c49174e6e79220f0ed0761c204a979eae6") (revision "0"))
+    (package
+      (name "emacs-popper")
+      (version "0.45")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/karthink/popper")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1l9n67jsj1y5q9hhkrmsxcjw1q3ychk7npl8fd1gbzxy2csc7vi2"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/karthink/popper")
+      (synopsis "Emacs minor-mode to summon and dismiss buffers easily")
+      (description
+       "Popper is a minor-mode to tame the flood of ephemeral
+windows Emacs produces, while still keeping them within arm’s reach.")
+      (license license:gpl3+))))
+
 (define-public emacs-python-black
   (package
     (name "emacs-python-black")
-- 
2.32.0

[bug#53535] [PATCH] gnu: Add emacs-popper

[Nicolas Goaziou]

Hello,

Niklas Eklund <niklas.eklund@posteo.net> writes:

> this patch adds the emacs-popper package.

Thank you. Somme comments follow..

> Subject: [PATCH] gnu: Add emacs-popper.

The commit message is missing a line:

  * gnu/packages/emacs-xyz.scm (emacs-popper): New variable.

> +(define-public emacs-popper
> +  ;; No tagged release upstream for version 0.45

This is true, but the commit matching release 0.45 is
"851d83882192ac9599ac5b053614a42d683b3fab", not the one you're using.

> +  (let ((commit "527a85c49174e6e79220f0ed0761c204a979eae6") (revision "0"))

Could you add a newline between (commit ...) and (revision ...)?
> +    (package
> +      (name "emacs-popper")
> +      (version "0.45")

You bound revision, but you're not actually making use of it. I think
there are two possibilities here:

- if you use commit 851d83882192ac9599ac5b053614a42d683b3fab, you can
  keep using (version "0.45"), and explain in a comment that the chosen
  commit matches version bump;

- if you use another commit, you need to use (git-version "0.45"
  revision commit) instead, and explain in a comment why you're using an
  untagged commit.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou