From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund@posteo.net>
Cc: 53535@debbugs.gnu.org
Subject: [bug#53535] [PATCH] gnu: Add emacs-popper
Date: Fri, 28 Jan 2022 09:11:39 +0100 [thread overview]
Message-ID: <87y230wa84.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87k0enmm8z.fsf@posteo.net> (Niklas Eklund's message of "Tue, 25 Jan 2022 23:25:16 +0000")
Hello,
Niklas Eklund <niklas.eklund@posteo.net> writes:
> this patch adds the emacs-popper package.
Thank you. Somme comments follow..
> Subject: [PATCH] gnu: Add emacs-popper.
The commit message is missing a line:
* gnu/packages/emacs-xyz.scm (emacs-popper): New variable.
> +(define-public emacs-popper
> + ;; No tagged release upstream for version 0.45
This is true, but the commit matching release 0.45 is
"851d83882192ac9599ac5b053614a42d683b3fab", not the one you're using.
> + (let ((commit "527a85c49174e6e79220f0ed0761c204a979eae6") (revision "0"))
Could you add a newline between (commit ...) and (revision ...)?
> + (package
> + (name "emacs-popper")
> + (version "0.45")
You bound revision, but you're not actually making use of it. I think
there are two possibilities here:
- if you use commit 851d83882192ac9599ac5b053614a42d683b3fab, you can
keep using (version "0.45"), and explain in a comment that the chosen
commit matches version bump;
- if you use another commit, you need to use (git-version "0.45"
revision commit) instead, and explain in a comment why you're using an
untagged commit.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-01-28 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 23:25 [bug#53535] [PATCH] gnu: Add emacs-popper Niklas Eklund
2022-01-28 8:11 ` Nicolas Goaziou [this message]
[not found] <draft-87fsp49bih.fsf@posteo.net>
2022-02-01 17:02 ` Niklas Eklund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y230wa84.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=53535@debbugs.gnu.org \
--cc=niklas.eklund@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.