From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wAzgEYWa+WFZwwAAgWs5BA (envelope-from ) for ; Tue, 01 Feb 2022 21:39:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2KCvDoWa+WGUWgEAauVa8A (envelope-from ) for ; Tue, 01 Feb 2022 21:39:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A6F2AEFA7 for ; Tue, 1 Feb 2022 21:39:32 +0100 (CET) Received: from localhost ([::1]:36106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEzw3-0007At-KY for larch@yhetil.org; Tue, 01 Feb 2022 15:39:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEwYY-000541-5O for guix-patches@gnu.org; Tue, 01 Feb 2022 12:03:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEwYX-0004uI-Rb for guix-patches@gnu.org; Tue, 01 Feb 2022 12:03:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEwYX-0002j9-OJ for guix-patches@gnu.org; Tue, 01 Feb 2022 12:03:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53535] [PATCH] gnu: Add emacs-popper Resent-From: Niklas Eklund Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Feb 2022 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53535 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 53535@debbugs.gnu.org Received: via spool by 53535-submit@debbugs.gnu.org id=B53535.164373495810444 (code B ref 53535); Tue, 01 Feb 2022 17:03:01 +0000 Received: (at 53535) by debbugs.gnu.org; 1 Feb 2022 17:02:38 +0000 Received: from localhost ([127.0.0.1]:43967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEwY9-0002iO-Nc for submit@debbugs.gnu.org; Tue, 01 Feb 2022 12:02:38 -0500 Received: from mout01.posteo.de ([185.67.36.65]:39477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEwY5-0002i8-Gf for 53535@debbugs.gnu.org; Tue, 01 Feb 2022 12:02:36 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 4C744240027 for <53535@debbugs.gnu.org>; Tue, 1 Feb 2022 18:02:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1643734947; bh=UPaPnnk5rSamJp6AvZxpnaoAlBUA99M2CWlb37UJDu4=; h=From:To:Cc:Subject:Date:From; b=dhY+LlgFIa/MuF4S/kKeIX/KoSLIgKVjisjD+AuQo0dAQHajm8x+tT6BrffCUh1kC 94FfD8aOUpOQftm9WYphCq5G7t/vNKVa4ORTJ8s//HP8S49RKT0471jIAPQU8+HFJ4 UfSEorUESPrbgDmstiuIR+M+rAZ13BNihK+Xdl68i0cw9qRt3IEu9qnrONUSRy/nBN YSLaLy2qBoTHu8q0kXKk14Jw6H0RwPsznGP4n2PLz9kxtio/TzzPO0kGmo8sM8GSth UWu5CNBOseVYDYNT0OimjVs2HCqtkVwVIY6eWlAtIcsdEJTLMchU6N8eMglfKJ9TKE Wcd3QKEsOo6WA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JpB7Q1TKlz6tmW; Tue, 1 Feb 2022 18:02:26 +0100 (CET) From: Niklas Eklund In-Reply-To: References: Date: Tue, 01 Feb 2022 17:02:25 +0000 Message-ID: <87a6fafrku.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643747973; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=zG+QrHFt/3lqCmxOTjEhjlF3rTOVyVAsoPH5XfUlaQY=; b=YD8cmWAoREknfwN5+u2n6OKj4N+AyIlWie3CmPYNIchSgzY9LLR9//a2mBKdVzzWoCZBHS gsLBJh3PYU2H/jbojGprXF+BbhQHJ/1ee1J8EeEXHj+PwGTUlSz7cz8VQWSFsGy/DxKqjq HB5GhCKcgLF6yDS33cW8CktWmI8B0aaTxTqBijBg7dUA4AxbyGlRium7AqEoOPTD9rQ4dL SCWzWZ8PXZRnnqpy3Y1JaDIpjmotPl3cQowHEC3jw/xU8Q9WnmvEk7RjVvh1XcUGfVEfG6 Rs0fF27KeAJ80ncvf1UWWLEBSSuaql45/0SAMnc9lkLPkQrzs2RY0txLbOAleg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643747973; a=rsa-sha256; cv=none; b=IHeWqeiaTWDrwCoNxMrYF/RdjB0V9ufA0BMkj2bAH2NNwlmNTEPQhmocxK4j6sDKMPzICj tlZ79S6dD+u3Uj51d5VZQp2qM0dlgcLQru2soHsMHDnkPjsIcsk14lEqoJ5TBYyQ/WsZMn fpMPpSfQmFTxwUWKVPC7+uZ6x83JO3qEr4KSwo19Sh7rNQ1cNaPwnUscYPJuL6BD954QR+ OKoMKl0QceQFtxuo7wfPyuyAejPbv7skUed0qVu52OzmEii0xNBZ6QmgA/hy0i/L9P+W6X pulLcVbVk8z/8Vbwi2Y6m2qiorR1oIpOxRX80tT11R8kGDh0H/rfQJVOZ1ZtjQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=dhY+LlgF; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=dhY+LlgF; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A6F2AEFA7 X-Spam-Score: -2.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: Sk0S9xKCWPFm --=-=-= Content-Type: text/plain Niklas Eklund writes: > Nicolas Goaziou writes: > >> Hello, >> >> Niklas Eklund writes: >> >>> this patch adds the emacs-popper package. >> >> Thank you. Somme comments follow.. >> >>> Subject: [PATCH] gnu: Add emacs-popper. >> >> The commit message is missing a line: >> >> * gnu/packages/emacs-xyz.scm (emacs-popper): New variable. Aha, I hadn't grasped that before. Thanks for mentioning it. Fixed that in this new patch. >>> +(define-public emacs-popper >>> + ;; No tagged release upstream for version 0.45 >> >> This is true, but the commit matching release 0.45 is >> "851d83882192ac9599ac5b053614a42d683b3fab", not the one you're using. >> >>> + (let ((commit "527a85c49174e6e79220f0ed0761c204a979eae6") (revision "0")) >> >> Could you add a newline between (commit ...) and (revision ...)? >>> + (package >>> + (name "emacs-popper") >>> + (version "0.45") >> >> You bound revision, but you're not actually making use of it. I think >> there are two possibilities here: >> >> - if you use commit 851d83882192ac9599ac5b053614a42d683b3fab, you can >> keep using (version "0.45"), and explain in a comment that the chosen >> commit matches version bump; >> >> - if you use another commit, you need to use (git-version "0.45" >> revision commit) instead, and explain in a comment why you're using an >> untagged commit. >> >> Could you send an updated patch? Good points. I have changed to the 851d83882192ac9599ac5b053614a42d683b3fab commit and dropped revision. >> Regards, >> -- >> Nicolas Goaziou /Niklas --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-Add-emacs-popper.patch Content-Transfer-Encoding: quoted-printable Content-Description: patch-v2 >From 3f064617c9b001ced07a92bac86edcc7e31c2a1e Mon Sep 17 00:00:00 2001 From: Niklas Eklund Date: Wed, 26 Jan 2022 00:23:29 +0100 Subject: [PATCH] gnu: Add emacs-popper. * gnu/packages/emacs-xyz.scm (emacs-popper): New variable. --- gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 9d9adbb1e5..865c7c4172 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -7068,6 +7068,29 @@ (define-public emacs-popup and popup menus.") (license license:gpl3+))) =20 +(define-public emacs-popper + ;; No tagged release upstream for version 0.45 + (let ((commit "851d83882192ac9599ac5b053614a42d683b3fab")) + (package + (name "emacs-popper") + (version "0.45") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/karthink/popper") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0pk5wzqlz7n6v8rb1957i3ql0wjx578l68a3rp2m9pxr7a8a03h4"))= )) + (build-system emacs-build-system) + (home-page "https://github.com/karthink/popper") + (synopsis "Emacs minor-mode to summon and dismiss buffers easily") + (description + "Popper is a minor-mode to tame the flood of ephemeral +windows Emacs produces, while still keeping them within arm=E2=80=99s reac= h.") + (license license:gpl3+)))) + (define-public emacs-python-black (package (name "emacs-python-black") --=20 2.32.0 --=-=-=--