From: Ben Sturmfels via Guix-patches via <guix-patches@gnu.org>
To: jgart <jgart@dismail.de>
Cc: Vinicius Monego <monego@posteo.net>, 47910@debbugs.gnu.org
Subject: [bug#47910] [PATCH] gnu: python-wtforms: Update to 2.3.3.
Date: Wed, 25 Aug 2021 10:57:33 +1000 [thread overview]
Message-ID: <875yvunxxe.fsf_-_@sturm.com.au> (raw)
In-Reply-To: <ca4ae1c43a11cd58da51929042d2697f0ff4c64f.camel@posteo.net> (Vinicius Monego's message of "Wed, 07 Jul 2021 23:29:10 +0000")
Hi Jgart,
>> I have not been able to successfully run all the tests without using
>> tox manually.
>
> [...]
>
>> What is the consensus for using tox with guix?
>
> Tox is an environment manager. As such, it is redundant in Guix. Tox is
> not a hard requirement for tests in any project.
>
> You can inspect the tox.ini file that is shipped in projects. This is
> the tox.ini from wtforms, in the 2.3.3 tag: [1]. Note that the test
> command that tox will run is:
>
>> python setup.py compile_catalog
>> coverage run tests/runtests.py --with-pep8
>
> After running these commands in the custom check phase, I could
> succesfully run the tests. I also added python-sqlalchemy and python-
> dateutil to native-inputs.
>
> Note that it requires django<1.7 which we don't have, but it's
> optional. It seems that the testing command will change again in
> version 3 to a standard pytest call and the legacy dependencies will be
> removed [2] (also see tox.ini in the master branch).
Vinicius's approach his makes sense to me - we only need to test wtforms on the version of Python in Guix, not all possible versions the library supports. Would you be able to proceed with calling the tests as Vinicius describes?
This is the last dependency we need to package MediaGoblin! Very exciting!
Regards,
Ben
next prev parent reply other threads:[~2021-08-25 0:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 17:28 [bug#47910] [PATCH] gnu: python-wtforms: Update to 2.3.3 jgart via Guix-patches via
2021-07-07 23:29 ` Vinicius Monego
2021-08-25 0:57 ` Ben Sturmfels via Guix-patches via [this message]
2021-09-11 23:37 ` [bug#47910] [PATCH] gnu: python-wtforms: Update to 2.3.3 and adjust arguments+inputs Raghav Gururajan via Guix-patches via
2021-09-11 23:46 ` Raghav Gururajan via Guix-patches via
2021-09-11 23:48 ` bug#47910: python-wtforms Raghav Gururajan via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yvunxxe.fsf_-_@sturm.com.au \
--to=guix-patches@gnu.org \
--cc=47910@debbugs.gnu.org \
--cc=ben@sturm.com.au \
--cc=jgart@dismail.de \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.