From: Vinicius Monego <monego@posteo.net>
To: 47910@debbugs.gnu.org
Subject: [bug#47910] [PATCH] gnu: python-wtforms: Update to 2.3.3.
Date: Wed, 07 Jul 2021 23:29:10 +0000 [thread overview]
Message-ID: <ca4ae1c43a11cd58da51929042d2697f0ff4c64f.camel@posteo.net> (raw)
In-Reply-To: <432e457285cdabe78e9db89f760a387c@dismail.de>
Hi,
> I have not been able to successfully run all the tests without using
> tox manually.
[...]
> What is the consensus for using tox with guix?
Tox is an environment manager. As such, it is redundant in Guix. Tox is
not a hard requirement for tests in any project.
You can inspect the tox.ini file that is shipped in projects. This is
the tox.ini from wtforms, in the 2.3.3 tag: [1]. Note that the test
command that tox will run is:
> python setup.py compile_catalog
> coverage run tests/runtests.py --with-pep8
After running these commands in the custom check phase, I could
succesfully run the tests. I also added python-sqlalchemy and python-
dateutil to native-inputs.
Note that it requires django<1.7 which we don't have, but it's
optional. It seems that the testing command will change again in
version 3 to a standard pytest call and the legacy dependencies will be
removed [2] (also see tox.ini in the master branch).
> python-hy is also broken (it depends on python-funcparserlib and
> fails because of it)
funcparserlib is broken because version 0.3.6 is compatible with only
up to Python 3.5 (it was released in 2013). There should be a 1.0.0
release this year [3] and it doesn't seem that 0.3.6 can be fixed from
our side.
It does not depend on tox either. Once 1.0.0 is released and packaged,
tox can be removed and it should run without replacing the check phase
(it uses unittest). Tox is still there because that package is
currently stagnating.
Vinicius
[1] https://github.com/wtforms/wtforms/blob/2.3.3/tox.ini
[2] https://github.com/wtforms/wtforms/commit/c49ecfb7e76f919eafb5c6a11c3b795c4e613757
[3] https://github.com/vlasovskikh/funcparserlib/issues/65
next prev parent reply other threads:[~2021-07-07 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 17:28 [bug#47910] [PATCH] gnu: python-wtforms: Update to 2.3.3 jgart via Guix-patches via
2021-07-07 23:29 ` Vinicius Monego [this message]
2021-08-25 0:57 ` Ben Sturmfels via Guix-patches via
2021-09-11 23:37 ` [bug#47910] [PATCH] gnu: python-wtforms: Update to 2.3.3 and adjust arguments+inputs Raghav Gururajan via Guix-patches via
2021-09-11 23:46 ` Raghav Gururajan via Guix-patches via
2021-09-11 23:48 ` bug#47910: python-wtforms Raghav Gururajan via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca4ae1c43a11cd58da51929042d2697f0ff4c64f.camel@posteo.net \
--to=monego@posteo.net \
--cc=47910@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.