[bug#47910] [PATCH] gnu: python-wtforms: Update to 2.3.3.

[jgart via Guix-patches via <guix-patches@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

Hi Guix,

This is related to 47260.

Attached is a patch for an upgrade to python-wtforms 2.3.3.

Tests are currently disabled in the attached patch. 

I added a when form in the code for when we are ready to enable the tests.

I'm getting the following error when I try to run the tests with tox:

error: [Errno 13] Permission denied: 'WTForms-2.3.3/setup.cfg'

Should I be using make-file-writable on the above or is this a different issue?

I have not been able to successfully run all the tests without using tox manually. 

See the comment I placed in the patch with a link to the github issue that I opened upstream.

Help and/or advice with testing this is much appreciated. 

What is the consensus for using tox with guix?

I see only one other package in the guix source tree that is currently invoking tox and that package is broken: python-funcparserlib.

python-hy is also broken (it depends on python-funcparserlib and fails because of it)

I think Tobias is currently working on those.

all the best,

jgart

[-- Attachment #2: 0001-gnu-python-wtforms-Update-to-2.3.3.patch --]
[-- Type: application/octet-stream, Size: 3086 bytes --]

From 7104474743af0575e68293384612458abe866917 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 19 Apr 2021 03:09:57 -0400
Subject: [PATCH] gnu: python-wtforms: Update to 2.3.3.

    * gnu/packages/python-xyz.scm (python-wtforms): Update to 2.3.3.

    Co-authored-by: Ben Sturmfels <ben@sturm.com.au>
---
 gnu/packages/python-web.scm | 39 ++++++++++++++++++++++---------------
 1 file changed, 23 insertions(+), 16 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 4f34502e86..533086d8f9 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -3000,7 +3000,7 @@ presume or force a developer to use a particular tool or library.")
        ("python-babel" ,python-babel)
        ("python-wtforms" ,python-wtforms)))
     (native-inputs
-     `(("python-pytest" ,python-pytest)))
+     `(("python-tox" ,python-tox)))
     (home-page "https://github.com/lepture/flask-wtf")
     (synopsis "Simple integration of Flask and WTForms")
     (description "Flask-WTF integrates Flask and WTForms, including CSRF, file
@@ -4122,29 +4122,36 @@ addon modules.")
 (define-public python-wtforms
   (package
     (name "python-wtforms")
-    (version "2.1")
+    (version "2.3.3")
     (source
      (origin
-       (method url-fetch)
-       (uri (pypi-uri "WTForms" version ".zip"))
+       (method git-fetch)
+       (uri (git-reference 
+            (url "https://github.com/wtforms/wtforms")
+            (commit version)))
+       (file-name (git-file-name name version))
        (sha256
         (base32
-         "0vyl26y9cg409cfyj8rhqxazsdnd0jipgjw06civhrd53yyi1pzz"))))
+         "0aix0655k8cbylpxi6lgyakigg51iy6bhj248g7d26d0mcpwl6mi"))))
     (build-system python-build-system)
     (arguments
-     '(#:phases
+     `(#:tests? #f
+       #:phases
        (modify-phases %standard-phases
-         (add-after 'unpack 'remove-django-test
-           ;; Don't fail the tests when the inputs for the optional tests cannot be found.
-           (lambda _
-             (substitute*
-               "tests/runtests.py"
-               (("'ext_django.tests', 'ext_sqlalchemy', 'ext_dateutil', 'locale_babel'") "")
-               (("sys.stderr.write(\"### Disabled test '%s', dependency not found\n\" % name)") ""))
-             #t)))))
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               ;; see https://github.com/wtforms/wtforms/issues/687
+               (invoke "tox"))))))) 
     (native-inputs
-     `(("unzip" ,unzip)))
-    (home-page "http://wtforms.simplecodes.com/")
+     `(("python-tox" ,python-tox)
+       ("python-babel" ,python-babel)
+       ("python-pytest" ,python-pytest)
+       ("python-coverage" ,python-coverage)))
+    (propagated-inputs
+     `(("python-markupsafe" ,python-markupsafe)
+       ("python-email-validator" ,python-email-validator)))
+    (home-page "http://wtforms.readthedocs.io")
     (synopsis
      "Form validation and rendering library for Python web development")
     (description
-- 
2.29.3