From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mB/oI7KVJWGPZQAAgWs5BA (envelope-from ) for ; Wed, 25 Aug 2021 02:58:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IJywH7KVJWHKAQAAB5/wlQ (envelope-from ) for ; Wed, 25 Aug 2021 00:58:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E339A1A657 for ; Wed, 25 Aug 2021 02:58:23 +0200 (CEST) Received: from localhost ([::1]:49978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIhFG-000623-HS for larch@yhetil.org; Tue, 24 Aug 2021 20:58:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIhEw-00061c-QZ for guix-patches@gnu.org; Tue, 24 Aug 2021 20:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIhEw-0004oW-JI for guix-patches@gnu.org; Tue, 24 Aug 2021 20:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIhEw-00021H-F2 for guix-patches@gnu.org; Tue, 24 Aug 2021 20:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47910] [PATCH] gnu: python-wtforms: Update to 2.3.3. Resent-From: Ben Sturmfels Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 25 Aug 2021 00:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47910 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: Vinicius Monego , 47910@debbugs.gnu.org Received: via spool by 47910-submit@debbugs.gnu.org id=B47910.16298530707745 (code B ref 47910); Wed, 25 Aug 2021 00:58:02 +0000 Received: (at 47910) by debbugs.gnu.org; 25 Aug 2021 00:57:50 +0000 Received: from localhost ([127.0.0.1]:45378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIhEj-00020r-Qu for submit@debbugs.gnu.org; Tue, 24 Aug 2021 20:57:50 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:57653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIhEh-00020d-Rc for 47910@debbugs.gnu.org; Tue, 24 Aug 2021 20:57:48 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 5E3EA32009C4; Tue, 24 Aug 2021 20:57:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 24 Aug 2021 20:57:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sturm.com.au; h= from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=fm3; bh=ZIha/2y1AFBNTRP/a2lQqp48Dl frPEp4wgTGnUx5C14=; b=OkUy72aJ06Do8e0Eg7CSfxvmDlANnfis6MXl+DBxYP Two9vak05DHDxyWQHJOErINMF6xFjeYzd2Yiq0lbK7ZUmRvnr+vwb98F0k0Mt37I qRBbnAQJcHfhtEwzYLAYrtbb9YXzwNbgnpwFhSM4layxwLqAGjQtrg/42yae16TB ndkkl+jpA32N9drqTudq7ViNorD+0hmJATEmua/fxf4GLS6Eu5yWj+nUd+mFCI83 6owS6UZzQ10B4I8i5jYiTvypeSkOU7OPvl4thARl9Ip5vDLdrpkipMXw40wA93Gr lrod4BJ6OP+JT2h0JH8XcSuejZEdYUh9tWxBlb3wPz0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ZIha/2 y1AFBNTRP/a2lQqp48DlfrPEp4wgTGnUx5C14=; b=azQP7s+YCHOn3iHcoQTErq Q2K1w/7g9nYc7NvqWxPX77tTDqMqc9v0nWW9y1ESMiKxHm2YUL6kGfMIg03ZTOM5 +Tb6VRJe7PFkEeFzOMwOJMGxyd8jTBfPd0v2qqO+mo6/6PutEXBSekY/RUb9zsU2 DdoawYvLpiWPXqRwLbJjIWs0gvxwGd419AXH96hUCOrxe91pz04YE/zHVPUdGlyb U4QE5CBWMi74BNfdt/en4ZjJwcFaRsFT/zZUvn8DuC95wBHBUbY/afs8PaVNqyb9 OtM7pyYiCFtj6aIA/Nz+7Lq3IKWCiyqn8K7n92fr8LuIV5BYxN8ulDRwSvCylP0Q == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddtkedgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpeeuvghnucfu thhurhhmfhgvlhhsuceosggvnhesshhtuhhrmhdrtghomhdrrghuqeenucggtffrrghtth gvrhhnpeeuteejffefleehjedukeegfefgleevvdeufeefueethfefueetkeefkeeljeet hfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsvg hnsehsthhurhhmrdgtohhmrdgruh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Aug 2021 20:57:38 -0400 (EDT) Received: from Marseille (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ce7eef9d; Wed, 25 Aug 2021 00:57:33 +0000 (UTC) References: <432e457285cdabe78e9db89f760a387c@dismail.de> Date: Wed, 25 Aug 2021 10:57:33 +1000 In-Reply-To: (Vinicius Monego's message of "Wed, 07 Jul 2021 23:29:10 +0000") Message-ID: <875yvunxxe.fsf_-_@sturm.com.au> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Ben Sturmfels X-ACL-Warn: , Ben Sturmfels via Guix-patches From: Ben Sturmfels via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629853106; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ZIha/2y1AFBNTRP/a2lQqp48DlfrPEp4wgTGnUx5C14=; b=CmiWkLfP3FzQn4/nlLaYyScBE+jfhorEWzHZaJ7AzUAhZnP69ReunscI9FdMGzAgile+oS fjujbmG5FSOesIM+WwCSGOa2x5U0fNhQ/lz+k5fKOAhBVfdbogiWQebH0VNpCmJcgBL/Lp tLR1WxPX0XHqq3M1Ge0pVjWOjO5UGWC2jv6pv+Z2jdogPybpCKeqfqLNxAtlgChatdAlQl Xei6qiTYrrumM0n1OKP76d8U/xxgPrS9+12KGV/c3pEeZ0eXGPl+tjnoQeVBClp97SpDBR gyLFZbPsUZcmr8ZG2z8QZ0iViKdjWfQqXVH9FPsxxltEvi89JtgJQGCEJVCjzA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629853106; a=rsa-sha256; cv=none; b=VmNOCd65wc+0MOjV7Jd2UOzlZLn4mkIrGtrqJxM7c4fWhCcYTIc6gmZ4SvG8Ew6SXGWsJU 3oD0IY6fkCaTafOsVxRWWfPEGkb+tLhR0P/1iZtn7VMe5I0Mgp0SqMSIQCw73aNZv3dt+I lx5vaOzgwA74dHLWtSRW7SyorX5KBPOVyXsmoslO9LdgdzLYutDqyrHEdAlTCt/mki7L3j 8NVZMhx9zF+A2lHpqF7Doaa7nV7FfhVdRF3hT0VCARh8Gad7cVTPkNG9Pkcac9jB1Nb6fM qsR+ys+3SWy3cFhiP8m92cy1DuOaqqh2RJm6NhyYPOo4CPY7UMMDQioGNLtFJw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=sturm.com.au header.s=fm3 header.b=OkUy72aJ; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=azQP7s+Y; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=sturm.com.au header.s=fm3 header.b=OkUy72aJ; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=azQP7s+Y; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E339A1A657 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: tnyyfW5IOiVA Hi Jgart, >> I have not been able to successfully run all the tests without using >> tox manually. > > [...] > >> What is the consensus for using tox with guix? > > Tox is an environment manager. As such, it is redundant in Guix. Tox is > not a hard requirement for tests in any project. > > You can inspect the tox.ini file that is shipped in projects. This is > the tox.ini from wtforms, in the 2.3.3 tag: [1]. Note that the test > command that tox will run is: > >> python setup.py compile_catalog >> coverage run tests/runtests.py --with-pep8 > > After running these commands in the custom check phase, I could > succesfully run the tests. I also added python-sqlalchemy and python- > dateutil to native-inputs. > > Note that it requires django<1.7 which we don't have, but it's > optional. It seems that the testing command will change again in > version 3 to a standard pytest call and the legacy dependencies will be > removed [2] (also see tox.ini in the master branch). Vinicius's approach his makes sense to me - we only need to test wtforms on the version of Python in Guix, not all possible versions the library supports. Would you be able to proceed with calling the tests as Vinicius describes? This is the last dependency we need to package MediaGoblin! Very exciting! Regards, Ben