Re: Merging ‘wip-newt-installer’ in master?

[ludo@gnu.org (Ludovic Courtès)]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

Hello Mathieu,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> I just pushed one commit on the branch to fix install tests. They now
> seem to all pass with success.
>
> Tell me if you see any remaining stuff to be done before merging :)

I stumbled upon a typo leading to an unbound variable error after the
last step (patch attached; I let you apply it.)

Other than that, something I hadn’t realized earlier (sorry for being
foolish!): the installer actually stops after the user account selection
and does nothing more, right?  It doesn’t generate a config file nor
does it run ‘guix system init’, does it?

If this is correct, we should probably delay merging until after the
release as people may be confused when they realize the installer has no
effect.  WDYT?

Thanks, and apologies for not following closely enough so far!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 567 bytes --]

diff --git a/gnu/installer.scm b/gnu/installer.scm
index b3eb2a6b08..d64a66e09d 100644
--- a/gnu/installer.scm
+++ b/gnu/installer.scm
@@ -289,8 +289,8 @@ selected keymap."
                       (print-exception port
                                        (stack-ref (make-stack #t) 1)
                                        key args)))
-                  (primitive-exit 1))))
-            ((installer-exit current-installer))))))
+                  (primitive-exit 1)))
+              ((installer-exit current-installer)))))))
 
   (program-file
    "installer"