From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Merging =?utf-8?Q?=E2=80=98wip-newt-installer=E2=80=99?= in master? Date: Wed, 28 Nov 2018 14:14:19 +0100 Message-ID: <874lc15opg.fsf@gnu.org> References: <87lg6sejwa.fsf@gmail.com> <87wopd88hq.fsf@gmail.com> <877ehcsocq.fsf@gnu.org> <87bm6oxsyf.fsf@gmail.com> <87a7m7yhu5.fsf@gmail.com> <878t1rygfu.fsf@gmail.com> <877ehbydmz.fsf@gmail.com> <87sgzykmyx.fsf@gnu.org> <877eh9245u.fsf@gmail.com> <87efbgx0p0.fsf@gnu.org> <87sgzw5ylb.fsf@gmail.com> <87zhu1cw4p.fsf_-_@gnu.org> <875zwp17od.fsf@gmail.com> <87lg5j6h00.fsf@gnu.org> <87pnuv26jv.fsf@gmail.com> <87efbb4xpt.fsf@gnu.org> <871s7bm8k5.fsf@gmail.com> <8736rl6049.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRzfp-00036W-01 for guix-devel@gnu.org; Wed, 28 Nov 2018 08:14:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRzfm-0006Zj-O2 for guix-devel@gnu.org; Wed, 28 Nov 2018 08:14:36 -0500 In-Reply-To: <8736rl6049.fsf@gmail.com> (Mathieu Othacehe's message of "Wed, 28 Nov 2018 18:07:50 +0900") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mathieu Othacehe Cc: Guix-devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Mathieu, Mathieu Othacehe skribis: > I just pushed one commit on the branch to fix install tests. They now > seem to all pass with success. > > Tell me if you see any remaining stuff to be done before merging :) I stumbled upon a typo leading to an unbound variable error after the last step (patch attached; I let you apply it.) Other than that, something I hadn=E2=80=99t realized earlier (sorry for bei= ng foolish!): the installer actually stops after the user account selection and does nothing more, right? It doesn=E2=80=99t generate a config file nor does it run =E2=80=98guix system init=E2=80=99, does it? If this is correct, we should probably delay merging until after the release as people may be confused when they realize the installer has no effect. WDYT? Thanks, and apologies for not following closely enough so far! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/installer.scm b/gnu/installer.scm index b3eb2a6b08..d64a66e09d 100644 --- a/gnu/installer.scm +++ b/gnu/installer.scm @@ -289,8 +289,8 @@ selected keymap." (print-exception port (stack-ref (make-stack #t) 1) key args))) - (primitive-exit 1)))) - ((installer-exit current-installer)))))) + (primitive-exit 1))) + ((installer-exit current-installer))))))) (program-file "installer" --=-=-=--