From: Leo Prikler <leo.prikler@student.tugraz.at>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 49670-done@debbugs.gnu.org
Subject: bug#49670: [PATCH] gnu: gnome-maps: Unregister from DBus when asked to.
Date: Fri, 23 Jul 2021 12:51:43 +0200 [thread overview]
Message-ID: <63a2a1a14cfcb6d9dfed2749ff5d93b2e9de72f8.camel@student.tugraz.at> (raw)
In-Reply-To: <87tuklbcpj.fsf@gnu.org>
Am Freitag, den 23.07.2021, 11:29 +0200 schrieb Ludovic Courtès:
> Hi Leo,
>
> Leo Prikler <leo.prikler@student.tugraz.at> skribis:
>
> > Am Mittwoch, den 21.07.2021, 16:28 +0200 schrieb Ludovic Courtès:
>
> [...]
>
> > > > +++ b/gnu/packages/patches/gnome-maps-really-do-
> > > > unregister.patch
> > > > @@ -0,0 +1,13 @@
> > > > +Index: gnome-maps-3.36.7/src/application.js
> > >
> > > Could you add a line at the top of this patch saying what it does
> > > along with a link to the merge request above?
> > It turns out a similar fix already exists upstream [1], so if we
> > decide
> > to backport that to 3.36 instead of bumping the package to 3.38, I
> > think we should pick the "official" one.
>
> Even better.
>
> > > Apart from that the two patches LGTM, especially if it allows me
> > > to
> > > use gnome-maps again. :-)
> > Do "the two patches" refer to this one alone or also to the one
> > bumping
> > the package to 3.38?
>
> Both, but I hadn’t realized there’s was an exclusive choice.
Well, the exclusive choice comes from the fact that the patch we would
have to add to 3.36 is already present in 3.38.1+. So bumping to a
sufficiently recent gnome-maps "voids" the patch in that it is already
applied.
> > Again, I'm a little unsure what would be the preferred solution
> > here,
> > as either patch adds additional code that would probably need to be
> > reverted by Raghav in their GNOME 40 work.
>
> I don’t know, I think it’s good to have short-term fixes anyway and
> it’s
> OK if they have to be undone when we eventually upgrade. Your call!
I went with bumping to 3.38. While I hope the test suite doesn't break
in 40 the same way it does here, there is a slim chance the phase I've
added needs to be kept.
Thanks
prev parent reply other threads:[~2021-07-23 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 22:34 [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to Leo Prikler
2021-07-21 11:04 ` [bug#49670] [PATCH] gnu: gnome-maps: Update to 3.38.5 Leo Prikler
2021-07-21 14:28 ` [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to Ludovic Courtès
2021-07-22 8:31 ` Leo Prikler
2021-07-23 9:29 ` Ludovic Courtès
2021-07-23 10:51 ` Leo Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63a2a1a14cfcb6d9dfed2749ff5d93b2e9de72f8.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=49670-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.