From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qmIwLJOf+mAEHAEAgWs5BA (envelope-from ) for ; Fri, 23 Jul 2021 12:53:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aEpiJ5Of+mC7UQAA1q6Kng (envelope-from ) for ; Fri, 23 Jul 2021 10:53:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D5318711 for ; Fri, 23 Jul 2021 12:53:07 +0200 (CEST) Received: from localhost ([::1]:36064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6sni-0004PS-EG for larch@yhetil.org; Fri, 23 Jul 2021 06:53:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6sne-0004PC-2x for guix-patches@gnu.org; Fri, 23 Jul 2021 06:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59071) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6snd-00056J-R7 for guix-patches@gnu.org; Fri, 23 Jul 2021 06:53:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6snd-0002wY-O0 for guix-patches@gnu.org; Fri, 23 Jul 2021 06:53:01 -0400 Subject: bug#49670: [PATCH] gnu: gnome-maps: Unregister from DBus when asked to. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 23 Jul 2021 10:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 49670 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49670-done@debbugs.gnu.org Mail-Followup-To: 49670@debbugs.gnu.org, leo.prikler@student.tugraz.at, leo.prikler@student.tugraz.at Received: via spool by 49670-done@debbugs.gnu.org id=D49670.162703753611258 (code D ref 49670); Fri, 23 Jul 2021 10:53:01 +0000 Received: (at 49670-done) by debbugs.gnu.org; 23 Jul 2021 10:52:16 +0000 Received: from localhost ([127.0.0.1]:42382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6smu-0002vV-6r for submit@debbugs.gnu.org; Fri, 23 Jul 2021 06:52:16 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:39411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6smq-0002vI-Mg for 49670-done@debbugs.gnu.org; Fri, 23 Jul 2021 06:52:14 -0400 Received: from [10.0.0.4] (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GWR3F5JwQz3wXd; Fri, 23 Jul 2021 12:52:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1627037529; bh=vBfBx09CmDhgVo0GcGH3ETdQTsXMk0pSdaeHqA0CK8M=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=vRlfu/9ldCRIPCgWSXEY9Rs6DsH1wWgD/A0wBgh7BPpJUy0VzmUJAmQ8Hh8tXbgBG 9WF7qQFbBvW5BBsJaJa8WnjgVe7HYoQR309TQQG0OF/Ih801i6cysnO1ft8rboDTDe 2EfwWXH0a5uGH+oY0OAmY2D+Z2YpE+BEezkQrVE0= Message-ID: <63a2a1a14cfcb6d9dfed2749ff5d93b2e9de72f8.camel@student.tugraz.at> From: Leo Prikler Date: Fri, 23 Jul 2021 12:51:43 +0200 In-Reply-To: <87tuklbcpj.fsf@gnu.org> References: <20210720223452.9471-1-leo.prikler@student.tugraz.at> <87fsw7hhce.fsf@gnu.org> <5af9faa539c916abf3fce795e1e127614456fa43.camel@student.tugraz.at> <87tuklbcpj.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627037587; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vBfBx09CmDhgVo0GcGH3ETdQTsXMk0pSdaeHqA0CK8M=; b=Lvn4sjANYwO7VH9ujnM7LaNzscXFjowU3alNVVNerJ7KBsQPjkpOE6K6vluBfNiICSBgkS IKRrfD4VcfNt646Uo3ELJoRpaLyBkHztEYf0Hyuf2oniqHoQKsi9ijuHIPrUlmqfUpaxDR CCnTCfxTLc9/2XjdouHLIblo/Aj0Xj66EBOTsq0yumBZzsx300VYMdk40K5XDPlP45mG2c 40+oltpRolOQmPCMWq0F51azoASodbiDIegOEHPMxQuKAX0/HmjdFb3N1MADrNgKJE45tl Eo+YzRL/1PijQmHvLPzbuDNxTXdgocuzFQ2r7kC4b8PoOk+4WRjDel1GDg1eIg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627037587; a=rsa-sha256; cv=none; b=tSsCGDMcfbEprcnPMzo19nhu2HuwtLnANIUE1Njjqbh9CcPmYOIj0u9SIA0M3U6Ie6v8Gk I8sElkNtN+IlhX/mjj/Cb3P8vFS2cEJ/IsocfMcWNZvg5TFnvaRsOpWFjXUypXRlTPglCc UuV3Qf+fCFeYQ8cAx7bwJSXBGsaTl9pA8iPL84e5uPvLIwZaJFhB6Mv+2s89dAJmPhmevy 4A7QNotK+YE5IaNiZ97VqjXCYkZWPvBwQRyqF2veK5PnrjV3aV9vaLLICgNRpm5oUWG1np Po+qEkcbdTNgelVcGBXo3bOkbEDu21tbTQ5FsFQx5QwIvZPKTzioLvh5q5MZNw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="vRlfu/9l"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="vRlfu/9l"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5D5318711 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5ks6ALmZcVph Am Freitag, den 23.07.2021, 11:29 +0200 schrieb Ludovic Courtès: > Hi Leo, > > Leo Prikler skribis: > > > Am Mittwoch, den 21.07.2021, 16:28 +0200 schrieb Ludovic Courtès: > > [...] > > > > > +++ b/gnu/packages/patches/gnome-maps-really-do- > > > > unregister.patch > > > > @@ -0,0 +1,13 @@ > > > > +Index: gnome-maps-3.36.7/src/application.js > > > > > > Could you add a line at the top of this patch saying what it does > > > along with a link to the merge request above? > > It turns out a similar fix already exists upstream [1], so if we > > decide > > to backport that to 3.36 instead of bumping the package to 3.38, I > > think we should pick the "official" one. > > Even better. > > > > Apart from that the two patches LGTM, especially if it allows me > > > to > > > use gnome-maps again. :-) > > Do "the two patches" refer to this one alone or also to the one > > bumping > > the package to 3.38? > > Both, but I hadn’t realized there’s was an exclusive choice. Well, the exclusive choice comes from the fact that the patch we would have to add to 3.36 is already present in 3.38.1+. So bumping to a sufficiently recent gnome-maps "voids" the patch in that it is already applied. > > Again, I'm a little unsure what would be the preferred solution > > here, > > as either patch adds additional code that would probably need to be > > reverted by Raghav in their GNOME 40 work. > > I don’t know, I think it’s good to have short-term fixes anyway and > it’s > OK if they have to be undone when we eventually upgrade. Your call! I went with bumping to 3.38. While I hope the test suite doesn't break in 40 the same way it does here, there is a slim chance the phase I've added needs to be kept. Thanks