From: Leo Prikler <leo.prikler@student.tugraz.at>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 49670@debbugs.gnu.org
Subject: [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to.
Date: Thu, 22 Jul 2021 10:31:21 +0200 [thread overview]
Message-ID: <5af9faa539c916abf3fce795e1e127614456fa43.camel@student.tugraz.at> (raw)
In-Reply-To: <87fsw7hhce.fsf@gnu.org>
Am Mittwoch, den 21.07.2021, 16:28 +0200 schrieb Ludovic Courtès:
> Hi!
>
> Leo Prikler <leo.prikler@student.tugraz.at> skribis:
>
> > * gnu/packages/patches/gnome-maps-really-do-unregister.patch: New
> > file.
> > * gnu/packages/geo.scm (gnome-maps)[patches]: Add it here...
> > * gnu/local.mk (dist_patch_DATA): ... and here.
> > ---
> > I've opened a separate merge request upsteam [1], but since their
> > CI is
> > currently failing, it will take some time for this patch to make it
> > into a
> > release.
> >
> > [1] https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/187
> > + (patches
> > + (search-patches
> > + "gnome-maps-really-do-unregister.patch"))))
>
> This can all go on a single line.
Forgot to count there, but thanks.
> > +++ b/gnu/packages/patches/gnome-maps-really-do-unregister.patch
> > @@ -0,0 +1,13 @@
> > +Index: gnome-maps-3.36.7/src/application.js
>
> Could you add a line at the top of this patch saying what it does
> along with a link to the merge request above?
It turns out a similar fix already exists upstream [1], so if we decide
to backport that to 3.36 instead of bumping the package to 3.38, I
think we should pick the "official" one.
> Apart from that the two patches LGTM, especially if it allows me to
> use gnome-maps again. :-)
Do "the two patches" refer to this one alone or also to the one bumping
the package to 3.38? Again, I'm a little unsure what would be the
preferred solution here, as either patch adds additional code that
would probably need to be reverted by Raghav in their GNOME 40 work.
Regards,
[1]
https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/2e64cf6909dfca559fcaf54c470134ecc4d64e9a
next prev parent reply other threads:[~2021-07-22 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 22:34 [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to Leo Prikler
2021-07-21 11:04 ` [bug#49670] [PATCH] gnu: gnome-maps: Update to 3.38.5 Leo Prikler
2021-07-21 14:28 ` [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to Ludovic Courtès
2021-07-22 8:31 ` Leo Prikler [this message]
2021-07-23 9:29 ` Ludovic Courtès
2021-07-23 10:51 ` bug#49670: " Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5af9faa539c916abf3fce795e1e127614456fa43.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=49670@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.