all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 49670@debbugs.gnu.org
Subject: [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to.
Date: Wed, 21 Jul 2021 16:28:01 +0200	[thread overview]
Message-ID: <87fsw7hhce.fsf@gnu.org> (raw)
In-Reply-To: <20210720223452.9471-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Wed, 21 Jul 2021 00:34:53 +0200")

Hi!

Leo Prikler <leo.prikler@student.tugraz.at> skribis:

> * gnu/packages/patches/gnome-maps-really-do-unregister.patch: New file.
> * gnu/packages/geo.scm (gnome-maps)[patches]: Add it here...
> * gnu/local.mk (dist_patch_DATA): ... and here.
> ---
> I've opened a separate merge request upsteam [1], but since their CI is
> currently failing, it will take some time for this patch to make it into a
> release.
>
> [1] https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/187

> +              (patches
> +               (search-patches
> +                "gnome-maps-really-do-unregister.patch"))))

This can all go on a single line.

> +++ b/gnu/packages/patches/gnome-maps-really-do-unregister.patch
> @@ -0,0 +1,13 @@
> +Index: gnome-maps-3.36.7/src/application.js

Could you add a line at the top of this patch saying what it does along
with a link to the merge request above?

Apart from that the two patches LGTM, especially if it allows me to use
gnome-maps again.  :-)

Thanks!

Ludo’.




  parent reply	other threads:[~2021-07-21 14:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 22:34 [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to Leo Prikler
2021-07-21 11:04 ` [bug#49670] [PATCH] gnu: gnome-maps: Update to 3.38.5 Leo Prikler
2021-07-21 14:28 ` Ludovic Courtès [this message]
2021-07-22  8:31   ` [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to Leo Prikler
2021-07-23  9:29     ` Ludovic Courtès
2021-07-23 10:51       ` bug#49670: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsw7hhce.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=49670@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.