From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qNe2Dwkt+WB3cAEAgWs5BA (envelope-from ) for ; Thu, 22 Jul 2021 10:32:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QHt/Cwkt+WBDQwAA1q6Kng (envelope-from ) for ; Thu, 22 Jul 2021 08:32:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 821A4EE64 for ; Thu, 22 Jul 2021 10:32:08 +0200 (CEST) Received: from localhost ([::1]:47950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6U7j-0003T9-J7 for larch@yhetil.org; Thu, 22 Jul 2021 04:32:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6U7d-0003Sm-Ux for guix-patches@gnu.org; Thu, 22 Jul 2021 04:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56029) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6U7d-0002Ls-NI for guix-patches@gnu.org; Thu, 22 Jul 2021 04:32:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6U7d-0000wL-Lh for guix-patches@gnu.org; Thu, 22 Jul 2021 04:32:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Jul 2021 08:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49670 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49670@debbugs.gnu.org Received: via spool by 49670-submit@debbugs.gnu.org id=B49670.16269426873571 (code B ref 49670); Thu, 22 Jul 2021 08:32:01 +0000 Received: (at 49670) by debbugs.gnu.org; 22 Jul 2021 08:31:27 +0000 Received: from localhost ([127.0.0.1]:39342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6U75-0000vW-EH for submit@debbugs.gnu.org; Thu, 22 Jul 2021 04:31:27 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:42610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6U73-0000vN-05 for 49670@debbugs.gnu.org; Thu, 22 Jul 2021 04:31:26 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GVlzG00Phz1LWpG; Thu, 22 Jul 2021 10:31:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GVlzG00Phz1LWpG DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626942682; bh=ejqL6lHnX7WofVWhCkqXU+uAy7lZNsSR7/NUbLEQXTo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Jj1yHihB63/0cuk6ywZQ88ZxlPdX7gJZQ69mZITg8lOI2FhH8v9yJAekviaiKAHSy a9S2FLAuTNdC0+g08lgwkRvZ9Hle0hNmEDLcwdwbWgufVcDVncOSKKkduLZzGGPOwO Ot7OPO8hAkjRtySCQhUIbIFfUVbwRVQPPlKrFJeM= Message-ID: <5af9faa539c916abf3fce795e1e127614456fa43.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 22 Jul 2021 10:31:21 +0200 In-Reply-To: <87fsw7hhce.fsf@gnu.org> References: <20210720223452.9471-1-leo.prikler@student.tugraz.at> <87fsw7hhce.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626942728; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ejqL6lHnX7WofVWhCkqXU+uAy7lZNsSR7/NUbLEQXTo=; b=RX+eQSJ72W+t6ga8Ji9DX2WGtkFa844yxQdxai9WB8LryirMXYe6BHeIgsbJ0g95C4gv+r Uz0LerRc/w47SUgikzdhEr/7BX3KgY4JlBg4jrqhLLVYU8/7fH5Q4ty24Rgrzo3hISorAH mOkQ+DFWhdnKhxzrorDCmmWFQYXmmZMc9nI8aI+r3wIW4j6ypOc/Y4zBGShzhPij3wQARI 8LoGnx5GRVxHkab6BvVNZuzLDknASgLGfQeRDNpJ7FsX680jCc/ZsFsnN5LOW1NswYphkK 1SemVGBvSd9Ao8WegIrpdfkxzl4F+8i9FUoYlWEcIDYVs+jG6jm4ZQfoDy7sSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626942728; a=rsa-sha256; cv=none; b=Qhq+dK7EsErjk4mX1NOToAUy7EY2YdfzTT529CRpFbqamplEd45t3QGJGk4k4Ib8crhCRG lMDo0AuT9v71b6ILprihbgqf0z8zfQwo6o+yRfYU/nFbLCQ8ttuiQ5GuS4aSWQhYpUgO0p tOz+VAiZ/+qKwdvoIbod7ReSG9eyxRe/pJi3MYuKXytdXLLFehkDx71gowlNtlJq2+87gJ PYuTZx1XYoTkiQ4YWfS6nN9ahlQSfhy3wJqYns5VDfHEyvgARmSdRUOQfrt6IS0tYE6VYo GZJKfqrQRbtG07mjMLfbYQneyeEwPAk3Fd+0U6Aa5Ye01B5VOi0Tu7+zTV5miw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Jj1yHihB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Jj1yHihB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 821A4EE64 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: ILisUSc7fgyK Am Mittwoch, den 21.07.2021, 16:28 +0200 schrieb Ludovic Courtès: > Hi! > > Leo Prikler skribis: > > > * gnu/packages/patches/gnome-maps-really-do-unregister.patch: New > > file. > > * gnu/packages/geo.scm (gnome-maps)[patches]: Add it here... > > * gnu/local.mk (dist_patch_DATA): ... and here. > > --- > > I've opened a separate merge request upsteam [1], but since their > > CI is > > currently failing, it will take some time for this patch to make it > > into a > > release. > > > > [1] https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/187 > > + (patches > > + (search-patches > > + "gnome-maps-really-do-unregister.patch")))) > > This can all go on a single line. Forgot to count there, but thanks. > > +++ b/gnu/packages/patches/gnome-maps-really-do-unregister.patch > > @@ -0,0 +1,13 @@ > > +Index: gnome-maps-3.36.7/src/application.js > > Could you add a line at the top of this patch saying what it does > along with a link to the merge request above? It turns out a similar fix already exists upstream [1], so if we decide to backport that to 3.36 instead of bumping the package to 3.38, I think we should pick the "official" one. > Apart from that the two patches LGTM, especially if it allows me to > use gnome-maps again. :-) Do "the two patches" refer to this one alone or also to the one bumping the package to 3.38? Again, I'm a little unsure what would be the preferred solution here, as either patch adds additional code that would probably need to be reverted by Raghav in their GNOME 40 work. Regards, [1] https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/2e64cf6909dfca559fcaf54c470134ecc4d64e9a