From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czfwd-0004Y8-HU for guix-patches@gnu.org; Sun, 16 Apr 2017 04:54:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czfwY-0007Cf-Nf for guix-patches@gnu.org; Sun, 16 Apr 2017 04:54:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51518) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1czfwY-0007C2-Eq for guix-patches@gnu.org; Sun, 16 Apr 2017 04:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1czfwY-0001Kk-8u for guix-patches@gnu.org; Sun, 16 Apr 2017 04:54:02 -0400 Subject: bug#26500: [PATCH] gnu: Add mcomix. Resent-Message-ID: Message-Id: <23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Sun, 16 Apr 2017 14:23:02 +0530 In-reply-to: <20170415090932.ed7dzowf6s5cwln5@abyayala> References: <495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@mailjet.com> <20170415090932.ed7dzowf6s5cwln5@abyayala> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26500@debbugs.gnu.org > No, I think a short comment behind or above the #:python keyword is > necessary, in case someone in the future wonders "Hey, why do we package > this for python 2 only and not for python 3" even if both languages are > developed in parallel. Ok, it doesn't hurt to keep the comment. Let's keep it. > + (description "A customizable image viewer that specializes as > +a comic and manga reader. It supports a variety of container formats > +including CBR, CBZ, CB7, CBT, LHA. > +For 7z support install the p7zip package. > +For rar support install the unrar package. > +For pdf support install the mupdf package.") Instead of mentioning p7zip, unrar and mupdf in the description, it would be better if we could make them inputs and patch all references to the executables in the source with their absolute paths. Could you try this= ? =