[bug#30886] Libreoffice

[bug#30886] Libreoffice

[Thomas Sigurdsen]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

Here is two patches for libreoffice, both are changes of the configure flags
in the definition.

First is a change according to a comment. I started looking at these because
I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
needed for NSS, but it is now enabled as per the old comment.

Second is enabling gtk2. This fixes  bug#30642 for me. I think this is
because I'm not using gnome and therefore libreoffice can't find what it
needs. But Idk.

Filechooser dialog and digital signatures work with these 2 changes here.

[-- Attachment #2: 0001-The-corresponding-inputs-looks-to-be-packaged-builds.patch --]
[-- Type: text/x-patch, Size: 1042 bytes --]

From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001
From: Tonton <tonton@riseup.net>
Date: Tue, 20 Mar 2018 17:23:52 +0100
Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds
 succesfully)

Signed-off-by: Tonton <tonton@riseup.net>
---
 gnu/packages/libreoffice.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index 316602adb..77c83b014 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -1027,8 +1027,7 @@ and to return information on pronunciations, meanings and synonyms.")
           "--without-fonts"
           ;; With java, the build fails since sac.jar is missing.
           "--without-java"
-          ;; FIXME: Enable once the corresponding inputs are packaged.
-          "--without-system-npapi-headers"
+          "--with-system-npapi-headers"
           "--disable-coinmp"
           "--disable-firebird-sdbc" ; embedded firebird
           "--disable-gltf"
-- 
2.16.2


[-- Attachment #3: 0002-Enable-gtk2.patch --]
[-- Type: text/x-patch, Size: 1052 bytes --]

From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001
From: Tonton <tonton@riseup.net>
Date: Tue, 20 Mar 2018 17:24:49 +0100
Subject: [PATCH 2/2] Enable gtk2

Racionale: on systems without gtk2 the openfile dialog makes openoffice
crash. This (enabling gtk2) fixes this.

Signed-off-by: Tonton <tonton@riseup.net>
---
 gnu/packages/libreoffice.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index 77c83b014..92ff0f3b0 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -1035,7 +1035,7 @@ and to return information on pronunciations, meanings and synonyms.")
           ;; patching the build scripts to work with GCC5.  Try enabling this
           ;; when our default compiler is >=GCC 6.
           "--disable-pdfium"
-          "--disable-gtk" ; disable use of GTK+ 2
+          "--enable-gtk"
           "--without-doxygen")))
     (home-page "https://www.libreoffice.org/")
     (synopsis "Office suite")
-- 
2.16.2

[bug#30886] Libreoffice

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 2477 bytes --]

Hello Thomas,

Sorry for the late reply.

Thomas Sigurdsen <thomas.sigurdsen@gmail.com> skribis:

> First is a change according to a comment. I started looking at these because
> I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
> needed for NSS, but it is now enabled as per the old comment.

OK.

> Second is enabling gtk2. This fixes  bug#30642 for me. I think this is
> because I'm not using gnome and therefore libreoffice can't find what it
> needs. But Idk.
>
> Filechooser dialog and digital signatures work with these 2 changes here.
>
>>From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton@riseup.net>
> Date: Tue, 20 Mar 2018 17:23:52 +0100
> Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds
>  succesfully)
>
> Signed-off-by: Tonton <tonton@riseup.net>
> ---
>  gnu/packages/libreoffice.scm | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
> index 316602adb..77c83b014 100644
> --- a/gnu/packages/libreoffice.scm
> +++ b/gnu/packages/libreoffice.scm
> @@ -1027,8 +1027,7 @@ and to return information on pronunciations, meanings and synonyms.")
>            "--without-fonts"
>            ;; With java, the build fails since sac.jar is missing.
>            "--without-java"
> -          ;; FIXME: Enable once the corresponding inputs are packaged.
> -          "--without-system-npapi-headers"
> +          "--with-system-npapi-headers"

I suspect this doesn’t have any effect because ‘configure’ complains:

--8<---------------cut here---------------start------------->8---
configure: WARNING: unrecognized options: --enable-fast-install, --enable-verbose, --with-system-npapi-headers
--8<---------------cut here---------------end--------------->8---

Are you sure digital signatures don’t work without this patch?

>>From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton@riseup.net>
> Date: Tue, 20 Mar 2018 17:24:49 +0100
> Subject: [PATCH 2/2] Enable gtk2
>
> Racionale: on systems without gtk2 the openfile dialog makes openoffice
> crash. This (enabling gtk2) fixes this.
>
> Signed-off-by: Tonton <tonton@riseup.net>

This is not OK because we’d rather keep using GTK+3.

Could you try the patch below and see if it fixes the FileChooser issue?

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 787 bytes --]

diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index ef40e018b..5b8991299 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -27,6 +27,7 @@
 
 (define-module (gnu packages libreoffice)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system trivial)
   #:use-module (guix download)
   #:use-module ((guix licenses)
@@ -855,7 +856,7 @@ and to return information on pronunciations, meanings and synonyms.")
       (sha256
        (base32
         "0icd8h221gp2dsbn6d35flwhqhcfpx66cjc5dg8yifhhvrfam74i"))))
-    (build-system gnu-build-system)
+    (build-system glib-or-gtk-build-system)
     (native-inputs
      `(("bison" ,bison)
        ("cppunit" ,cppunit-1.14)

[bug#30886] Libreoffice

[Thomas Sigurdsen]

Hi,

Seems this issue is a slow back and forth thing :)

I applied the patch and built it. The build fails before finishing with a
scheme backtrace. At first I thought it didn't finish anything, but it seems
to have finished building libreoffice because I get:

-------
Installation finished, you can now execute:
/gnu/store/hf2a8f4rca9dvw1s6ffcsrbcsp39aj83-libreoffice-5.4.6.2/lib/libreoffice/program/soffice
------

And then the most important part of the error after (I think):

------
phase `install' succeeded after 27.2 seconds
starting phase `bin-and-desktop-install'
Backtrace:
------

The backtrace points to trying to copy a file that might exist... the
following path exists in /tmp/guix-build-...libreoffice..../ - but ofcourse,
the whole path is not in the backtrace:
	0 (copy-file "sysui/desktop/appstream-appdata/libreoffic…" …)


But, I can run the generated binary from the store. And the filechooser
dialog still causes libreoffice to crash:
"(soffice:9332): GLib-GIO-ERROR **: Settings schema
'org.gtk.Settings.FileChooser' is not installed "

On Wed, 04 Apr 2018 14:30:55 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Hello Thomas,
> 
> Sorry for the late reply.
> 
> Thomas Sigurdsen <thomas.sigurdsen@gmail.com> skribis:
> 
> > First is a change according to a comment. I started looking at these
> > because I wanted to check digital signatures and NSS was needed. Not sure
> > NPAPI is needed for NSS, but it is now enabled as per the old comment.  
> 
> OK.
> 
> > Second is enabling gtk2. This fixes  bug#30642 for me. I think this is
> > because I'm not using gnome and therefore libreoffice can't find what it
> > needs. But Idk.
> >
> > Filechooser dialog and digital signatures work with these 2 changes here.
> >  
> >>From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001  
> > From: Tonton <tonton@riseup.net>
> > Date: Tue, 20 Mar 2018 17:23:52 +0100
> > Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds
> >  succesfully)
> >
> > Signed-off-by: Tonton <tonton@riseup.net>
> > ---
> >  gnu/packages/libreoffice.scm | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
> > index 316602adb..77c83b014 100644
> > --- a/gnu/packages/libreoffice.scm
> > +++ b/gnu/packages/libreoffice.scm
> > @@ -1027,8 +1027,7 @@ and to return information on pronunciations,
> > meanings and synonyms.") "--without-fonts"
> >            ;; With java, the build fails since sac.jar is missing.
> >            "--without-java"
> > -          ;; FIXME: Enable once the corresponding inputs are packaged.
> > -          "--without-system-npapi-headers"
> > +          "--with-system-npapi-headers"  
> 
> I suspect this doesn’t have any effect because ‘configure’ complains:
> 
> --8<---------------cut here---------------start------------->8---
> configure: WARNING: unrecognized options: --enable-fast-install,
> --enable-verbose, --with-system-npapi-headers --8<---------------cut
> here---------------end--------------->8---
> 
> Are you sure digital signatures don’t work without this patch?
> 
> >>From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001  
> > From: Tonton <tonton@riseup.net>
> > Date: Tue, 20 Mar 2018 17:24:49 +0100
> > Subject: [PATCH 2/2] Enable gtk2
> >
> > Racionale: on systems without gtk2 the openfile dialog makes openoffice
> > crash. This (enabling gtk2) fixes this.
> >
> > Signed-off-by: Tonton <tonton@riseup.net>  
> 
> This is not OK because we’d rather keep using GTK+3.
> 
> Could you try the patch below and see if it fixes the FileChooser issue?
> 
> Thanks,
> Ludo’.
> 

[bug#30886] Libreoffice

[Nils Gillmann]

Ludovic Courtès transcribed 3.3K bytes:
> Hello Thomas,
> 
> Sorry for the late reply.
> 
> Thomas Sigurdsen <thomas.sigurdsen@gmail.com> skribis:
> 
> > First is a change according to a comment. I started looking at these because
> > I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
> > needed for NSS, but it is now enabled as per the old comment.
> 
> OK.
> 
> > Second is enabling gtk2. This fixes  bug#30642 for me. I think this is
> > because I'm not using gnome and therefore libreoffice can't find what it
> > needs. But Idk.
> >
> > Filechooser dialog and digital signatures work with these 2 changes here.
> >
> >>From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001
> > From: Tonton <tonton@riseup.net>
> > Date: Tue, 20 Mar 2018 17:23:52 +0100
> > Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds
> >  succesfully)
> >
> > Signed-off-by: Tonton <tonton@riseup.net>
> > ---
> >  gnu/packages/libreoffice.scm | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
> > index 316602adb..77c83b014 100644
> > --- a/gnu/packages/libreoffice.scm
> > +++ b/gnu/packages/libreoffice.scm
> > @@ -1027,8 +1027,7 @@ and to return information on pronunciations, meanings and synonyms.")
> >            "--without-fonts"
> >            ;; With java, the build fails since sac.jar is missing.
> >            "--without-java"
> > -          ;; FIXME: Enable once the corresponding inputs are packaged.
> > -          "--without-system-npapi-headers"
> > +          "--with-system-npapi-headers"
> 
> I suspect this doesn’t have any effect because ‘configure’ complains:
> 
> --8<---------------cut here---------------start------------->8---
> configure: WARNING: unrecognized options: --enable-fast-install, --enable-verbose, --with-system-npapi-headers
> --8<---------------cut here---------------end--------------->8---
> 
> Are you sure digital signatures don’t work without this patch?
> 
> >>From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001
> > From: Tonton <tonton@riseup.net>
> > Date: Tue, 20 Mar 2018 17:24:49 +0100
> > Subject: [PATCH 2/2] Enable gtk2
> >
> > Racionale: on systems without gtk2 the openfile dialog makes openoffice
> > crash. This (enabling gtk2) fixes this.

A quick workaround which I found some time ago:

Workaround: Libreoffice options > "Libreoffice" > "general" > "Use Libreoffice dialogs".

> > Signed-off-by: Tonton <tonton@riseup.net>
> 
> This is not OK because we’d rather keep using GTK+3.
> 
> Could you try the patch below and see if it fixes the FileChooser issue?
> 
> Thanks,
> Ludo’.
> 

> diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
> index ef40e018b..5b8991299 100644
> --- a/gnu/packages/libreoffice.scm
> +++ b/gnu/packages/libreoffice.scm
> @@ -27,6 +27,7 @@
>  
>  (define-module (gnu packages libreoffice)
>    #:use-module (guix build-system gnu)
> +  #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system trivial)
>    #:use-module (guix download)
>    #:use-module ((guix licenses)
> @@ -855,7 +856,7 @@ and to return information on pronunciations, meanings and synonyms.")
>        (sha256
>         (base32
>          "0icd8h221gp2dsbn6d35flwhqhcfpx66cjc5dg8yifhhvrfam74i"))))
> -    (build-system gnu-build-system)
> +    (build-system glib-or-gtk-build-system)
>      (native-inputs
>       `(("bison" ,bison)
>         ("cppunit" ,cppunit-1.14)

[bug#30886] Libreoffice

[Clément Lassieur]

There was a similar issue some time ago on Icecat, see
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26593

Hope this helps.
Clément

[bug#30886] Libreoffice

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

On Tue, Mar 20, 2018 at 06:28:29PM +0100, Thomas Sigurdsen wrote:
> First is a change according to a comment. I started looking at these because
> I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
> needed for NSS, but it is now enabled as per the old comment.

What is the status of this patch? Do you still want it to be applied? It
seems the conversation just fizzled out.

> Second is enabling gtk2. This fixes  bug#30642 for me. I think this is
> because I'm not using gnome and therefore libreoffice can't find what it
> needs. But Idk.

The file chooser dialog issue is fixed since commit
994bccd9443032141accede0e403cbfb62f6c63e.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#30886] "LibreOffice digital signature support?"

[zimoun]

Hi,

On Tue, 12 Feb 2019 at 17:56, Leo Famulari <leo@famulari.name> wrote:
> On Tue, Mar 20, 2018 at 06:28:29PM +0100, Thomas Sigurdsen wrote:
>> First is a change according to a comment. I started looking at these because
>> I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
>> needed for NSS, but it is now enabled as per the old comment.
>
> What is the status of this patch? Do you still want it to be applied? It
> seems the conversation just fizzled out.
>
>> Second is enabling gtk2. This fixes  bug#30642 for me. I think this is
>> because I'm not using gnome and therefore libreoffice can't find what it
>> needs. But Idk.
>
> The file chooser dialog issue is fixed since commit
> 994bccd9443032141accede0e403cbfb62f6c63e.

Well, I think this patch #30886 [1] can be closed.  The patches had
been sent on 2018 and improvements mentioned on 2019.

The initial report mentions that the patches are fixing bug #30642 [2]
which had been closed 4 years ago.

Any objection for closing?

1: https://issues.guix.gnu.org/issue/30886
2: https://issues.guix.gnu.org/issue/30642

Cheers,
simon

bug#30886: "LibreOffice digital signature support?"

[zimoun]

Hi,

On Fri, 21 Apr 2023 at 09:51, zimoun <zimon.toutoune@gmail.com> wrote:

> Any objection for closing?

I am closing.  Feel free to reopen if I missed something.


Cheers,
simon