From: ludo@gnu.org (Ludovic Courtès)
To: Thomas Sigurdsen <thomas.sigurdsen@gmail.com>
Cc: 30886@debbugs.gnu.org
Subject: [bug#30886] Libreoffice
Date: Wed, 04 Apr 2018 14:30:55 +0200 [thread overview]
Message-ID: <87efjvcfwg.fsf@gnu.org> (raw)
In-Reply-To: <20180320182829.2b5abb89@merlin.browniehive.net> (Thomas Sigurdsen's message of "Tue, 20 Mar 2018 18:28:29 +0100")
[-- Attachment #1: Type: text/plain, Size: 2477 bytes --]
Hello Thomas,
Sorry for the late reply.
Thomas Sigurdsen <thomas.sigurdsen@gmail.com> skribis:
> First is a change according to a comment. I started looking at these because
> I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
> needed for NSS, but it is now enabled as per the old comment.
OK.
> Second is enabling gtk2. This fixes bug#30642 for me. I think this is
> because I'm not using gnome and therefore libreoffice can't find what it
> needs. But Idk.
>
> Filechooser dialog and digital signatures work with these 2 changes here.
>
>>From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton@riseup.net>
> Date: Tue, 20 Mar 2018 17:23:52 +0100
> Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds
> succesfully)
>
> Signed-off-by: Tonton <tonton@riseup.net>
> ---
> gnu/packages/libreoffice.scm | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
> index 316602adb..77c83b014 100644
> --- a/gnu/packages/libreoffice.scm
> +++ b/gnu/packages/libreoffice.scm
> @@ -1027,8 +1027,7 @@ and to return information on pronunciations, meanings and synonyms.")
> "--without-fonts"
> ;; With java, the build fails since sac.jar is missing.
> "--without-java"
> - ;; FIXME: Enable once the corresponding inputs are packaged.
> - "--without-system-npapi-headers"
> + "--with-system-npapi-headers"
I suspect this doesn’t have any effect because ‘configure’ complains:
--8<---------------cut here---------------start------------->8---
configure: WARNING: unrecognized options: --enable-fast-install, --enable-verbose, --with-system-npapi-headers
--8<---------------cut here---------------end--------------->8---
Are you sure digital signatures don’t work without this patch?
>>From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton@riseup.net>
> Date: Tue, 20 Mar 2018 17:24:49 +0100
> Subject: [PATCH 2/2] Enable gtk2
>
> Racionale: on systems without gtk2 the openfile dialog makes openoffice
> crash. This (enabling gtk2) fixes this.
>
> Signed-off-by: Tonton <tonton@riseup.net>
This is not OK because we’d rather keep using GTK+3.
Could you try the patch below and see if it fixes the FileChooser issue?
Thanks,
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 787 bytes --]
diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index ef40e018b..5b8991299 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -27,6 +27,7 @@
(define-module (gnu packages libreoffice)
#:use-module (guix build-system gnu)
+ #:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system trivial)
#:use-module (guix download)
#:use-module ((guix licenses)
@@ -855,7 +856,7 @@ and to return information on pronunciations, meanings and synonyms.")
(sha256
(base32
"0icd8h221gp2dsbn6d35flwhqhcfpx66cjc5dg8yifhhvrfam74i"))))
- (build-system gnu-build-system)
+ (build-system glib-or-gtk-build-system)
(native-inputs
`(("bison" ,bison)
("cppunit" ,cppunit-1.14)
next prev parent reply other threads:[~2018-04-04 12:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 17:28 [bug#30886] Libreoffice Thomas Sigurdsen
2018-04-04 12:30 ` Ludovic Courtès [this message]
2018-04-13 20:58 ` Thomas Sigurdsen
2018-04-14 10:04 ` Nils Gillmann
2018-04-14 11:05 ` Clément Lassieur
2019-02-12 22:56 ` Leo Famulari
2023-04-21 7:51 ` [bug#30886] "LibreOffice digital signature support?" zimoun
2023-04-24 8:26 ` bug#30886: " zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efjvcfwg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30886@debbugs.gnu.org \
--cc=thomas.sigurdsen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.