From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7I3P-0002xo-VO for guix-patches@gnu.org; Sat, 14 Apr 2018 06:05:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7I3L-0006nZ-16 for guix-patches@gnu.org; Sat, 14 Apr 2018 06:05:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f7I3K-0006nR-TQ for guix-patches@gnu.org; Sat, 14 Apr 2018 06:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f7I3K-0000eZ-G3 for guix-patches@gnu.org; Sat, 14 Apr 2018 06:05:02 -0400 Subject: [bug#30886] Libreoffice Resent-Message-ID: Date: Sat, 14 Apr 2018 10:04:37 +0000 From: Nils Gillmann Message-ID: <20180414100437.yarnkprfp4b5gxs4@abyayala> References: <20180320182829.2b5abb89@merlin.browniehive.net> <87efjvcfwg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87efjvcfwg.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30886@debbugs.gnu.org, Thomas Sigurdsen Ludovic Courtès transcribed 3.3K bytes: > Hello Thomas, > > Sorry for the late reply. > > Thomas Sigurdsen skribis: > > > First is a change according to a comment. I started looking at these because > > I wanted to check digital signatures and NSS was needed. Not sure NPAPI is > > needed for NSS, but it is now enabled as per the old comment. > > OK. > > > Second is enabling gtk2. This fixes bug#30642 for me. I think this is > > because I'm not using gnome and therefore libreoffice can't find what it > > needs. But Idk. > > > > Filechooser dialog and digital signatures work with these 2 changes here. > > > >>From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001 > > From: Tonton > > Date: Tue, 20 Mar 2018 17:23:52 +0100 > > Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds > > succesfully) > > > > Signed-off-by: Tonton > > --- > > gnu/packages/libreoffice.scm | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm > > index 316602adb..77c83b014 100644 > > --- a/gnu/packages/libreoffice.scm > > +++ b/gnu/packages/libreoffice.scm > > @@ -1027,8 +1027,7 @@ and to return information on pronunciations, meanings and synonyms.") > > "--without-fonts" > > ;; With java, the build fails since sac.jar is missing. > > "--without-java" > > - ;; FIXME: Enable once the corresponding inputs are packaged. > > - "--without-system-npapi-headers" > > + "--with-system-npapi-headers" > > I suspect this doesn’t have any effect because ‘configure’ complains: > > --8<---------------cut here---------------start------------->8--- > configure: WARNING: unrecognized options: --enable-fast-install, --enable-verbose, --with-system-npapi-headers > --8<---------------cut here---------------end--------------->8--- > > Are you sure digital signatures don’t work without this patch? > > >>From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001 > > From: Tonton > > Date: Tue, 20 Mar 2018 17:24:49 +0100 > > Subject: [PATCH 2/2] Enable gtk2 > > > > Racionale: on systems without gtk2 the openfile dialog makes openoffice > > crash. This (enabling gtk2) fixes this. A quick workaround which I found some time ago: Workaround: Libreoffice options > "Libreoffice" > "general" > "Use Libreoffice dialogs". > > Signed-off-by: Tonton > > This is not OK because we’d rather keep using GTK+3. > > Could you try the patch below and see if it fixes the FileChooser issue? > > Thanks, > Ludo’. > > diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm > index ef40e018b..5b8991299 100644 > --- a/gnu/packages/libreoffice.scm > +++ b/gnu/packages/libreoffice.scm > @@ -27,6 +27,7 @@ > > (define-module (gnu packages libreoffice) > #:use-module (guix build-system gnu) > + #:use-module (guix build-system glib-or-gtk) > #:use-module (guix build-system trivial) > #:use-module (guix download) > #:use-module ((guix licenses) > @@ -855,7 +856,7 @@ and to return information on pronunciations, meanings and synonyms.") > (sha256 > (base32 > "0icd8h221gp2dsbn6d35flwhqhcfpx66cjc5dg8yifhhvrfam74i")))) > - (build-system gnu-build-system) > + (build-system glib-or-gtk-build-system) > (native-inputs > `(("bison" ,bison) > ("cppunit" ,cppunit-1.14)