* [bug#27548] [PATCH] gnu: Add python-xenon
@ 2017-07-01 14:44 Muriithi Frederick Muriuki
2017-07-11 19:03 ` Marius Bakke
2017-10-16 13:24 ` bug#27548: " Ludovic Courtès
0 siblings, 2 replies; 4+ messages in thread
From: Muriithi Frederick Muriuki @ 2017-07-01 14:44 UTC (permalink / raw)
To: 27548
* gnu/packages/python.scm (python-xenon, python2-xenon) New variables.
---
gnu/packages/python.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6e1e289e9..1167b0933 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -15512,3 +15512,49 @@ pure Python module.")
(define-public python2-rencode
(package-with-python2 python-rencode))
+
+(define-public python-xenon
+ (package
+ (name "python-xenon")
+ (version "0.5.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "xenon" version))
+ (sha256
+ (base32
+ "14kby2y48vp3sgwxqlm5d5789yibqwb1qli5fwcmdqg3iayrbklc"))))
+ (build-system python-build-system)
+ (native-inputs
+ `(("python-pyyaml" ,python-pyyaml)
+ ("python-radon" ,python-radon)
+ ("python-requests" ,python-requests)
+ ("python-flake8" ,python-flake8)
+ ("python-tox" ,python-tox)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'build 'patch-test-requirements
+ (lambda* (#:key inputs #:allow-other-keys)
+ ;; Update requirements from dependecy==version
+ ;; to dependency>=version
+ (substitute* "requirements.txt"
+ (("==") ">=")
+ ((",<1.5.0") ""))
+ ;; Remove httpretty dependency for tests
+ (substitute* "setup.py"
+ (("httpretty") ""))
+ #t)))))
+ (home-page "https://xenon.readthedocs.org/")
+ (synopsis
+ "Monitor code metrics for Python on your CI server")
+ (description
+ "@code{Xenon} is a monitoring tool based on Radon. It monitors code’s
+complexity. Ideally, @code{xenon} is run every time code is committed. Through
+command line options, various thresholds can be set for the complexity of code.
+It will fail (i.e. it will exit with a non-zero exit code) when any of these
+equirements is not met.")
+ (license license:expat)))
+
+(define-public python2-xenon
+ (package-with-python2 python-xenon))
--
2.13.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#27548] [PATCH] gnu: Add python-xenon
2017-07-01 14:44 [bug#27548] [PATCH] gnu: Add python-xenon Muriithi Frederick Muriuki
@ 2017-07-11 19:03 ` Marius Bakke
2017-10-16 13:24 ` bug#27548: " Ludovic Courtès
1 sibling, 0 replies; 4+ messages in thread
From: Marius Bakke @ 2017-07-11 19:03 UTC (permalink / raw)
To: Muriithi Frederick Muriuki, 27548
[-- Attachment #1: Type: text/plain, Size: 2414 bytes --]
Hello!
Sorry for the slooow response :-)
The patch mostly LGTM. A few minor comments:
Muriithi Frederick Muriuki <fredmanglis@gmail.com> writes:
> * gnu/packages/python.scm (python-xenon, python2-xenon) New variables.
[...]
> +(define-public python-xenon
> + (package
> + (name "python-xenon")
> + (version "0.5.1")
It looks like 0.5.2 was recently released. Can you try updating to it?
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "xenon" version))
> + (sha256
> + (base32
> + "14kby2y48vp3sgwxqlm5d5789yibqwb1qli5fwcmdqg3iayrbklc"))))
> + (build-system python-build-system)
> + (native-inputs
> + `(("python-pyyaml" ,python-pyyaml)
> + ("python-radon" ,python-radon)
> + ("python-requests" ,python-requests)
> + ("python-flake8" ,python-flake8)
Indentation is off :)
> + ("python-tox" ,python-tox)))
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'build 'patch-test-requirements
> + (lambda* (#:key inputs #:allow-other-keys)
> + ;; Update requirements from dependecy==version
Missing letter here: ^^^
> + ;; to dependency>=version
> + (substitute* "requirements.txt"
> + (("==") ">=")
> + ((",<1.5.0") ""))
> + ;; Remove httpretty dependency for tests
> + (substitute* "setup.py"
> + (("httpretty") ""))
Why is this necessary? Can you expand on this comment?
> + #t)))))
> + (home-page "https://xenon.readthedocs.org/")
> + (synopsis
> + "Monitor code metrics for Python on your CI server")
> + (description
> + "@code{Xenon} is a monitoring tool based on Radon. It monitors code’s
I think we can drop @code here since it's used as a name. Side note: It
would be cool if we could cross-reference packages in descriptions.
Sorry for the nit-picks! I'll go through the other patches shortly.
> +complexity. Ideally, @code{xenon} is run every time code is committed. Through
> +command line options, various thresholds can be set for the complexity of code.
> +It will fail (i.e. it will exit with a non-zero exit code) when any of these
> +equirements is not met.")
> + (license license:expat)))
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#27548: [PATCH] gnu: Add python-xenon
2017-07-01 14:44 [bug#27548] [PATCH] gnu: Add python-xenon Muriithi Frederick Muriuki
2017-07-11 19:03 ` Marius Bakke
@ 2017-10-16 13:24 ` Ludovic Courtès
2017-10-16 13:25 ` [bug#27548] " Frederick Muriithi
1 sibling, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2017-10-16 13:24 UTC (permalink / raw)
To: Muriithi Frederick Muriuki; +Cc: 27548-done
Muriithi Frederick Muriuki <fredmanglis@gmail.com> skribis:
> * gnu/packages/python.scm (python-xenon, python2-xenon) New variables.
This was pushed as 2038a48f4d a while back.
Thanks again,
Ludo'.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-16 13:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-01 14:44 [bug#27548] [PATCH] gnu: Add python-xenon Muriithi Frederick Muriuki
2017-07-11 19:03 ` Marius Bakke
2017-10-16 13:24 ` bug#27548: " Ludovic Courtès
2017-10-16 13:25 ` [bug#27548] " Frederick Muriithi
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.