From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV0S7-0007wf-ML for guix-patches@gnu.org; Tue, 11 Jul 2017 15:04:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dV0S2-0005ez-Gk for guix-patches@gnu.org; Tue, 11 Jul 2017 15:04:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59873) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dV0S2-0005ep-5r for guix-patches@gnu.org; Tue, 11 Jul 2017 15:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dV0S1-0001SF-QS for guix-patches@gnu.org; Tue, 11 Jul 2017 15:04:01 -0400 Subject: [bug#27548] [PATCH] gnu: Add python-xenon Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170701144420.24120-1-fredmanglis@gmail.com> References: <20170701144420.24120-1-fredmanglis@gmail.com> Date: Tue, 11 Jul 2017 21:03:24 +0200 Message-ID: <877ezelrsz.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Muriithi Frederick Muriuki , 27548@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! Sorry for the slooow response :-) The patch mostly LGTM. A few minor comments: Muriithi Frederick Muriuki writes: > * gnu/packages/python.scm (python-xenon, python2-xenon) New variables. [...] > +(define-public python-xenon > + (package > + (name "python-xenon") > + (version "0.5.1") It looks like 0.5.2 was recently released. Can you try updating to it? > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "xenon" version)) > + (sha256 > + (base32 > + "14kby2y48vp3sgwxqlm5d5789yibqwb1qli5fwcmdqg3iayrbklc")))) > + (build-system python-build-system) > + (native-inputs > + `(("python-pyyaml" ,python-pyyaml) > + ("python-radon" ,python-radon) > + ("python-requests" ,python-requests) > + ("python-flake8" ,python-flake8) Indentation is off :) > + ("python-tox" ,python-tox))) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-before 'build 'patch-test-requirements > + (lambda* (#:key inputs #:allow-other-keys) > + ;; Update requirements from dependecy=3D=3Dversion Missing letter here: ^^^ > + ;; to dependency>=3Dversion > + (substitute* "requirements.txt" > + (("=3D=3D") ">=3D") > + ((",<1.5.0") "")) > + ;; Remove httpretty dependency for tests > + (substitute* "setup.py" > + (("httpretty") "")) Why is this necessary? Can you expand on this comment? > + #t))))) > + (home-page "https://xenon.readthedocs.org/") > + (synopsis > + "Monitor code metrics for Python on your CI server") > + (description > + "@code{Xenon} is a monitoring tool based on Radon. It monitors cod= e=E2=80=99s I think we can drop @code here since it's used as a name. Side note: It would be cool if we could cross-reference packages in descriptions. Sorry for the nit-picks! I'll go through the other patches shortly. > +complexity. Ideally, @code{xenon} is run every time code is committed. = Through > +command line options, various thresholds can be set for the complexity o= f code. > +It will fail (i.e. it will exit with a non-zero exit code) when any of = these > +equirements is not met.") > + (license license:expat))) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlllIPwACgkQoqBt8qM6 VPqg9wgAicdwfRaNvU1gm3pIqge2aJLGQF1zO76PZBUDJcZIF0j3rGfv/Krpa1/V k0hQ94Me2www/Ctvqo/vFwPM21/Pg0wjbHrh71NZB/0w/yQR7+a3JDSRHlaX6iIJ b/wtkaLljZlEkw0w8A1auuUa2fNTtb3LuRM/KEp6giO3030nM9ix8eWon1lh6sjg 9N0Wa3GU6IEsirmFe3jzCmTHKOInUK1Nb96WLtEtdnF/Xd1e4BU/KvYZK2gbwsQp UCBtVhaaaWXZBnqSCq5uqCx2MoLn/OQVSPslAk88qXV45aMb4vYkzSGa4Hv2jTFx Ru/E2zHBPSmy05njI42ciRfIURF2Qw== =KMnN -----END PGP SIGNATURE----- --=-=-=--