From: Marius Bakke <mbakke@fastmail.com>
To: Muriithi Frederick Muriuki <fredmanglis@gmail.com>,
27548@debbugs.gnu.org
Subject: [bug#27548] [PATCH] gnu: Add python-xenon
Date: Tue, 11 Jul 2017 21:03:24 +0200 [thread overview]
Message-ID: <877ezelrsz.fsf@fastmail.com> (raw)
In-Reply-To: <20170701144420.24120-1-fredmanglis@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2414 bytes --]
Hello!
Sorry for the slooow response :-)
The patch mostly LGTM. A few minor comments:
Muriithi Frederick Muriuki <fredmanglis@gmail.com> writes:
> * gnu/packages/python.scm (python-xenon, python2-xenon) New variables.
[...]
> +(define-public python-xenon
> + (package
> + (name "python-xenon")
> + (version "0.5.1")
It looks like 0.5.2 was recently released. Can you try updating to it?
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "xenon" version))
> + (sha256
> + (base32
> + "14kby2y48vp3sgwxqlm5d5789yibqwb1qli5fwcmdqg3iayrbklc"))))
> + (build-system python-build-system)
> + (native-inputs
> + `(("python-pyyaml" ,python-pyyaml)
> + ("python-radon" ,python-radon)
> + ("python-requests" ,python-requests)
> + ("python-flake8" ,python-flake8)
Indentation is off :)
> + ("python-tox" ,python-tox)))
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'build 'patch-test-requirements
> + (lambda* (#:key inputs #:allow-other-keys)
> + ;; Update requirements from dependecy==version
Missing letter here: ^^^
> + ;; to dependency>=version
> + (substitute* "requirements.txt"
> + (("==") ">=")
> + ((",<1.5.0") ""))
> + ;; Remove httpretty dependency for tests
> + (substitute* "setup.py"
> + (("httpretty") ""))
Why is this necessary? Can you expand on this comment?
> + #t)))))
> + (home-page "https://xenon.readthedocs.org/")
> + (synopsis
> + "Monitor code metrics for Python on your CI server")
> + (description
> + "@code{Xenon} is a monitoring tool based on Radon. It monitors code’s
I think we can drop @code here since it's used as a name. Side note: It
would be cool if we could cross-reference packages in descriptions.
Sorry for the nit-picks! I'll go through the other patches shortly.
> +complexity. Ideally, @code{xenon} is run every time code is committed. Through
> +command line options, various thresholds can be set for the complexity of code.
> +It will fail (i.e. it will exit with a non-zero exit code) when any of these
> +equirements is not met.")
> + (license license:expat)))
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-07-11 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 14:44 [bug#27548] [PATCH] gnu: Add python-xenon Muriithi Frederick Muriuki
2017-07-11 19:03 ` Marius Bakke [this message]
2017-10-16 13:24 ` bug#27548: " Ludovic Courtès
2017-10-16 13:25 ` [bug#27548] " Frederick Muriithi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ezelrsz.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=27548@debbugs.gnu.org \
--cc=fredmanglis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.