* [bug#29386] Update taglib to 1.11.1.
@ 2017-11-21 21:11 Pierre Langlois
2017-11-21 21:25 ` bug#29386: " Marius Bakke
0 siblings, 1 reply; 3+ messages in thread
From: Pierre Langlois @ 2017-11-21 21:11 UTC (permalink / raw)
To: 29386
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
Hello Guix!
This is a patch to update taglib. I've had to enable building as a
shared library otherwise gst-plugins-good would fail to link. Also,
`guix lint' warned about the home page redirecting to http://taglib.org
so I thought I'd fix that too.
Finally, I tried to enable the tests by adding "-DBUILD_TESTS" as a
configure flag but they are explicitely disabled if building the shared
library:
~~~
if(BUILD_TESTS AND NOT BUILD_SHARED_LIBS)
enable_testing()
add_subdirectory(tests)
endif()
~~~
Oh well, how does this look?
Thanks!
Pierre
[-- Attachment #2: 0001-gnu-taglib-Update-to-1.11.1-and-fix-home-page.patch --]
[-- Type: text/x-patch, Size: 2091 bytes --]
From 994f090fb285ff7c09a462e87c48e50c3d0e45dc Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Tue, 21 Nov 2017 09:49:35 +0000
Subject: [PATCH] gnu: taglib: Update to 1.11.1 and fix home page.
* gnu/packages/mp3.scm (taglib)[version]: Update to 1.11.1.
[arguments]: Configure with -DBUILD_SHARED_LIBS=ON.
[home-page]: Change to http://taglig.org.
---
gnu/packages/mp3.scm | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 1860997e0..fbb924ba5 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -4,6 +4,7 @@
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
+;;; Copyright © 2017 Pierre Langlois <pierre.langlois@gmx.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -151,18 +152,20 @@ a highly stable and efficient implementation.")
(define-public taglib
(package
(name "taglib")
- (version "1.10")
+ (version "1.11.1")
(source (origin
(method url-fetch)
(uri (string-append "http://taglib.github.io/releases/taglib-"
version ".tar.gz"))
(sha256
(base32
- "1alv6vp72p0x9i9yscmz2a71anjwqy53y9pbcbqxvc1c0i82vhr4"))))
+ "0ssjcdjv4qf9liph5ry1kngam1y7zp8fzr9xv4wzzrma22kabldn"))))
(build-system cmake-build-system)
- (arguments '(#:tests? #f)) ;no 'test' target
+ (arguments
+ '(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on.
+ #:configure-flags (list "-DBUILD_SHARED_LIBS=ON")))
(inputs `(("zlib" ,zlib)))
- (home-page "http://developer.kde.org/~wheeler/taglib.html")
+ (home-page "http://taglib.org")
(synopsis "Library to access audio file meta-data")
(description
"TagLib is a C++ library for reading and editing the meta-data of several
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#29386: Update taglib to 1.11.1.
2017-11-21 21:11 [bug#29386] Update taglib to 1.11.1 Pierre Langlois
@ 2017-11-21 21:25 ` Marius Bakke
2017-11-21 21:29 ` [bug#29386] " Pierre Langlois
0 siblings, 1 reply; 3+ messages in thread
From: Marius Bakke @ 2017-11-21 21:25 UTC (permalink / raw)
To: Pierre Langlois, 29386-done
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
Pierre Langlois <pierre.langlois@gmx.com> writes:
> Hello Guix!
>
> This is a patch to update taglib. I've had to enable building as a
> shared library otherwise gst-plugins-good would fail to link. Also,
> `guix lint' warned about the home page redirecting to http://taglib.org
> so I thought I'd fix that too.
Hello Pierre,
Thank you for this patch, and for checking dependent packages! I've
applied it after fixing a typo in the commit message (home page).
> Finally, I tried to enable the tests by adding "-DBUILD_TESTS" as a
> configure flag but they are explicitely disabled if building the shared
> library:
> ~~~
> if(BUILD_TESTS AND NOT BUILD_SHARED_LIBS)
> enable_testing()
> add_subdirectory(tests)
> endif()
> ~~~
>
> Oh well, how does this look?
OK! Perhaps we could do a separate build just for the tests, but that
should be in a standalone patch anyway.
Pushed as d1451fa0d0b27a20ef3a1b3fe8d53a995f0c4d85.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#29386] Update taglib to 1.11.1.
2017-11-21 21:25 ` bug#29386: " Marius Bakke
@ 2017-11-21 21:29 ` Pierre Langlois
0 siblings, 0 replies; 3+ messages in thread
From: Pierre Langlois @ 2017-11-21 21:29 UTC (permalink / raw)
To: Marius Bakke; +Cc: 29386-done
Marius Bakke writes:
> Pierre Langlois <pierre.langlois@gmx.com> writes:
>
>> Hello Guix!
>>
>> This is a patch to update taglib. I've had to enable building
>> as a
>> shared library otherwise gst-plugins-good would fail to
>> link. Also,
>> `guix lint' warned about the home page redirecting to
>> http://taglib.org
>> so I thought I'd fix that too.
>
> Hello Pierre,
>
> Thank you for this patch, and for checking dependent packages!
> I've
> applied it after fixing a typo in the commit message (home
> page).
>
>> Finally, I tried to enable the tests by adding "-DBUILD_TESTS"
>> as a
>> configure flag but they are explicitely disabled if building
>> the shared
>> library:
>> ~~~
>> if(BUILD_TESTS AND NOT BUILD_SHARED_LIBS)
>> enable_testing()
>> add_subdirectory(tests)
>> endif()
>> ~~~
>>
>> Oh well, how does this look?
>
> OK! Perhaps we could do a separate build just for the tests,
> but that
> should be in a standalone patch anyway.
>
> Pushed as d1451fa0d0b27a20ef3a1b3fe8d53a995f0c4d85.
That was quick! Thank you!
Pierre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-21 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-21 21:11 [bug#29386] Update taglib to 1.11.1 Pierre Langlois
2017-11-21 21:25 ` bug#29386: " Marius Bakke
2017-11-21 21:29 ` [bug#29386] " Pierre Langlois
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).