From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55071)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eHG7J-0006KR-Ex
	for guix-patches@gnu.org; Tue, 21 Nov 2017 16:30:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eHG7G-00007J-Bl
	for guix-patches@gnu.org; Tue, 21 Nov 2017 16:30:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:42837)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eHG7G-00007C-8r
	for guix-patches@gnu.org; Tue, 21 Nov 2017 16:30:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eHG7F-0005EH-RX
	for guix-patches@gnu.org; Tue, 21 Nov 2017 16:30:01 -0500
Subject: [bug#29386] Update taglib to 1.11.1.
Resent-Message-ID: <handler.29386.D29386.151129976120031@debbugs.gnu.org>
References: <cubshd71gm9.fsf@gmx.com> <8760a3qq7p.fsf@fastmail.com>
From: Pierre Langlois <pierre.langlois@gmx.com>
In-reply-to: <8760a3qq7p.fsf@fastmail.com>
Date: Tue, 21 Nov 2017 21:29:08 +0000
Message-ID: <cubr2sr1ftn.fsf@gmx.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29386-done@debbugs.gnu.org


Marius Bakke writes:

> Pierre Langlois <pierre.langlois@gmx.com> writes:
>
>> Hello Guix!
>>
>> This is a patch to update taglib. I've had to enable building 
>> as a
>> shared library otherwise gst-plugins-good would fail to 
>> link. Also,
>> `guix lint' warned about the home page redirecting to 
>> http://taglib.org
>> so I thought I'd fix that too.
>
> Hello Pierre,
>
> Thank you for this patch, and for checking dependent packages! 
> I've
> applied it after fixing a typo in the commit message (home 
> page).
>
>> Finally, I tried to enable the tests by adding "-DBUILD_TESTS" 
>> as a
>> configure flag but they are explicitely disabled if building 
>> the shared
>> library:
>> ~~~
>> if(BUILD_TESTS AND NOT BUILD_SHARED_LIBS)
>>   enable_testing()
>>   add_subdirectory(tests)
>> endif()
>> ~~~
>>
>> Oh well, how does this look?
>
> OK!  Perhaps we could do a separate build just for the tests, 
> but that
> should be in a standalone patch anyway.
>
> Pushed as d1451fa0d0b27a20ef3a1b3fe8d53a995f0c4d85.

That was quick! Thank you!

Pierre